linux-toradex.git/drivers/misc/sgi-xp, branch v5.16

net: sgi-xp: use eth_hw_addr_set()

2021-10-29T12:17:21+00:00

Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it go through appropriate helpers.

Signed-off-by: Jakub Kicinski 
Signed-off-by: David S. Miller

sgi-xpc: Replace deprecated CPU-hotplug functions.

2021-08-03T14:30:36+00:00

The functions get_online_cpus() and put_online_cpus() have been
deprecated during the CPU hotplug rework. They map directly to
cpus_read_lock() and cpus_read_unlock().

Replace deprecated CPU-hotplug functions with the official version.
The behavior remains unchanged.

Cc: Robin Holt 
Cc: Steve Wahl 
Cc: Mike Travis 
Cc: Arnd Bergmann 
Cc: Greg Kroah-Hartman 
Signed-off-by: Sebastian Andrzej Siewior 
Link: https://lore.kernel.org/r/20210803141621.780504-17-bigeasy@linutronix.de
Signed-off-by: Greg Kroah-Hartman

misc: sgi-xp: xp_main: make some symbols static

2021-03-28T12:39:26+00:00

The sparse tool complains as follows:

drivers/misc/sgi-xp/xp_main.c:24:22: warning:
 symbol 'xp_dbg_name' was not declared. Should it be static?
drivers/misc/sgi-xp/xp_main.c:28:15: warning:
 symbol 'xp_dbg_subname' was not declared. Should it be static?

These symbols are not used outside of xp_main.c, so this
commit marks them static.

Reported-by: Hulk Robot 
Signed-off-by: Zou Wei 
Link: https://lore.kernel.org/r/20210324084823.7393-1-zou_wei@huawei.com
Signed-off-by: Greg Kroah-Hartman

misc/sgi-xp: use NULL instead of using plain integer as pointer

2021-03-24T07:26:30+00:00

This fixes the following sparse warnings:
drivers/misc/sgi-xp/xpc_main.c:210:23: warning: Using plain integer as
NULL pointer

Reported-by: Abaci Robot 
Reviewed-by: Steve Wahl	
Signed-off-by: Yang Li 
Link: https://lore.kernel.org/r/1615885041-68750-1-git-send-email-yang.lee@linux.alibaba.com
Signed-off-by: Greg Kroah-Hartman

sgi-xp: remove h from printk format specifier

2021-01-26T18:36:02+00:00

This change fixes the checkpatch warning described in this commit
commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
  unnecessary %h[xudi] and %hh[xudi]")

Standard integer promotion is already done and %hx and %hhx is useless
so do not encourage the use of %hh[xudi] or %h[xudi].

Reviewed-By: Steve Wahl 
Signed-off-by: Tom Rix 
Link: https://lore.kernel.org/r/20210123160003.1777766-1-trix@redhat.com
Signed-off-by: Greg Kroah-Hartman

misc/sgi-xp: Replace in_interrupt() usage

2020-12-09T18:35:52+00:00

The usage of in_interrupt() in xpc_partition_disengaged() is clearly
intended to avoid canceling the timeout timer when the function is invoked
from the timer callback.

While in_interrupt() is deprecated and ill defined as it does not provide
what the name suggests it catches the intended case.

Add an argument to xpc_partition_disengaged() which is true if called
from timer and otherwise false.
Use del_timer_sync() instead of del_singleshot_timer_sync() which is the
same thing.

Note: This does not prevent reentrancy into the function as the function
has no concurrency control and timer callback and regular task context
callers can happen concurrently on different CPUs or the timer can
interrupt the task context before it is able to cancel it.

While the only driver which is providing the arch_xpc_ops callbacks
(xpc_uv) seems not to have a reentrancy problem and the only negative
effect would be a double dev_info() entry in dmesg, the whole mechanism is
conceptually broken.

But that's not subject of this cleanup endeavour and left as an exercise to
the folks who might have interest to make that code fully correct.

[bigeasy: Add the argument, use del_timer_sync().]

Cc: Greg Kroah-Hartman 
Cc: Cliff Whickman 
Cc: Arnd Bergmann 
Cc: Robin Holt 
Cc: Steve Wahl 
Cc: Dimitri Sivanich 
Cc: Russ Anderson 
Reviewed-by: Steve Wahl 
Signed-off-by: Thomas Gleixner 
Signed-off-by: Sebastian Andrzej Siewior 
Link: https://lore.kernel.org/r/20201119103151.ppo45mj53ulbxjx4@linutronix.de
Signed-off-by: Greg Kroah-Hartman

x86/platform/uv: Update Copyrights to conform to HPE standards

2020-10-07T07:10:07+00:00

Add Copyrights to those files that have been updated for UV5 changes.

Signed-off-by: Mike Travis 
Signed-off-by: Borislav Petkov 
Link: https://lkml.kernel.org/r/20201005203929.148656-14-mike.travis@hpe.com

drivers/misc/sgi-xp: Adjust references in UV kernel modules

2020-10-07T06:56:05+00:00

Remove the define is_uv() is_uv_system and just use the latter as is.
This removes a conflict with a new symbol in the generated uv_mmrs.h
file (is_uv()).

Signed-off-by: Mike Travis 
Signed-off-by: Borislav Petkov 
Reviewed-by: Dimitri Sivanich 
Reviewed-by: Steve Wahl 
Link: https://lkml.kernel.org/r/20201005203929.148656-4-mike.travis@hpe.com

treewide: Use fallthrough pseudo-keyword

2020-08-23T22:36:59+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva

misc: sgi-xp: xp_main: Staticify local functions xp_init() and xp_exit()

2020-07-01T13:08:02+00:00

These functions are not exported and no external prototypes exist

Fixes W=1 kernel build warning(s):

 drivers/misc/sgi-xp/xp_main.c:227:1: warning: no previous prototype for ‘xp_init’ [-Wmissing-prototypes]
 227 | xp_init(void)
 | ^~~~~~~
 drivers/misc/sgi-xp/xp_main.c:250:1: warning: no previous prototype for ‘xp_exit’ [-Wmissing-prototypes]
 250 | xp_exit(void)
 | ^~~~~~~

Cc: Cliff Whickman 
Cc: Robin Holt 
Cc: Dean Nelson 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20200701083118.45744-5-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman