linux-toradex.git/drivers/misc, branch v3.14.3

mei: ignore client writing state during cb completion

2014-05-06T14:59:25+00:00

commit 34ec43661fe8f1977dd0f05353302ae2ed10aabb upstream.

Ignore client writing state during cb completion to fix a memory
leak.

When moving cbs to the completion list we should not look at
writing_state as this state can be already overwritten by next
write, the fact that a cb is on the write waiting list means
that it was already written to the HW and we can safely complete it.

Same pays for wait in poll handler, we do not have to check the state
wake is done after completion list processing.

Signed-off-by: Alexander Usyskin 
Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: me: do not load the driver if the FW doesn't support MEI interface

2014-05-06T14:59:25+00:00

commit 5e6533a6f52f1a8283b2f818f5828be99a417dd6 upstream.

NM and SPS  FW types that may run on ME device on server platforms
do not have valid MEI/HECI interface and driver should not
be bound to it as this might lead to system hung.
In practice not all BIOSes effectively hide such devices from the
OS and in some cases it is not possible.

We determine FW type by examining Host FW status registers in order to
unbind the driver.
In this patch we are adding check for ME on Cougar Point, Lynx Point
Devices

Signed-off-by: Tomas Winkler 
Tested-by: Nikola Ciprich 
Signed-off-by: Greg Kroah-Hartman

mei: fix memory leak of pending write cb objects

2014-05-06T14:59:24+00:00

commit cc99ecfdac01215594c73907726b12f251c21e20 upstream.

Write callbacks are released on the write completed path but
when file handler is closed before the writes are
completed those are left dangling on write and write_waiting queues.

We add mei_io_list_free function to perform this task

Also move static functions to client.c form client.h

Signed-off-by: Tomas Winkler 
Signed-off-by: Alexander Usyskin 
Signed-off-by: Greg Kroah-Hartman

mm: fix GFP_THISNODE callers and clarify

2014-03-11T00:26:19+00:00

GFP_THISNODE is for callers that implement their own clever fallback to
remote nodes.  It restricts the allocation to the specified node and
does not invoke reclaim, assuming that the caller will take care of it
when the fallback fails, e.g.  through a subsequent allocation request
without GFP_THISNODE set.

However, many current GFP_THISNODE users only want the node exclusive
aspect of the flag, without actually implementing their own fallback or
triggering reclaim if necessary.  This results in things like page
migration failing prematurely even when there is easily reclaimable
memory available, unless kswapd happens to be running already or a
concurrent allocation attempt triggers the necessary reclaim.

Convert all callsites that don't implement their own fallback strategy
to __GFP_THISNODE.  This restricts the allocation a single node too, but
at the same time allows the allocator to enter the slowpath, wake
kswapd, and invoke direct reclaim if necessary, to make the allocation
happen when memory is full.

Signed-off-by: Johannes Weiner 
Acked-by: Rik van Riel 
Cc: Jan Stancek 
Cc: Mel Gorman 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mei: set client's read_cb to NULL when flow control fails

2014-02-18T18:07:36+00:00

In mei_cl_read_start(), if it fails to send flow control request, it
will release "cl->read_cb" but forget to set pointer to NULL, leaving
"cl->read_cb" still pointing to random memory, next time this client is
operated like mei_release(), it has chance to refer to this wrong pointer.

Fixes:  PANIC at kfree in mei_release()

[228781.826904] Call Trace:
[228781.829737]  [] ? mei_cl_unlink+0x48/0xa0
[228781.835283]  [] mei_io_cb_free+0x17/0x30
[228781.840733]  [] mei_release+0xa8/0x180
[228781.845989]  [] ? __fsnotify_parent+0xa0/0xf0
[228781.851925]  [] __fput+0xd9/0x200
[228781.856696]  [] ____fput+0xd/0x10
[228781.861467]  [] task_work_run+0x81/0xb0
[228781.866821]  [] do_exit+0x283/0xa00
[228781.871786]  [] ? kprobe_flush_task+0x66/0xc0
[228781.877722]  [] ? __dequeue_signal+0x18/0x1a0
[228781.883657]  [] ? dequeue_signal+0x32/0x190
[228781.889397]  [] do_group_exit+0x34/0xa0
[228781.894750]  [] get_signal_to_deliver+0x206/0x610
[228781.901075]  [] do_signal+0x38/0x100
[228781.906136]  [] ? mei_read+0x42c/0x4e0
[228781.911393]  [] ? wake_up_bit+0x30/0x30
[228781.916745]  [] ? mei_poll+0x120/0x120
[228781.922001]  [] ? vfs_read+0x89/0x160
[228781.927158]  [] ? mei_poll+0x120/0x120
[228781.932414]  [] ? fget_light+0x44/0xe0
[228781.937670]  [] ? SyS_read+0x68/0x80
[228781.942730]  [] do_notify_resume+0x55/0x70
[228781.948376]  [] work_notifysig+0x29/0x30
[228781.953827]  [] ? bad_area+0x5/0x3e

Cc: stable  # 3.9+
Signed-off-by: Chao Bi 
Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

Merge tag 'char-misc-3.14-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc

2014-02-15T00:13:00+00:00

Pull char/misc fixes from Greg KH:
 "Here are some small char/misc driver fixes, along with some
  documentation updates, for 3.14-rc3.  Nothing major, just a number of
  fixes for reported issues"

* tag 'char-misc-3.14-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc:
  Revert "misc: eeprom: sunxi: Add new compatibles"
  Revert "ARM: sunxi: dt: Convert to the new SID compatibles"
  misc: mic: fix possible signed underflow (undefined behavior) in userspace API
  ARM: sunxi: dt: Convert to the new SID compatibles
  misc: eeprom: sunxi: Add new compatibles
  misc: genwqe: Fix potential memory leak when pinning memory
  Documentation:Update Documentation/zh_CN/arm64/memory.txt
  Documentation:Update Documentation/zh_CN/arm64/booting.txt
  Documentation:Chinese translation of Documentation/arm64/tagged-pointers.txt
  raw: set range for MAX_RAW_DEVS
  raw: test against runtime value of max_raw_minors
  Drivers: hv: vmbus: Don't timeout during the initial connection with host
  Drivers: hv: vmbus: Specify the target CPU that should receive notification
  VME: Correct read/write alignment algorithm
  mei: don't unset read cb ptr on reset
  mei: clear write cb from waiting list on reset

Revert "misc: eeprom: sunxi: Add new compatibles"

2014-02-14T19:16:08+00:00

This reverts commit f0de8e04a7201a2000f3c6d09732c11e7f35d42d, it is
incorrect, a future patch will fix this up properly.

Cc: Maxime Ripard 
Signed-off-by: Greg Kroah-Hartman

drivers/misc/sgi-gru/grukdump.c: unlocking should be conditional in gru_dump_context()

2014-02-11T00:01:39+00:00

I was reviewing this and noticed that unlocking should be conditional on
the error path.  I've changed it to unlock and return directly since we
only do it once and it seems unlikely to change in the near future.

Signed-off-by: Dan Carpenter 
Acked-by: Dimitri Sivanich 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

misc: mic: fix possible signed underflow (undefined behavior) in userspace API

2014-02-07T23:30:34+00:00

iovcnt is declared as a signed integer in both the userspace API and
as a local variable in mic_virtio.c. The while() loop in mic_virtio.c
iterates until the local variable iovcnt reaches the value 0. If
userspace passes e.g. INT_MIN as iovcnt field, this loop then appears
to depend on an undefined behavior (signed underflow) to complete.
The fix is to use unsigned integers in both the userspace API and
the local variable.

This issue was reported @ https://lkml.org/lkml/2014/1/10/10

Reported-by: Mathieu Desnoyers 
Reviewed-by: Ashutosh Dixit 
Signed-off-by: Sudeep Dutt 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

misc: eeprom: sunxi: Add new compatibles

2014-02-07T23:30:34+00:00

The Allwinner A10 compatibles were following a slightly different compatible
patterns than the rest of the SoCs for historical reasons. Add compatibles
matching the other pattern to the SID driver for consistency, and keep the
older one for backward compatibility.

Signed-off-by: Maxime Ripard 
Signed-off-by: Greg Kroah-Hartman