linux-toradex.git/drivers/mmc/core/mmc_ops.c, branch v5.0

mmc: core: Cleanup BKOPS support

2018-12-17T08:01:15+00:00

It's been ~6 years ago since we introduced the BKOPS support for eMMC
cards. The current code is a bit messy and primarily that's because it
prepares to support running BKOPS in an asynchronous mode. However, that
mode has never been fully implemented/enabled. Instead BKOPS is always
executed in synchronously, when the card has reported an urgent BKOPS
level.

For these reasons, let's make the code more readable by dropping the unused
parts. Let's also rename mmc_start_bkops() to mmc_run_bkops(), as to make
it more descriptive.

Cc: Jaehoon Chung 
Signed-off-by: Ulf Hansson

mmc: core: Drop redundant check in mmc_send_hpi_cmd()

2018-12-17T08:01:15+00:00

There is no point checking if HPI is supported in mmc_send_hpi_cmd() as
mmc_interrupt_hpi(), which is the only caller, already checks if HPI has
been enabled. Therefore, let's drop the check and the corresponding error
path.

Signed-off-by: Ulf Hansson

mmc: core: Adjust and reuse the macro of R1_STATUS(x)

2018-07-16T09:21:45+00:00

R1_STATUS(x) now is only used by ioctl_rpmb_card_status_poll(),
which checks all bits as possible. But according to the spec,
bit 17 and bit 18 should be ignored, as well bit 14 which is
reserved(must be set to 0) quoting from the spec and these rule
apply to all places checking the device status. So change
its checking from 0xFFFFE000 to 0xFFF9A000.

As a bonus, we reuse it for mmc_do_erase() as well as
mmc_switch_status_error().
(1) Currently mmc_switch_status_error() doesn't check bit 25, but
it means device is locked but not unlocked by CMD42 prior to any
operations which need check busy, which is also not allowed.
(2) mmc_do_erase() also forgot to to check bit 15, WP_ERASE_SKIP.
The spec says "Only partial address space was erased due to existing
write protected blocks.", which obviously means we should fail this I/O.
Otherwise, the partial erased data stored in nonvalatile flash violates
the data integrity from the view of I/O owner, which probably confuse
it when further used.

So reusing R1_STATUS for them not only improve the readability but also
slove real problems.

Signed-off-by: Shawn Lin 
Signed-off-by: Ulf Hansson

mmc: core: Avoid hanging to claim host for mmc via some nested calls

2018-02-27T14:12:37+00:00

As the block layer, since the conversion to blkmq, claims the host using a
context, a following nested call to mmc_claim_host(), which isn't using a
context, may hang.

Calling mmc_interrupt_hpi() and mmc_read_bkops_status() via the mmc block
layer, may suffer from this problem, as these functions are calling
mmc_claim|release_host().

Let's fix the problem by removing the calls to mmc_claim|release_host()
from the above mentioned functions and instead make the callers responsible
of claiming/releasing the host. As a matter of fact, the existing callers
already deals with it.

Fixes: 81196976ed94 ("mmc: block: Add blk-mq support")
Reported-by: Dmitry Osipenko 
Suggested-by: Adrian Hunter 
Tested-by: Dmitry Osipenko 
Signed-off-by: Ulf Hansson 
Acked-by: Adrian Hunter 
Reviewed-by: Shawn Lin

mmc: core: Export a few functions needed for blkmq support

2017-10-30T10:45:56+00:00

The following functions are needed by the mmc block device driver, once it
converts to blkmq, therefore let's export them.

mmc_start_bkops()
mmc_start_request()
mmc_retune_hold_now()
mmc_retune_release()

Signed-off-by: Adrian Hunter 
Reviewed-by: Linus Walleij 
Signed-off-by: Ulf Hansson

mmc: core: Remove unnecessary host claim

2017-10-30T10:45:49+00:00

Callers already have the host claimed, so remove the unnecessary
calls to mmc_claim_host() and mmc_release_host().

Signed-off-by: Adrian Hunter 
Reviewed-by: Linus Walleij 
Signed-off-by: Ulf Hansson

mmc: ops: export mmc_get_status()

2017-08-30T13:03:39+00:00

This function retrieves the status of the card with the default
number of retries. Since the block layer wants to use this, and
since the block layer is a loadable kernel module, we need to
export this symbol.

Signed-off-by: Linus Walleij 
Signed-off-by: Ulf Hansson

mmc: mmc_ops: fix a typo for comment of mmc_start_bkops

2017-08-30T12:01:28+00:00

Just a trivial fix for that found by reading the code.

Signed-off-by: Shawn Lin 
Reviewed-by: Jaehoon Chung 
Signed-off-by: Ulf Hansson

mmc: core: Clarify code for sending CSD

2017-06-20T08:30:47+00:00

To make the code more consistent and to increase readability, add an
mmc_spi_send_csd() function, which gets called from mmc_send_csd() in case
of SPI mode.

Signed-off-by: Ulf Hansson 
Reviewed-by: Linus Walleij 
Reviewed-by: Shawn Lin

mmc: core: Drop mmc_all_send_cid() and use mmc_send_cxd_native() instead

2017-06-20T08:30:46+00:00

Signed-off-by: Ulf Hansson 
Reviewed-by: Linus Walleij 
Reviewed-by: Shawn Lin