linux-toradex.git/drivers/mmc/core/sdio.c, branch v4.10

mmc: core: remove BUG_ONs from sdio

2016-12-05T09:31:08+00:00

BUG_ONs doesn't help anything except for stop the system from
running. If it occurs, it implies we should deploy proper error
handling for that. So this patch is gonna discard these meaningless
BUG_ONs and deploy error handling if needed.

Signed-off-by: Shawn Lin 
Signed-off-by: Ulf Hansson

mmc: core: remove redundant memset of sdio_read_cccr

2016-03-17T13:54:41+00:00

When initializing sdio card, we get struct mmc_card
from mmc_alloc_card which allocates it by kzalloc. So we
don't need another memset while reading cccr.

Signed-off-by: Shawn Lin 
Signed-off-by: Ulf Hansson

mmc: core: Enable tuning according to the actual timing

2016-01-14T09:59:09+00:00

While in sdhci_execute_tuning() the choice whether or not to enable the
tuning is done on the actual timing, in the mmc_sdio_init_uhs_card() the
check is done on the capability of the card.

This difference is causing some issues with some SDIO cards in DDR50
mode where the CDM19 is wrongly issued.

With this patch we modify the check in both
mmc_(sd|sdio)_init_uhs_card() functions to take the proper decision
only according to the actual timing specification.

Cc: stable@vger.kernel.org
Signed-off-by: Carlo Caione 
Signed-off-by: Ulf Hansson

mmc: sdio: Fix invalid vdd in voltage switch power cycle

2015-12-22T10:32:15+00:00

The 'ocr' parameter passed to mmc_set_signal_voltage()
defines the power-on voltage used when power cycling
after a failure to set the voltage.  However, in the
case of mmc_sdio_init_card(), the value passed has the
R4_18V_PRESENT flag set which is not valid for power-on
and results in an invalid vdd.  Fix by passing the card's
ocr value which does not have the flag.

Signed-off-by: Adrian Hunter 
Cc: stable@vger.kernel.org # v3.13+
Signed-off-by: Ulf Hansson

mmc: core: Remove MMC_CLKGATE

2015-10-26T15:00:09+00:00

MMC_CLKGATE was once invented to save power by gating the bus clock at
request inactivity. At that time it served its purpose. The modern way to
deal with power saving for these scenarios, is by using runtime PM.

Nowadays, several host drivers have deployed runtime PM, but for those
that haven't and which still cares power saving at request inactivity,
it's certainly time to deploy runtime PM as it has been around for several
years now.

To simplify code to mmc core and thus decrease maintenance efforts, this
patch removes all code related to MMC_CLKGATE.

Signed-off-by: Ulf Hansson 
Reviewed-by: Linus Walleij

mmc: core: Keep host claimed while invoking mmc_power_off|up()

2015-10-26T14:59:52+00:00

As mmc_claim_host() invokes pm_runtime_get_sync() for the mmc host device,
it's important that the host is kept claimed for *all* accesses to it via
the host_ops callbacks.

In some code paths for SDIO, particularly related to the PM support,
mmc_power_off|up() is invoked without keeping the host claimed. Let's fix
these.

Moreover, mmc_start|stop_host() also invokes mmc_power_off|up() without
claiming the host, let's fix these as well.

Signed-off-by: Ulf Hansson 
Acked-by: Kishon Vijay Abraham I

mmc: core: Record card drive strength

2015-06-01T07:07:13+00:00

In preparation for adding drive strength support
for eMMC, add drive_strength to struct mmc_card
to record the card drive strength for UHS-I modes
and HS200 / HS400. For eMMC this will be needed
when switching between HS200 and HS400.

Signed-off-by: Adrian Hunter 
Signed-off-by: Ulf Hansson

mmc: core: Factor out common code in drive strength selection

2015-06-01T07:07:12+00:00

Make a new function out of common code used for drive
strength selection.

Signed-off-by: Adrian Hunter 
Signed-off-by: Ulf Hansson

mmc: core: Add 'card' to drive strength selection callback

2015-06-01T07:07:12+00:00

In preparation for supporting also eMMC drive strength,
add the 'card' as a parameter so that the callback can
distinguish different types of cards if necessary.

Signed-off-by: Adrian Hunter 
Signed-off-by: Ulf Hansson

mmc: core: Simplify card drive strength mask

2015-06-01T07:07:11+00:00

Card drive strength selection uses a callback to
which a mask of supported drive strengths is passed.
Currently, the bits are checked against the values
in the SD specifications. That is not necessary
because the callback will anyway match the mask
against a valid value. Simplify by taking the mask
as is but still ensuring that the default mandatory
value (type B) is always supported.

Signed-off-by: Adrian Hunter 
Signed-off-by: Ulf Hansson