linux-toradex.git/drivers/mmc/core/sdio.c, branch v5.3.2

mmc: sdio: Drop unused in-parameter from mmc_sdio_init_card()

2019-07-10T11:20:17+00:00

The "powered_resume" in-parameter to mmc_sdio_init_card() has now become
redundant as all callers set it to 0. Therefore let's just drop it.

Signed-off-by: Ulf Hansson 
Reviewed-by: Douglas Anderson 
Tested-by: Douglas Anderson

mmc: sdio: Drop unused in-parameter to mmc_sdio_reinit_card()

2019-07-10T11:19:57+00:00

The "powered_resume" in-parameter to mmc_sdio_reinit_card() has now become
redundant as all callers set it to 0. Therefore let's just drop it.

Signed-off-by: Ulf Hansson 
Reviewed-by: Douglas Anderson 
Tested-by: Douglas Anderson

mmc: sdio: Don't re-initialize powered-on removable SDIO cards at resume

2019-07-10T11:19:31+00:00

It looks like the original idea behind always doing a re-initialization of
a removable SDIO card during system resume in mmc_sdio_resume(), is to try
to play safe to detect whether the card has been removed.

However, this seems like a really a bad idea as it will most likely screw
things up, especially when the card is expected to remain powered on during
system suspend by the SDIO func driver.

Let's fix this, simply by trusting that the detect work checks if the card
is alive and inserted, which is being scheduled at the PM_POST_SUSPEND
notification anyway.

Signed-off-by: Ulf Hansson 
Tested-by: Douglas Anderson 
Reviewed-by: Douglas Anderson

mmc: sdio: Drop powered-on re-init at runtime resume and HW reset

2019-07-10T11:18:56+00:00

To use the so called powered-on re-initialization of an SDIO card, the
power to the card must obviously have stayed on. If not, the initialization
will simply fail.

In the runtime suspend case, the card is always powered off. Hence, let's
drop the support for powered-on re-initialization during runtime resume, as
it doesn't make sense.

Moreover, during a HW reset, the point is to cut the power to the card and
then do fresh re-initialization. Therefore drop the support for powered-on
re-initialization during HW reset.

Signed-off-by: Ulf Hansson 
Fixes: ca8971ca5753 ("mmc: dw_mmc: Prevent runtime PM suspend when SDIO IRQs are enabled")
Tested-by: Douglas Anderson

mmc: sdio: Move comment about re-initialization to mmc_sdio_reinit_card()

2019-07-10T11:18:29+00:00

The comment in mmc_sdio_power_restore() belongs in mmc_sdio_reinit_card(),
which was created during a previous commit that re-factored some code. Fix
this by moving the comment into mmc_sdio_reinit_card().

Signed-off-by: Ulf Hansson 
Reviewed-by: Douglas Anderson

mmc: sdio: Drop mmc_claim|release_host() in mmc_sdio_power_restore()

2019-07-10T11:17:30+00:00

The function mmc_sdio_power_restore() is called either from
mmc_sdio_runtime_resume() or from mmc_sdio_hw_reset(). Both callers either
claims/releases the host or require its callers to do so. Therefore let's
drop the redundant calls to mmc_claim|release_host() in
mmc_sdio_power_restore().

Signed-off-by: Ulf Hansson 
Reviewed-by: Douglas Anderson 
Tested-by: Douglas Anderson

mmc: core: Prevent processing SDIO IRQs when the card is suspended

2019-06-18T12:06:32+00:00

Processing of SDIO IRQs must obviously be prevented while the card is
system suspended, otherwise we may end up trying to communicate with an
uninitialized SDIO card.

Reports throughout the years shows that this is not only a theoretical
problem, but a real issue. So, let's finally fix this problem, by keeping
track of the state for the card and bail out before processing the SDIO
IRQ, in case the card is suspended.

Cc: stable@vger.kernel.org
Reported-by: Douglas Anderson 
Tested-by: Douglas Anderson 
Signed-off-by: Ulf Hansson

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

2019-05-30T18:26:32+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license as published by
  the free software foundation either version 2 of the license or at
  your option any later version

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-or-later

has been chosen to replace the boilerplate/reference in 3029 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.de
Signed-off-by: Greg Kroah-Hartman

mmc: core: Add a debug print when the card may have been replaced

2019-02-28T08:28:27+00:00

If the card was removed in suspended state and a new one was inserted,
print a debug log when the check detects that it's not the old card.

Signed-off-by: hongjiefang 
Signed-off-by: Ulf Hansson

mmc: core: Drop the unused mmc_power_save|restore_host()

2018-07-16T09:21:45+00:00

The last user of mmc_power_save|restore_host() APIs is gone, hence let's
drop them. Drop also the corresponding bus_ops callback,
->power_save|restore() as those becomes redundant.

Cc: Tony Lindgren 
Cc: Eyal Reizer 
Signed-off-by: Ulf Hansson