linux-toradex.git/drivers/mmc/host/mvsdio.c, branch v3.10.31

mmc: mvsdio: use dev_() API instead of pr_() API

2013-03-22T17:29:47+00:00

The mvsdio driver was already using some dev_*() functions to print
some messages, but still using pr_*() functions for some others. This
patch converts all messages to use dev_*() functions.

Many of the pr_*() function calls were printing the output of
mmc_hostname() to preprend the message with an identifier for the
device. Since the dev_*() functions do that automatically, this patch
also gets rid of those string prefixes.

Signed-off-by: Thomas Petazzoni 
Signed-off-by: Chris Ball

mmc: mvsdio: fix non-DT probing of GPIOs

2013-03-22T17:29:46+00:00

Ralph Droms  reported that 3.9-rc was breaking the
SDIO interface on his Sheevaplug platform, and that the recent changes
to the mvsdio driver are responsible for this breakage. Precisely, the
regression has been introduced by 07728b77c03d (mmc: mvsdio: use
slot-gpio for card detect gpio).

After investigation, is turns out that the Sheevaplug does not have
any "card detect" GPIO, and the Sheevaplug has not been converted to
the Device Tree. Therefore, the Sheevaplug board code does not define
a value for the .gpio_card_detect field of the mvsdio_platform_data
structure, which means that its value is 0. Unfortunately,
gpio_is_valid() considers 0 as a valid GPIO, and therefore calls
mmc_gpio_request_cd(), which fails and makes the entire probing of the
driver fail.

In fact, in the previous mvsdio code, before the Device Tree binding
was introduced, 0 was not considered as a valid GPIO. Therefore, this
fix revert back to this behavior in the non-DT case, by setting the
gpio_card_detect and gpio_write_protect local variables to -EINVAL
when the corresponding fields of the mvsdio_platform_data structure
are set to zero (i.e, left undefined). Of course, it prevents to use
GPIO 0 as a card detect or write protect GPIO, but it was a defiency
of the previous non-DT code, and the fix moving forward is to convert
platforms to the Device Tree.

The problem has been reproduced successfully on the Kirkwood-based
Marvell DB-88F6281-BP Development Board (that doesn't use the Device
Tree) and the fix has proven to work properly, after of course
removing the gpio_card_detect field of the mvsdio_platform_data
instance for this board.

Reported-by: Ralph Droms 
Tested-by: Ralph Droms 
Signed-off-by: Thomas Petazzoni 
Signed-off-by: Chris Ball

mmc: mvsdio: use module_platform_driver_probe()

2013-03-22T16:29:12+00:00

This patch uses module_platform_driver_probe() macro which makes
the code smaller and simpler.

Signed-off-by: Jingoo Han 
Signed-off-by: Chris Ball

mmc: mvsdio: add pinctrl integration

2013-02-24T19:36:42+00:00

On many Marvell SoCs, the pins used for the SDIO interface are part of
the MPP pins, that are muxable pins. In order to get the muxing of
those pins correct, this commit integrates the mvsdio driver with the
pinctrl infrastructure by calling devm_pinctrl_get_select_default()
during ->probe().

Note that we permit this function to fail because not all Marvell
platforms have yet been fully converted to using the pinctrl
infrastructure.

Signed-off-by: Thomas Petazzoni 
Signed-off-by: Andrew Lunn 
Tested-by: Stefan Peter 
Tested-by: Florian Fainelli 
Signed-off-by: Jason Cooper 
Signed-off-by: Chris Ball

mmc: mvsdio: implement a Device Tree binding

2013-02-11T18:28:54+00:00

This patch adds a simple Device Tree binding for the mvsdio driver, as
well as the necessary documentation for it. Compatibility with non-DT
platforms is preserved, by keeping the platform_data based
initialization.

We introduce a small difference between non-DT and DT platforms: DT
platforms are required to provide a clocks = <...> property, which the
driver uses to get the frequency of the clock that goes to the SDIO
IP. The behaviour on non-DT platforms is kept unchanged: a clock
reference is not mandatory, but the clock frequency must be passed in
the "clock" field of the mvsdio_platform_data structure.

Signed-off-by: Thomas Petazzoni 
Signed-off-by: Andrew Lunn 
Tested-by: Stefan Peter 
Tested-by: Florian Fainelli 
Signed-off-by: Jason Cooper 
Signed-off-by: Chris Ball

mmc: mvsdio: use slot-gpio for card detect gpio

2013-02-11T18:28:53+00:00

The MMC core subsystem provides in drivers/mmc/core/slot-gpio.c a nice
set of helper functions to simplify the management of the card detect
GPIO in MMC host drivers. This patch migrates the mvsdio driver to
using those helpers, which will make the ->probe() code simpler, and
therefore ease the process of adding a Device Tree binding for this
driver.

Signed-off-by: Thomas Petazzoni 
Signed-off-by: Andrew Lunn 
Tested-by: Stefan Peter 
Tested-by: Florian Fainelli 
Signed-off-by: Jason Cooper 
Signed-off-by: Chris Ball

mmc: mvsdio: use slot-gpio infrastructure for write protect gpio

2013-02-11T18:28:53+00:00

The MMC core subsystem provides in drivers/mmc/core/slot-gpio.c a nice
set of helper functions to simplify the management of the write
protect GPIO in MMC host drivers. This patch migrates the mvsdio
driver to using those helpers, which will make the ->probe() code
simpler, and therefore ease the process of adding a Device Tree
binding for this driver.

Signed-off-by: Thomas Petazzoni 
Signed-off-by: Andrew Lunn 
Tested-by: Stefan Peter 
Tested-by: Florian Fainelli 
Signed-off-by: Jason Cooper 
Signed-off-by: Chris Ball

mmc: mvsdio: use devm_ API to simplify/correct error paths.

2013-01-23T01:08:01+00:00

There are a number of bugs in the error paths of this driver.  Make
use of devm_ functions to simplify the cleanup on error.

Based on a patch by Russell King.

Signed-off-by: Andrew Lunn 
Signed-off-by: Jason Cooper

ARM: orion: move platform_data definitions

2012-09-19T15:42:17+00:00

Platform data for device drivers should be defined in
include/linux/platform_data/*.h, not in the architecture
and platform specific directories.

This moves such data out of the orion include directories

Signed-off-by: Arnd Bergmann 
Acked-by: Mark Brown 
Acked-by: Greg Kroah-Hartman 
Acked-by: Nicolas Pitre 
Acked-by: Mauro Carvalho Chehab 
Cc: Jason Cooper 
Cc: Andrew Lunn 
Cc: Vinod Koul 
Cc: Dan Williams 
Cc: Bryan Wu 
Cc: Richard Purdie 
Cc: Chris Ball 
Cc: David Woodhouse 
Cc: Alan Stern 
Cc: Liam Girdwood 
Cc: Jaroslav Kysela 
Cc: Takashi Iwai

ARM: Orion: fix driver probe error handling with respect to clk

2012-07-25T15:06:21+00:00

The clk patches added code to get and enable clocks in the
respective driver probe functions.  If the probe function failed
for some reason after enabling the clock, the clock was not
disabled again in many cases.

Signed-off-by: Simon Baatz 
Signed-off-by: Andrew Lumm