linux-toradex.git/drivers/mtd/maps/gpio-addr-flash.c, branch v4.20-rc6 Linux kernel for Apalis and Colibri modules mtd: maps: gpio-addr-flash: Convert to gpiod 2018-10-08T19:32:58+00:00 Ricardo Ribalda Delgado ricardo.ribalda@gmail.com 2018-10-04T13:01:08+00:00 299b43535d3895bcde93cc7310b95b92b4fd8129 Convert from legacy gpio API to gpiod. Board files will have to use gpiod_lookup_tables. Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Suggested-by: Boris Brezillon <boris.brezillon@bootlin.com> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> 
Convert from legacy gpio API to gpiod.
Board files will have to use gpiod_lookup_tables.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Suggested-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
mtd: maps: gpio-addr-flash: Replace array with an integer 2018-10-08T19:32:57+00:00 Ricardo Ribalda Delgado ricardo.ribalda@gmail.com 2018-10-04T13:01:07+00:00 0304f8eaa3aebc0480787139a26c7a19ac9936bd By replacing the array with an integer we can avoid completely the bit comparison loop if the value has not changed (by far the most common case). Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> 
By replacing the array with an integer we can avoid completely
the bit comparison loop if the value has not changed (by far
the most common case).

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
mtd: maps: gpio-addr-flash: Use order instead of size 2018-10-08T19:32:49+00:00 Ricardo Ribalda Delgado ricardo.ribalda@gmail.com 2018-10-04T13:01:06+00:00 460cdeca546fc75f2450914c96e701f990396285 By using the order of the window instead of the size, we can replace a lot of expensive division and modulus on the code with simple bit operations. Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> 
By using the order of the window instead of the size, we can replace a
lot of expensive division and modulus on the code with simple bit
operations.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
mtd: maps: gpio-addr-flash: Use devm_* functions 2018-10-05T08:20:34+00:00 Ricardo Ribalda Delgado ricardo.ribalda@gmail.com 2018-10-04T13:01:05+00:00 4edc00adfd58768b065204968948c52f5e5b07b1 By using devm functions we can make the code cleaner. Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> 
By using devm functions we can make the code cleaner.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
mtd: maps: gpio-addr-flash: Fix ioremapped size 2018-10-05T08:20:32+00:00 Ricardo Ribalda Delgado ricardo.ribalda@gmail.com 2018-10-04T13:01:04+00:00 6c925b333368cda4e1b0513b07f72316c0e7edd7 We should only iomap the area of the chip that is memory mapped. Otherwise we could be mapping devices beyond the memory space or that belong to other devices. Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Fixes: ebd71e3a4861 ("mtd: maps: gpio-addr-flash: fix warnings and make more portable") Cc: <stable@vger.kernel.org> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> 
We should only iomap the area of the chip that is memory mapped.
Otherwise we could be mapping devices beyond the memory space or that
belong to other devices.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Fixes: ebd71e3a4861 ("mtd: maps: gpio-addr-flash: fix warnings and make more portable")
Cc: <stable@vger.kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
mtd: maps: gpio-addr-flash: Replace custom printk 2018-10-05T08:20:31+00:00 Ricardo Ribalda Delgado ricardo.ribalda@gmail.com 2018-10-04T13:01:03+00:00 34cb1e31890c97d0ee89755d5f2833737fa30a03 Use preferred print methods dev_* Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> 
Use preferred print methods dev_*

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
mtd: maps: gpio-addr-flash: add error handling for ioremap_nocache 2018-07-07T08:48:36+00:00 Zhouyang Jia jiazhouyang09@gmail.com 2018-06-22T01:52:20+00:00 c31106b7af32d845e56acb705f07e187f9b519e6 When ioremap_nocache fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling ioremap_nocache. Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> 
When ioremap_nocache fails, the lack of error-handling code may
cause unexpected results.

This patch adds error-handling code after calling ioremap_nocache.

Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
mtd: maps: gpio-addr-flash: show parent device in sysfs 2015-10-13T19:56:18+00:00 Frans Klaver fransklaver@gmail.com 2015-06-10T20:38:25+00:00 28bc7406bd6d0e3fb50f29348bafcaa9e34fabf9 Fix a bug where mtd parent device symlinks aren't shown in sysfs. Signed-off-by: Frans Klaver <fransklaver@gmail.com> Signed-off-by: Brian Norris <computersforpeace@gmail.com> 
Fix a bug where mtd parent device symlinks aren't shown in sysfs.

Signed-off-by: Frans Klaver <fransklaver@gmail.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
mtd: gpio_flash: handle case where offset + len exceeds the window size 2014-08-19T18:53:10+00:00 Aaron Wu aaron.wu@analog.com 2014-08-07T03:43:49+00:00 02f8a24e7b1c253ee37edc684200c11300de23f9 Fix the bug in handling gpio flash read/write when offset + len from MTD exceeds the window size Signed-off-by: Aaron Wu <Aaron.wu@analog.com> [Brian: made some commentary edits. Also note that the BUG_ON() was provably false for all non-negative inputs (since x % y <= x), so we dropped it.] Signed-off-by: Brian Norris <computersforpeace@gmail.com> 
Fix the bug in handling gpio flash read/write when offset + len
from MTD exceeds the window size

Signed-off-by: Aaron Wu <Aaron.wu@analog.com>

[Brian: made some commentary edits. Also note that the BUG_ON() was
provably false for all non-negative inputs (since x % y <= x), so we
dropped it.]

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
mtd: delete non-required instances of include <linux/init.h> 2014-03-11T05:42:22+00:00 Paul Gortmaker paul.gortmaker@windriver.com 2014-01-21T21:22:52+00:00 3ea5b037e750274659648b58fb97426566a90373 None of these files are actually using any __init type directives and hence don't need to include <linux/init.h>. Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Cc: David Woodhouse <dwmw2@infradead.org> Cc: Brian Norris <computersforpeace@gmail.com> Cc: linux-mtd@lists.infradead.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> [Brian: dropped one incorrect hunk] Signed-off-by: Brian Norris <computersforpeace@gmail.com> 
None of these files are actually using any __init type directives
and hence don't need to include <linux/init.h>.  Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.

Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
[Brian: dropped one incorrect hunk]
Signed-off-by: Brian Norris <computersforpeace@gmail.com>