linux-toradex.git/drivers/mtd/maps/physmap.c, branch v2.6.33.19

mtd: error return -EIO instead of EIO

2009-11-30T09:51:44+00:00

Return a negative error value instead of a positive

Signed-off-by: Roel Kluin 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: Fix compile failure and error path in physmap.c

2009-10-20T21:29:27+00:00

Commit 4b56ffcacee937a85bf39e14872dd141e23ee85f ("mtd: Fix kernel NULL
pointer dereference in physmap.c") introduced a couple of bugs.

It neglected to run the loop of map_destroy() calls in
physmap_flash_remove(), if !info->cmtd, which would happen if that
function was called to clean up errors during probe.

It also failed to compile if CONFIG_MTD_PARTITIONS was not defined.

Reported-By: Atsushi Nemoto 
Signed-off-by: H Hartley Sweeten 
Signed-off-by: David Woodhouse

mtd: Fix kernel NULL pointer dereference in physmap.c

2009-10-20T00:36:04+00:00

During the probe for physmap platform flash devices there are a
number error exit conditions that all do a goto err_out which
then calls physmap_flash_remove().  In that function one of the
cleanup steps is:

#ifdef CONFIG_MTD_CONCAT
	if (info->cmtd != info->mtd[0])
		mtd_concat_destroy(info->cmtd);
#endif

This test will succeed since info->cmtd == NULL and info->mtd[0] is
valid.

Fix this by exiting the remove function when info->cmtd == NULL.

Also, cleanup the #ifdef CONFIG_MTD_PARTITIONS stuff by using
mtd_has_partitions().

Signed-off-by: H Hartley Sweeten 
Signed-off-by: David Woodhouse

[MTD] Remove mtd->{suspend,resume} calls from board drivers

2009-05-26T15:45:44+00:00

Now the MTD core will do this for us, we don't need to hook it up from
the board drivers.

Shame we can't do shutdown from the class too...

Signed-off-by: David Woodhouse

[MTD] support driver model updates

2009-04-04T13:32:59+00:00

Follow-on patch to the previous driver model patch for the MTD
framework.  This one makes various MTD drivers connect to the
driver model tree, so /sys/devices/virtual/mtd/* nodes are no
longer present ... mostly drivers used on boards I have handy.

Based on a patch from Kay Sievers.

Signed-off-by: David Brownell 
Signed-off-by: David Woodhouse

mtd: physmap: fix NULL pointer dereference in error path

2009-03-10T22:55:11+00:00

commit e480814f138cd5d78a8efe397756ba6b6518fdb6 ("[MTD] [MAPS] physmap:
fix wrong free and del_mtd_{partition,device}") introduces a NULL pointer
dereference in physmap_flash_remove when called from the error path in
physmap_flash_probe (if map_probe failed).

Call del_mtd_{partition,device} only if info->cmtd was not NULL.

Reported-by: pHilipp Zabel 
Signed-off-by: Atsushi Nemoto 
Cc: David Woodhouse 
Cc: "Rafael J. Wysocki" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[MTD] [MAPS] physmap: fix wrong free and del_mtd_{partition,device}

2009-02-14T08:06:20+00:00

commit 176bf2e0f10ecf1d20a97db3bd5bb2e6ba0b5668 ("physmap: fix leak of
memory returned by parse_mtd_partitions") deals with a memory leak and
frees the pointer array of mtd_partition after the call to
add_mtd_partitions().  the problem is that mtd_table[x]->name still points
to the freed memory.

Aldo physmap_flash_remove() should call del_mtd_partitions() or
del_mtd_device() only once.

Signed-off-by: Atsushi Nemoto 
Reported-by: Matthias Kaehlcke 
Tested-by: Matthias Kaehlcke 
Signed-off-by: Andrew Morton 
Signed-off-by: David Woodhouse

[MTD] LPDDR extended physmap driver to support LPDDR flash

2009-01-05T12:57:28+00:00

Physmap is a generic map driver for different platforms and flash types.
We added support of LPDDR to physmap.
All changes here are related to introduction of new pfow_base parameter.
This parameter is valid in case of LPDDR chips only.

Signed-off-by: Alexey Korolev 
Acked-by: Jared Hulbert 
Signed-off-by: David Woodhouse

[MTD] struct device - replace bus_id with dev_name(), dev_set_name()

2008-12-23T10:00:14+00:00

Signed-off-by: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: David Woodhouse

[MTD] physmap: fix leak of memory returned by parse_mtd_partitions

2008-12-10T16:10:27+00:00

The mtd partition parser returns an allocated pointer array of
mtd_partition.  The caller must free it.  The array is used only for
add_mtd_partitions(), so free it just after the call.

Signed-off-by: Atsushi Nemoto 
Cc: Mike Frysinger 
Signed-off-by: Andrew Morton 
Signed-off-by: David Woodhouse