linux-toradex.git/drivers/mtd/maps/physmap.c, branch v2.6.38.6

mtd-physmap: add support users can assign the probe type in board files

2010-08-08T11:28:15+00:00

There are three reasons to add this support:
1. users probably know the interface type of their flashs, then probe
can be faster if they give the right type in platform data since wrong
types will not be detected.
2. sometimes, detecting can cause destory to system. For example, for
kernel XIP, detecting can cause NOR enter a mode instructions can not
be fetched right, which will make kernel crash.
3. For a new probe which is not listed in the rom_probe_types, if users
assign it in board files, physmap can still probe it.

Signed-off-by: Barry Song <21cnbao@gmail.com>
Signed-off-by: Mike Frysinger 
Signed-off-by: David Woodhouse

mtd: physmap: use resource_size()

2010-08-02T08:03:55+00:00

Signed-off-by: H Hartley Sweeten 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd/maps/physmap: catch failure to register MTD_PHYSMAP_COMPAT device

2010-04-20T07:53:52+00:00

If the default Kconfig values are used with MTD_PHYSMAP_COMPAT you end
up with a resource where end < start.  This causes __request_resource to
return a conflict which then returns an -EBUSY error code.  The current
physmap.c code just assumes that the platfom_device_register will always
succeed.

Catch this failure during the physmap_init and propogate the error.

Signed-off-by: H Hartley Sweeten 
Reported-by: Randy Dunlap 
Signed-off-by: David Woodhouse

mtd: error return -EIO instead of EIO

2009-11-30T09:51:44+00:00

Return a negative error value instead of a positive

Signed-off-by: Roel Kluin 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: Fix compile failure and error path in physmap.c

2009-10-20T21:29:27+00:00

Commit 4b56ffcacee937a85bf39e14872dd141e23ee85f ("mtd: Fix kernel NULL
pointer dereference in physmap.c") introduced a couple of bugs.

It neglected to run the loop of map_destroy() calls in
physmap_flash_remove(), if !info->cmtd, which would happen if that
function was called to clean up errors during probe.

It also failed to compile if CONFIG_MTD_PARTITIONS was not defined.

Reported-By: Atsushi Nemoto 
Signed-off-by: H Hartley Sweeten 
Signed-off-by: David Woodhouse

mtd: Fix kernel NULL pointer dereference in physmap.c

2009-10-20T00:36:04+00:00

During the probe for physmap platform flash devices there are a
number error exit conditions that all do a goto err_out which
then calls physmap_flash_remove().  In that function one of the
cleanup steps is:

#ifdef CONFIG_MTD_CONCAT
	if (info->cmtd != info->mtd[0])
		mtd_concat_destroy(info->cmtd);
#endif

This test will succeed since info->cmtd == NULL and info->mtd[0] is
valid.

Fix this by exiting the remove function when info->cmtd == NULL.

Also, cleanup the #ifdef CONFIG_MTD_PARTITIONS stuff by using
mtd_has_partitions().

Signed-off-by: H Hartley Sweeten 
Signed-off-by: David Woodhouse

[MTD] Remove mtd->{suspend,resume} calls from board drivers

2009-05-26T15:45:44+00:00

Now the MTD core will do this for us, we don't need to hook it up from
the board drivers.

Shame we can't do shutdown from the class too...

Signed-off-by: David Woodhouse

[MTD] support driver model updates

2009-04-04T13:32:59+00:00

Follow-on patch to the previous driver model patch for the MTD
framework.  This one makes various MTD drivers connect to the
driver model tree, so /sys/devices/virtual/mtd/* nodes are no
longer present ... mostly drivers used on boards I have handy.

Based on a patch from Kay Sievers.

Signed-off-by: David Brownell 
Signed-off-by: David Woodhouse

mtd: physmap: fix NULL pointer dereference in error path

2009-03-10T22:55:11+00:00

commit e480814f138cd5d78a8efe397756ba6b6518fdb6 ("[MTD] [MAPS] physmap:
fix wrong free and del_mtd_{partition,device}") introduces a NULL pointer
dereference in physmap_flash_remove when called from the error path in
physmap_flash_probe (if map_probe failed).

Call del_mtd_{partition,device} only if info->cmtd was not NULL.

Reported-by: pHilipp Zabel 
Signed-off-by: Atsushi Nemoto 
Cc: David Woodhouse 
Cc: "Rafael J. Wysocki" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[MTD] [MAPS] physmap: fix wrong free and del_mtd_{partition,device}

2009-02-14T08:06:20+00:00

commit 176bf2e0f10ecf1d20a97db3bd5bb2e6ba0b5668 ("physmap: fix leak of
memory returned by parse_mtd_partitions") deals with a memory leak and
frees the pointer array of mtd_partition after the call to
add_mtd_partitions().  the problem is that mtd_table[x]->name still points
to the freed memory.

Aldo physmap_flash_remove() should call del_mtd_partitions() or
del_mtd_device() only once.

Signed-off-by: Atsushi Nemoto 
Reported-by: Matthias Kaehlcke 
Tested-by: Matthias Kaehlcke 
Signed-off-by: Andrew Morton 
Signed-off-by: David Woodhouse