linux-toradex.git/drivers/mtd/maps, branch v4.4.80

mtd: pmcmsp: use kstrndup instead of kmalloc+strncpy

2017-03-18T11:09:56+00:00

commit 906b268477bc03daaa04f739844c120fe4dbc991 upstream.

kernelci.org reports a warning for this driver, as it copies a local
variable into a 'const char *' string:

    drivers/mtd/maps/pmcmsp-flash.c:149:30: warning: passing argument 1 of 'strncpy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]

Using kstrndup() simplifies the code and avoids the warning.

Signed-off-by: Arnd Bergmann 
Acked-by: Marek Vasut 
Signed-off-by: Brian Norris 
Signed-off-by: Greg Kroah-Hartman

mtd: pmcmsp-flash: Allocating too much in init_msp_flash()

2016-09-30T08:18:37+00:00

commit 79ad07d45743721010e766e65dc004ad249bd429 upstream.

There is a cut and paste issue here.  The bug is that we are allocating
more memory than necessary for msp_maps.  We should be allocating enough
space for a map_info struct (144 bytes) but we instead allocate enough
for an mtd_info struct (1840 bytes).  It's a small waste.

The other part of this is not harmful but when we allocated msp_flash
then we allocated enough space fro a map_info pointer instead of an
mtd_info pointer.  But since pointers are the same size it works out
fine.

Anyway, I decided to clean up all three allocations a bit to make them
a bit more consistent and clear.

Fixes: 68aa0fa87f6d ('[MTD] PMC MSP71xx flash/rootfs mappings')
Signed-off-by: Dan Carpenter 
Signed-off-by: Brian Norris 
Signed-off-by: Greg Kroah-Hartman

mtd: maps: sa1100-flash: potential NULL dereference

2016-09-30T08:18:37+00:00

commit dc01a28d80a42cef08c94dfc595565aaebe46d15 upstream.

We check for NULL but then dereference "info->mtd" on the next line.

Fixes: 72169755cf36 ('mtd: maps: sa1100-flash: show parent device in sysfs')
Signed-off-by: Dan Carpenter 
Signed-off-by: Brian Norris 
Signed-off-by: Greg Kroah-Hartman

mtd: maps: rbtx4939-flash: fix compile error

2015-10-20T01:21:25+00:00

We got the syntax wrong here. Compile tested this time!

Error:

   drivers/mtd/maps/rbtx4939-flash.c: In function 'rbtx4939_flash_probe':
>> drivers/mtd/maps/rbtx4939-flash.c:99:11: error: request for member 'dev' in something not a structure or union
     info->mtd.dev.parent = &dev->dev;
              ^

Fixes: 9aa7e50276c1 ("mtd: maps: rbtx4939-flash: show parent device in sysfs")
Reported-by: kbuild test robot 
Signed-off-by: Brian Norris 
Cc: Frans Klaver

mtd: maps: sa1100-flash: show parent device in sysfs

2015-10-13T19:56:24+00:00

Fix a bug where mtd parent device symlinks aren't shown in sysfs.

While at it, make use of the default owner value set by mtdcore.
Incidentally, it seems the owner field in the concatenated mtds is not
actually used, so this shouldn't make much of a difference anyway.

Signed-off-by: Frans Klaver 
Signed-off-by: Brian Norris

mtd: maps: rbtx4939-flash: show parent device in sysfs

2015-10-13T19:56:24+00:00

Fix a bug where mtd parent device symlinks aren't shown in sysfs.

While at it, make use of the default owner value set by mtdcore.

Signed-off-by: Frans Klaver 
Signed-off-by: Brian Norris

mtd: maps: pxa2xx-flash: show parent device in sysfs

2015-10-13T19:56:23+00:00

Fix a bug where mtd parent device symlinks aren't shown in sysfs.

While at it, make use of the default owner value set by mtdcore.

Signed-off-by: Frans Klaver 
Signed-off-by: Brian Norris

mtd: maps: plat_ram: drop owner assignment

2015-10-13T19:56:22+00:00

Owner is automatically set by mtdcore. Make use of that.

Signed-off-by: Frans Klaver 
Signed-off-by: Brian Norris

mtd: maps: physmap_of: drop owner assignment

2015-10-13T19:56:22+00:00

Owner is automatically set by mtdcore. Make use of that.

Signed-off-by: Frans Klaver 
Signed-off-by: Brian Norris

mtd: maps: physmap: drop owner assignment

2015-10-13T19:56:21+00:00

Owner is automatically set by mtdcore. Make use of that.

Signed-off-by: Frans Klaver 
Signed-off-by: Brian Norris