linux-toradex.git/drivers/mtd/mtdcore.c, branch v3.3.6

mtd: fix MTD suspend

2012-01-30T14:23:07+00:00

Commits 3fe4bae88460869a8e553397cd9057a4ee7ca341 and
079c985e7a6f4ce60f931cebfdd5ee3c3 broke MTD suspend in 2 ways:

1. When the '->suspend' method is not present, we return -EOPNOTSUPP, but
   the callers of 'mtd_suspend()' expects 0 instead.
2. Checking of the 'mtd' parameter against NULL has been incorrectly removed
   in 'mtd_cls_suspend()'.

This patch fixes the breakages. This has been found, analyzed, reported
and tested by Rafael J. Wysocki .

Note, this patch is not needed in the stable tree because it causes a
regression introduced during the v3.3 merge window.

Reported-by: Rafael J. Wysocki 
Tested-by: Rafael J. Wysocki 
Tested-by: Russell King 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: do not use mtd->suspend and mtd->resume directly

2012-01-09T18:26:23+00:00

Just call the 'mtd_suspend()' and 'mtd_resume()' - they will do nothing
if the operation is not defined.

Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: do not use mtd->lock, unlock and is_locked directly

2012-01-09T18:26:22+00:00

Instead, call the corresponding MTD API function which will return
'-EOPNOTSUPP' if the operation is not supported.

Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: harmonize mtd_writev usage

2012-01-09T18:26:19+00:00

This patch makes the 'mtd_writev()' function more usable and logical. We first
teach it to fall-back to the 'default_mtd_writev()' function if the MTD driver
does not define its own '->writev()' method. Then we make block2mtd and JFFS2
just 'mtd_writev()' instead of 'default_mtd_writev()' function. This means we
can now stop exporting 'default_mtd_writev()' and instead, export
'mtd_writev()'. This is much cleaner and more logical, as well as allows us to
get read of another direct 'mtd->writev' access in JFFS2.

Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: mtdcore: export symbols cleanup

2012-01-09T18:26:06+00:00

The mtdcore.c file is a bit inconsistent - some EXPORT_SYMBOL_GPL declarations
follow the corresponding functions, some are placed at the end. This patch
harmonizes the file so that EXPORT_SYMBOL_GPL declarations follow the
corresponding function.

It also removes few extra newlines and trailing white-spaces.

Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: clean-up the default_mtd_writev function

2012-01-09T18:26:05+00:00

1. Teach 'mtd_write()' function to return '-EROFS' if the write method
   is undefined, and remove the corresponding check from
   'default_mtd_writev()'.
2. Do not test 'retlen' for NULL - it cannot be NULL.
3. Few minor coding stile clean-ups.
4. Add a kerneldoc comment

Additionally, minor fixes to the kerneldoc comments of the neighbor function.

Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: kill dev_to_mtd helper

2012-01-09T18:25:57+00:00

... since it is not needed because the generic 'dev_get_drvdata()' can be
used instead.

Signed-off-by: Artem Bityutskiy 
Acked-by: Mike Frysinger 
Signed-off-by: David Woodhouse

mtd: introduce mtd_resume interface

2012-01-09T18:25:46+00:00

Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: introduce mtd_suspend interface

2012-01-09T18:25:45+00:00

Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: introduce mtd_unlock interface

2012-01-09T18:25:40+00:00

Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse