linux-toradex.git/drivers/mtd/mtdswap.c, branch v4.9.97 Linux kernel for Apalis and Colibri modules mtd: mtdswap: remove useless if (!mtd->ecclayout) test 2016-03-08T00:23:09+00:00 Boris BREZILLON boris.brezillon@free-electrons.com 2016-03-07T09:46:53+00:00 f2de0fa64306651bc5aa04f6bb56c057658486d5 If the MTD device does not have OOB, the mtd->oobsize and mtd->oobavail fields are set to zero, and we are testing those values in the following test. Remove the useless if (!mtd->ecclayout) test. Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> Signed-off-by: Brian Norris <computersforpeace@gmail.com> 
If the MTD device does not have OOB, the mtd->oobsize and mtd->oobavail
fields are set to zero, and we are testing those values in the following
test.
Remove the useless if (!mtd->ecclayout) test.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
mtd: kill the ecclayout->oobavail field 2016-03-08T00:23:09+00:00 Boris BREZILLON boris.brezillon@free-electrons.com 2016-03-07T09:46:51+00:00 f5b8aa78ef086248145363bf1ffe5ca4348b6a98 ecclayout->oobavail is just redundant with the mtd->oobavail field. Moreover, it prevents static const definition of ecc layouts since the NAND framework is calculating this value based on the ecclayout->oobfree field. Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> Signed-off-by: Brian Norris <computersforpeace@gmail.com> 
ecclayout->oobavail is just redundant with the mtd->oobavail field.
Moreover, it prevents static const definition of ecc layouts since the
NAND framework is calculating this value based on the ecclayout->oobfree
field.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
mtd: use __packed shorthand 2014-08-19T18:53:08+00:00 Brian Norris computersforpeace@gmail.com 2014-07-22T02:07:22+00:00 31f754628cbb12c983600f22d9f0fed50dfe2134 Signed-off-by: Brian Norris <computersforpeace@gmail.com> 
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
mtd: mtdswap: fix integer overflow 2014-08-19T18:53:08+00:00 Brian Norris computersforpeace@gmail.com 2014-07-22T02:07:02+00:00 8c3f3f1d7941bcb25590b784f84accd7dcb44ba3 Caught by Coverity. Signed-off-by: Brian Norris <computersforpeace@gmail.com> 
Caught by Coverity.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
mtd: Fixed checkpatch seq_printf warnings 2014-08-19T18:53:07+00:00 Samarth Parikh samarthp@ymail.com 2014-07-16T10:44:37+00:00 6f3c0f163103fb225c77b73ca17fc4ecea308103 Fixed checkpatch warnings: "WARNING: Prefer seq_puts to seq_printf" This patch is created with reference to the ongoing lkml thread https://lkml.org/lkml/2014/7/15/646 where Andrew Morton wrote: " - puts is presumably faster - puts doesn't go rogue if you accidentally pass it a "%". - this patch would actually make compiled object files few bytes smaller. Perhaps because seq_printf() is a varargs function, forcing the caller to pass args on the stack instead of in registers. " Signed-off-by: Samarth Parikh <samarthp@ymail.com> Signed-off-by: Brian Norris <computersforpeace@gmail.com> 
Fixed checkpatch warnings: "WARNING: Prefer seq_puts to seq_printf"

This patch is created with reference to the ongoing lkml thread
https://lkml.org/lkml/2014/7/15/646
where Andrew Morton wrote:

"
- puts is presumably faster

- puts doesn't go rogue if you accidentally pass it a "%".

- this patch would actually make compiled object files few bytes smaller.
  Perhaps because seq_printf() is a varargs function, forcing the
  caller to pass args on the stack instead of in registers.
"

Signed-off-by: Samarth Parikh <samarthp@ymail.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
mtd: mtdswap: replace strict_strtoul() with kstrtoul() 2013-08-30T20:52:51+00:00 Jingoo Han jg1.han@samsung.com 2013-07-19T06:54:11+00:00 3156231fb644cf29c1d7f21766ff9e33dc9761d3 The usage of strict_strtoul() is not preferred, because strict_strtoul() is obsolete. Thus, kstrtoul() should be used. Signed-off-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Brian Norris <computersforpeace@gmail.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 
The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
mtd: do not use mtd->block_markbad directly 2012-01-09T18:26:26+00:00 Artem Bityutskiy artem.bityutskiy@linux.intel.com 2012-01-02T11:59:12+00:00 800ffd3496987e91f599a135060ef49731e045ac Instead, use the new 'mtd_can_have_bb()', or just rely on 'mtd_block_markbad()' return code, which will be -EOPNOTSUPP if bad blocks are not supported. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 
Instead, use the new 'mtd_can_have_bb()', or just rely on 'mtd_block_markbad()'
return code, which will be -EOPNOTSUPP if bad blocks are not supported.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
mtd: introduce mtd_can_have_bb helper 2012-01-09T18:26:24+00:00 Artem Bityutskiy artem.bityutskiy@linux.intel.com 2012-01-02T11:48:54+00:00 8f461a730242c528ca221948edceca49266a3ffb This patch introduces new 'mtd_can_have_bb()' helper function which checks whether the flash can have bad eraseblocks. Then it changes all the direct 'mtd->block_isbad' use cases with 'mtd_can_have_bb()'. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 
This patch introduces new 'mtd_can_have_bb()' helper function which checks
whether the flash can have bad eraseblocks. Then it changes all the
direct 'mtd->block_isbad' use cases with 'mtd_can_have_bb()'.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
mtd: do not use mtd->sync directly 2012-01-09T18:26:21+00:00 Artem Bityutskiy artem.bityutskiy@linux.intel.com 2011-12-30T14:35:35+00:00 327cf2922b4edf0439b219469722d2a502e37349 This patch teaches 'mtd_sync()' to do nothing when the MTD driver does not have the '->sync()' method, which allows us to remove all direct 'mtd->sync' accesses. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 
This patch teaches 'mtd_sync()' to do nothing when the MTD driver does
not have the '->sync()' method, which allows us to remove all direct
'mtd->sync' accesses.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
mtd: introduce mtd_block_markbad interface 2012-01-09T18:25:48+00:00 Artem Bityutskiy artem.bityutskiy@linux.intel.com 2011-12-23T17:37:38+00:00 5942ddbc500d1c9b75e571b656be97f65b26adfe Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>