linux-toradex.git/drivers/mtd/nand, branch v3.0.9

mtd: nand_base: always initialise oob_poi before writing OOB data

2011-11-11T17:37:19+00:00

commit f722013ee9fd24623df31dec9a91a6d02c3e2f2f upstream.

In nand_do_write_ops() code it is possible for a caller to provide
ops.oobbuf populated and ops.mode == MTD_OOB_AUTO, which currently
means that the chip->oob_poi buffer isn't initialised to all 0xFF.
The nand_fill_oob() method then carries out the task of copying
the provided OOB data to oob_poi, but with MTD_OOB_AUTO it skips
areas marked as unavailable by the layout struct, including the
bad block marker bytes.

An example of this causing issues is when the last OOB data read
was from the start of a bad block where the markers are not 0xFF,
and the caller wishes to write new OOB data at the beginning of
another block. In this scenario the caller would provide OOB data,
but nand_fill_oob() would skip the bad block marker bytes in
oob_poi before copying the OOB data provided by the caller.
This means that when the OOB data is written back to NAND,
the block is inadvertently marked as bad without the caller knowing.
This has been witnessed when using YAFFS2 where tags are stored
in the OOB.

To avoid this oob_poi is always initialised to 0xFF to make sure
no left over data is inadvertently written back to the OOB area.

Credits to Brian Norris  for fixing this
patch.

Signed-off-by: Adam Thomson 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: Greg Kroah-Hartman

mtd: pxa3xx_nand: Fix blank page ECC mismatch

2011-11-11T17:37:16+00:00

commit 543e32d5ff165d0d68deedb0e3557478c7c36a4a upstream.

This bug was introduced in f8155a40 ("mtd: pxa3xx_nand: rework irq
logic") and causes the PXA3xx NAND controller fail to operate with NAND
flash that has empty pages. According to the comment in this block, the
hardware controller will report a double-bit error for empty pages,
which can and must be ignored.

This patch restores the original behaviour of the driver.

Signed-off-by: Daniel Mack 
Acked-by: Lei Wen 
Cc: Haojian Zhuang 
Cc: David Woodhouse 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: Greg Kroah-Hartman

mtd: pxa3xx_nand: fix nand detection issue

2011-11-11T17:37:16+00:00

commit 0fab028b77d714ad302404b23306cf7adb885223 upstream.

When keep_config is set, the detection would goes different routine.
That the driver would read out the setting which is set previously
by bootloader. While most bootloader keep the irq mask as off, and
current driver need all irq default open, keep_config behavior would
lead to no irq at all.

Signed-off-by: Lei Wen 
Tested-by: Daniel Mack 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: Greg Kroah-Hartman

powerpc/85xx: fix NAND_CMD_READID read bytes number

2011-06-22T11:08:48+00:00

when nand_get_flash_type() is called, it will read 8 bytes of ID instead of 5,
but the driver only read 5 bytes, so kernel will dump error messages like:

fsl-lbc ffe124000.localbus: read_byte beyond end of buffer
fsl-lbc ffe124000.localbus: read_byte beyond end of buffer
fsl-lbc ffe124000.localbus: read_byte beyond end of buffer

Signed-off-by: Shaohui Xie 
Acked-by: Scott Wood 
Signed-off-by: Kumar Gala

Merge git://git.infradead.org/mtd-2.6

2011-05-28T03:06:53+00:00

* git://git.infradead.org/mtd-2.6: (97 commits)
  mtd: kill CONFIG_MTD_PARTITIONS
  mtd: remove add_mtd_partitions, add_mtd_device and friends
  mtd: convert remaining users to mtd_device_register()
  mtd: samsung onenand: convert to mtd_device_register()
  mtd: omap2 onenand: convert to mtd_device_register()
  mtd: txx9ndfmc: convert to mtd_device_register()
  mtd: tmio_nand: convert to mtd_device_register()
  mtd: socrates_nand: convert to mtd_device_register()
  mtd: sharpsl: convert to mtd_device_register()
  mtd: s3c2410 nand: convert to mtd_device_register()
  mtd: ppchameleonevb: convert to mtd_device_register()
  mtd: orion_nand: convert to mtd_device_register()
  mtd: omap2: convert to mtd_device_register()
  mtd: nomadik_nand: convert to mtd_device_register()
  mtd: ndfc: convert to mtd_device_register()
  mtd: mxc_nand: convert to mtd_device_register()
  mtd: mpc5121_nfc: convert to mtd_device_register()
  mtd: jz4740_nand: convert to mtd_device_register()
  mtd: h1910: convert to mtd_device_register()
  mtd: fsmc_nand: convert to mtd_device_register()
  ...

Fixed up trivial conflicts in
 - drivers/mtd/maps/integrator-flash.c: removed in ARM tree
 - drivers/mtd/maps/physmap.c: addition of afs partition probe type
   clashing with removal of CONFIG_MTD_PARTITIONS

mtd: Use platform_data to retrieve tmio_nand platform bits

2011-05-26T17:45:04+00:00

With the addition of the platform device mfd_cell pointer, we can now
cleanly pass the sub device drivers platform data pointers through the
regular device platform_data one, and get rid of mfd_get_data().

Cc: Ian Molton 
Cc: Artem Bityutskiy 
Acked-by: Dmitry Eremin-Solenikov 
Signed-off-by: Samuel Ortiz

mtd: kill CONFIG_MTD_PARTITIONS

2011-05-25T01:25:35+00:00

Now that none of the drivers use CONFIG_MTD_PARTITIONS we can remove
it from Kconfig and the last remaining uses.

Signed-off-by: Jamie Iles 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: convert remaining users to mtd_device_register()

2011-05-25T01:25:00+00:00

The older add_mtd_device()/add_mtd_partitions() and their removal
counterparts will soon be gone.  Replace uses with mtd_device_register()
and mtd_device_unregister().

Signed-off-by: Jamie Iles 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: txx9ndfmc: convert to mtd_device_register()

2011-05-25T01:23:57+00:00

Convert to mtd_device_register() and remove the CONFIG_MTD_PARTITIONS
preprocessor conditionals as partitioning is always available.

Signed-off-by: Jamie Iles 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: tmio_nand: convert to mtd_device_register()

2011-05-25T01:23:55+00:00

Convert to mtd_device_register() and remove the CONFIG_MTD_PARTITIONS
preprocessor conditionals as partitioning is always available.

Signed-off-by: Jamie Iles 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse