linux-toradex.git/drivers/mtd/ubi/cdev.c, branch v4.1-rc4

UBI: fix check for "too many bytes"

2015-03-26T11:07:18+00:00

The comparison from the previous line seems to have been erroneously
(partially) copied-and-pasted onto the next. The second line should be
checking req.bytes, not req.lnum.

Coverity CID #139400

Cc: stable 
Signed-off-by: Brian Norris 
[rw: Fixed comparison]
Signed-off-by: Richard Weinberger

UBI: extend UBI layer debug/messaging capabilities - cosmetics

2015-01-28T15:09:09+00:00

Some cosmetic fixes to the patch "UBI: Extend UBI layer debug/messaging
capabilities".

Signed-off-by: Tanya Brokhman 
Signed-off-by: Artem Bityutskiy

UBI: rename_volumes: Use UBI_METAONLY

2015-01-28T14:57:13+00:00

By using UBI_METAONLY in rename_volumes() it is now possible to rename
an UBI volume atomically while it is open for writing.
This is useful for firmware upgrades.

Cc: Ezequiel Garcia 
Cc: Andrew Murray 
Signed-off-by: Richard Weinberger 
Tested-by: Guido Martínez 
Reviewed-by: Guido Martínez 
Tested-by: Christoph Fritz 
Tested-by: Andrew Murray

UBI: Implement UBI_METAONLY

2015-01-28T14:57:04+00:00

UBI_METAONLY is a new open mode for UBI volumes, it indicates
that only meta data is being changed.
Meta data in terms of UBI volumes means data which is stored in the
UBI volume table but not on the volume itself.
While it does not interfere with UBI_READONLY and UBI_READWRITE
it is not allowed to use UBI_METAONLY together with UBI_EXCLUSIVE.

Cc: Ezequiel Garcia 
Cc: Andrew Murray 
Signed-off-by: Richard Weinberger 
Tested-by: Guido Martínez 
Reviewed-by: Guido Martínez 
Tested-by: Christoph Fritz 
Tested-by: Andrew Murray

UBI: Extend UBI layer debug/messaging capabilities

2014-11-07T10:08:51+00:00

If there is more then one UBI device mounted, there is no way to
distinguish between messages from different UBI devices.
Add device number to all ubi layer message types.

The R/O block driver messages were replaced by pr_* since
ubi_device structure is not used by it.

Amended a bit by Artem.

Signed-off-by: Tanya Brokhman 
Signed-off-by: Artem Bityutskiy

UBI: return on error in rename_volumes()

2014-09-19T15:12:00+00:00

I noticed this during a code review.  We are checking that the strlen()
of ->name is not less than the ->name_len which the user gave us.  I
believe this bug is harmless but clearly we meant to return here instead
of setting an error code and then not using it.

Signed-off-by: Dan Carpenter 
Signed-off-by: Artem Bityutskiy

UBI: Dispatch update notification if the volume is updated

2014-09-16T16:02:05+00:00

The UBI_IOCVOLUP ioctl is used to start an update and also to
truncate a volume. In the first case, a "volume updated" notification
is dispatched when the update is done.

This commit adds the "volume updated" notification to be also sent when
the volume is truncated. This is required for UBI block and gluebi to get
notified about the new volume size.

Signed-off-by: Ezequiel Garcia 
Signed-off-by: Artem Bityutskiy 
Cc: stable@vger.kernel.org # v3.15+

UBI: weaken the 'exclusive' constraint when opening volumes to rename

2014-05-13T10:45:16+00:00

The UBI volume rename ioctl (UBI_IOCRNVOL) open the volumes in exclusive
mode. The volumes are opened for two reasons: to build a volume rename list,
and a volume remove list.

However, the first open constraint is excessive and can be replaced by
a 'read-write' open mode. The second open constraint is properly set as
'exclusive' given the volume is opened for removal and we don't want any
users around.

By weakening the former 'exclusive' mode, we allow 'read-only' users to keep
the volume open, while a rename is taking place. This is useful to perform
an atomic rename, in a firmware upgrade scenario, while keeping the volume
in read-only use (for instance, if a ubiblock is mounted as rootfs).

It's worth mention this is not the case of UBIFS, which keeps the volume
opened as 'read-write' despite mounted as read-write or read-only mode.

This change was suggested at least twice by Artem:
http://lists.infradead.org/pipermail/linux-mtd/2012-September/044175.html
http://permalink.gmane.org/gmane.linux.drivers.mtd/39866

Signed-off-by: Ezequiel Garcia 
Signed-off-by: Artem Bityutskiy

UBI: rename block device ioctls

2014-03-05T13:49:15+00:00

Rename the UBI_IOCVOLATTBLK and UBI_IOCVOLDETBLK to UBI_IOCVOLCRBLK and
UBI_IOCVOLRMBLK, because we do not use terms "attach" and "detach" for the R/O
block devices on top of UBI volumes. Instead, we use terms "create" and
"remove". This patch also amends the related commentaries.

Signed-off-by: Artem Bityutskiy 
Acked-by: Ezequiel Garcia

UBI: block: do not use term "attach"

2014-03-04T11:52:33+00:00

We already use term attach/detach for UBI->MTD relations, let's not use this
for UBI->ubiblock relations to avoid confusion. Just use 'create' and 'remove'
instead. E.g., "create a R/O block device on top of a UBI volume".

Signed-off-by: Artem Bityutskiy