linux-toradex.git/drivers/mtd/ubi/fastmap.c, branch v4.10

ubi: fastmap: Fix add_vol() return value test in ubi_attach_fastmap()

2016-10-28T12:48:18+00:00

Commit e96a8a3bb671 ("UBI: Fastmap: Do not add vol if it already
exists") introduced a bug by changing the possible error codes returned
by add_vol():
- this function no longer returns NULL in case of allocation failure
  but return ERR_PTR(-ENOMEM)
- when a duplicate entry in the volume RB tree is found it returns
  ERR_PTR(-EEXIST) instead of ERR_PTR(-EINVAL)

Fix the tests done on add_vol() return val to match this new behavior.

Fixes: e96a8a3bb671 ("UBI: Fastmap: Do not add vol if it already exists")
Reported-by: Dan Carpenter 
Signed-off-by: Boris Brezillon 
Acked-by: Sheng Yong 
Signed-off-by: Richard Weinberger

ubi: fix swapped arguments to call to ubi_alloc_aeb

2016-10-19T22:06:00+00:00

Static analysis by CoverityScan detected the ec and pnum
arguments are in the wrong order on a call to ubi_alloc_aeb.
Swap the order to fix this.

Fixes: 91f4285fe389a27 ("UBI: provide helpers to allocate and free aeb elements")
Signed-off-by: Colin Ian King 
Reviewed-by: Boris Brezillon 
Signed-off-by: Richard Weinberger

ubi: Fix Fastmap's update_vol()

2016-10-02T20:55:02+00:00

Usually Fastmap is free to consider every PEB in one of the pools
as newer than the existing PEB. Since PEBs in a pool are by definition
newer than everything else.
But update_vol() missed the case that a pool can contain more than
one candidate.

Cc: 
Fixes: dbb7d2a88d ("UBI: Add fastmap core")
Signed-off-by: Richard Weinberger 
Reviewed-by: Boris Brezillon 
Signed-off-by: Richard Weinberger

ubi: Fix races around ubi_refill_pools()

2016-10-02T20:54:01+00:00

When writing a new Fastmap the first thing that happens
is refilling the pools in memory.
At this stage it is possible that new PEBs from the new pools
get already claimed and written with data.
If this happens before the new Fastmap data structure hits the
flash and we face power cut the freshly written PEB will not
scanned and unnoticed.

Solve the issue by locking the pools until Fastmap is written.

Cc: 
Fixes: dbb7d2a88d ("UBI: Add fastmap core")
Signed-off-by: Richard Weinberger

UBI: introduce the VID buffer concept

2016-10-02T20:48:14+00:00

Currently, all VID headers are allocated and freed using the
ubi_zalloc_vid_hdr() and ubi_free_vid_hdr() function. These functions
make sure to align allocation on ubi->vid_hdr_alsize and adjust the
vid_hdr pointer to match the ubi->vid_hdr_shift requirements.
This works fine, but is a bit convoluted.
Moreover, the future introduction of LEB consolidation (needed to support
MLC/TLC NANDs) will allows a VID buffer to contain more than one VID
header.

Hence the creation of a ubi_vid_io_buf struct to attach extra information
to the VID header.

We currently only store the actual pointer of the underlying buffer, but
will soon add the number of VID headers contained in the buffer.

Signed-off-by: Boris Brezillon 
Signed-off-by: Richard Weinberger

UBI: provide an helper to query LEB information

2016-10-02T20:48:14+00:00

This is part of our attempt to hide EBA internals from other part of the
implementation in order to easily adapt it to the MLC needs.

Here we are creating an ubi_eba_leb_desc struct to hide the way we keep
track of the LEB to PEB mapping.

Signed-off-by: Boris Brezillon 
Signed-off-by: Richard Weinberger

UBI: provide helpers to allocate and free aeb elements

2016-10-02T20:48:14+00:00

This not only hides the aeb allocation internals (which is always good in
case we ever want to change the allocation system), but also helps us
factorize the initialization of some common fields (ec and pnum).

Signed-off-by: Boris Brezillon 
Signed-off-by: Richard Weinberger

UBI: fastmap: use ubi_io_{read, write}_data() instead of ubi_io_{read, write}()

2016-10-02T20:48:14+00:00

ubi_io_{read,write}_data() are wrappers around ubi_io_{read/write}() that
are used to read/write eraseblock payload data, which is exactly what
fastmap does when calling ubi_io_{read,write}().

Signed-off-by: Boris Brezillon 
Signed-off-by: Richard Weinberger

UBI: fastmap: use ubi_rb_for_each_entry() in unmap_peb()

2016-10-02T20:48:14+00:00

Use the ubi_rb_for_each_entry() macro instead of open-coding it.

Signed-off-by: Boris Brezillon 
Signed-off-by: Richard Weinberger

UBI: factorize code used to manipulate volumes at attach time

2016-10-02T20:48:14+00:00

Volume creation/search code is duplicated in a few places (fastmap and
non fastmap code). Create some helpers to factorize the code.

Signed-off-by: Boris Brezillon 
Signed-off-by: Richard Weinberger