linux-toradex.git/drivers/mtd/ubi/upd.c, branch v3.3.2

UBI: fix memory leak in update path

2010-01-18T16:53:56+00:00

When truncating an UBI volume, UBI should allocates a PEB-sized
buffer but does not release it, which leads to memory leaks.
This patch fixes the issue.

Reported-by: Marek Skuczynski 
Signed-off-by: Artem Bityutskiy 
Tested-by: Marek Skuczynski 
Cc: stable@kernel.org

UBI: flush wl before clearing update marker

2009-12-04T05:47:11+00:00

ubiupdatevol -t does the following:
- ubi_start_update()
  - set_update_marker()
  - for all LEBs ubi_eba_unmap_leb()
  - clear_update_marker()
  - ubi_wl_flush()

ubi_wl_flush() physically erases all PEB, once it returns all PEBs are
empty. clear_update_marker() has the update marker written after return.
If there is a power cut between the last two functions then the UBI
volume has no longer the "update" marker set and may have some valid
LEBs while some of them may be gone.
If that volume in question happens to be a UBIFS volume, then mount
will fail with

|UBIFS error (pid 1361): ubifs_read_node: bad node type (255 but expected 6)
|UBIFS error (pid 1361): ubifs_read_node: bad node at LEB 0:0
|Not a node, first 24 bytes:
|00000000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff

if there is at least one valid LEB and the wear-leveling worker managed
to clear LEB 0.

The patch waits for the wl worker to finish prior clearing the "update"
marker on flash. The two new LEB which are scheduled for erasing after
clear_update_marker() should not matter because they are only visible to
UBI.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Artem Bityutskiy 
Cc: stable@kernel.org

UBI: minor serialization fix

2009-05-18T09:28:26+00:00

The @vol->upd_marker should be protected by the @ubi->device_mutex,
otherwise 'paranoid_check_volume()' complains sometimes because
vol->upd_marker is 1 while vtbl_rec->upd_marker is 0.

Signed-off-by: Artem Bityutskiy

UBI: re-name volumes_mutex to device_mutex

2009-05-18T09:28:24+00:00

The mutex essencially protects the entire UBI device, so the
old @volumes_mutex name is a little misleading.

Signed-off-by: Artem Bityutskiy

UBI: use nicer 64-bit math

2009-01-18T12:27:44+00:00

Get rid of 'do_div()' and use more user-friendly primitives from
'linux/math64.h'.

Signed-off-by: Artem Bityutskiy

UBI: fix kernel-doc errors and warnings

2008-07-24T10:36:09+00:00

No functional changes, just tweak comments to make kernel-doc
work fine and stop complaining.

Signed-off-by: Artem Bityutskiy

UBI: fix checkpatch.pl errors and warnings

2008-07-24T10:36:09+00:00

Just out or curiousity ran checkpatch.pl for whole UBI,
and discovered there are quite a few of stylistic issues.
Fix them.

Signed-off-by: Artem Bityutskiy

UBI: fix and re-work debugging stuff

2008-07-24T10:34:45+00:00

Signed-off-by: Artem Bityutskiy

UBI: fix buffer padding

2008-07-24T10:32:54+00:00

Instead of correctly pad the buffer wich we are writing to the
eraseblock during update, we used weird construct:

memset(buf + len, 0xFF, len - len);

Fix this.

Signed-off-by: Kyungmin Park 
Signed-off-by: Artem Bityutskiy

UBI: implement atomic LEB change ioctl

2008-01-25T14:41:26+00:00

Signed-off-by: Artem Bityutskiy