linux-toradex.git/drivers/net/3c503.c, branch v2.6.35

drivers/net: Remove unnecessary returns from void function()s

2010-05-14T07:19:28+00:00

This patch removes from drivers/net/ all the unnecessary
return; statements that precede the last closing brace of
void functions.

It does not remove the returns that are immediately
preceded by a label as gcc doesn't like that.

It also does not remove null void functions with return.

Done via:
$ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
  xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'

with some cleanups by hand.

Compile tested x86 allmodconfig only.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

3c503: Fix IRQ probing

2010-04-08T03:55:47+00:00

The driver attempts to select an IRQ for the NIC automatically by
testing which of the supported IRQs are available and then probing
each available IRQ with probe_irq_{on,off}().  There are obvious race
conditions here, besides which:
1. The test for availability is done by passing a NULL handler, which
   now always returns -EINVAL, thus the device cannot be opened:
   
2. probe_irq_off() will report only the first ISA IRQ handled,
   potentially leading to a false negative.

There was another bug that meant it ignored all error codes from
request_irq() except -EBUSY, so it would 'succeed' despite this
(possibly causing conflicts with other ISA devices).  This was fixed
by ab08999d6029bb2c79c16be5405d63d2bedbdfea 'WARNING: some
request_irq() failures ignored in el2_open()', which exposed bug 1.

This patch:
1. Replaces the use of probe_irq_{on,off}() with a real interrupt handler
2. Adds a delay before checking the interrupt-seen flag
3. Disables interrupts on all failure paths
4. Distinguishes error codes from the second request_irq() call,
   consistently with the first

Compile-tested only.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

drivers/net: Move && and || to end of previous line

2009-12-03T21:18:01+00:00

Only files where David Miller is the primary git-signer.
wireless, wimax, ixgbe, etc are not modified.

Compile tested x86 allyesconfig only
Not all files compiled (not x86 compatible)

Added a few > 80 column lines, which I ignored.
Existing checkpatch complaints ignored.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

net: Fix a build break because of a typo in drivers/net/3c503.c

2009-09-04T10:41:07+00:00

Signed-off-by: Sachin Sant 
Signed-off-by: David S. Miller

WARNING: some request_irq() failures ignored in el2_open()

2009-09-03T06:45:54+00:00

Request_irq() may fail in different ways, handle accordingly.

Signed-off-by: Roel Kluin 
Signed-off-by: David S. Miller

3c50x: convert printk() to pr_()

2009-05-27T03:35:02+00:00

Signed-off-by: Alexander Beregalov 
Signed-off-by: David S. Miller

3c503, smc-ultra: netdev_ops bugs

2009-03-27T07:46:38+00:00

A couple of drivers have leftovers from netdev ops conversion.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

netdev: add missing set_mac_address hook

2009-01-11T08:06:36+00:00

Many drivers lost the ability to set ethernet address accidently
during the net_device_ops conversion.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

3c503: convert to net_device_ops

2008-11-26T02:26:20+00:00

Another of the 8390p group.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

net: convert print_mac to %pM

2008-10-28T00:06:18+00:00

This converts pretty much everything to print_mac. There were
a few things that had conflicts which I have just dropped for
now, no harm done.

I've built an allyesconfig with this and looked at the files
that weren't built very carefully, but it's a huge patch.

Signed-off-by: Johannes Berg 
Signed-off-by: David S. Miller