linux-toradex.git/drivers/net/3c59x.c, branch tegra-9.12.13

3c59x: Use device_set_wakeup_enable

2009-01-11T08:06:32+00:00

Since dev->power.should_wakeup bit is used by the PCI core to
decide whether the device should wake up the system from sleep
states, set this bit by calling device_set_wakeup_enable().

This restores proper WOL for the 3c59x driver.

Reported-and-tested-by: Graeme Wilford 
Reported-by: Gunnar Degnbol 
Signed-off-by: Steffen Klassert 
Signed-off-by: David S. Miller

netdevice: safe convert to netdev_priv() #part-1

2008-11-13T07:37:49+00:00

We have some reasons to kill netdev->priv:
1. netdev->priv is equal to netdev_priv().
2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
   netdev_priv() is more flexible than netdev->priv.
But we cann't kill netdev->priv, because so many drivers reference to it
directly.

This patch is a safe convert for netdev->priv to netdev_priv(netdev).
Since all of the netdev->priv is only for read.
But it is too big to be sent in one mail.
I split it to 4 parts and make every part smaller than 100,000 bytes,
which is max size allowed by vger.

Signed-off-by: Wang Chen 
Signed-off-by: David S. Miller

net: struct device - replace bus_id with dev_name(), dev_set_name()

2008-11-10T21:55:14+00:00

Acked-by: Marcel Holtmann 
Acked-by: Greg Kroah-Hartman 
Signed-off-by: Kay Sievers 
Signed-off-by: David S. Miller

drivers/net: Kill now superfluous ->last_rx stores.

2008-11-04T05:11:17+00:00

The generic packet receive code takes care of setting
netdev->last_rx when necessary, for the sake of the
bonding ARP monitor.

Drivers need not do it any more.

Some cases had to be skipped over because the drivers
were making use of the ->last_rx value themselves.

Signed-off-by: David S. Miller

net: convert print_mac to %pM

2008-10-28T00:06:18+00:00

This converts pretty much everything to print_mac. There were
a few things that had conflicts which I have just dropped for
now, no harm done.

I've built an allyesconfig with this and looked at the files
that weren't built very carefully, but it's a huge patch.

Signed-off-by: Johannes Berg 
Signed-off-by: David S. Miller

drivers/net: use nr_irqs

2008-10-16T14:52:05+00:00

Signed-off-by: Yinghai Lu 
Signed-off-by: Ingo Molnar

3c59x: use netdev_alloc_skb

2008-08-07T06:22:15+00:00

Fix possible bug where end of receive buffer could be overwritten.
The allocation needs to allow for the reserved space. This would only happen
if device received packet greater than Ethernet standard MTU.

Change this driver to use netdev_alloc_skb rather than setting skb->dev
directly. For the initial allocation it doesn't need to be GFP_ATOMIC.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Jeff Garzik

3c59x: handle pci_name() being const

2008-07-22T04:55:03+00:00

This changes vortex_prob1() to handle pci_name() now returning a
constant string.

Cc: Steffen Klassert 
Signed-off-by: Greg Kroah-Hartman

[netdrvr] 3c59x: remove irqs_disabled warning from local_bh_enable

2008-06-27T05:30:33+00:00

Original Author: Michael Buesch 

net, vortex: fix lockup

Ingo Molnar reported:

-tip testing found that Johannes Berg's "softirq: remove irqs_disabled
warning from local_bh_enable" enhancement to lockdep triggers a new
warning on an old testbox that uses 3c59x vortex and netlogging:

----->
    calling  vortex_init+0x0/0xb0
    PCI: Found IRQ 10 for device 0000:00:0b.0
    PCI: Sharing IRQ 10 with 0000:00:0a.0
    PCI: Sharing IRQ 10 with 0000:00:0b.1
    3c59x: Donald Becker and others.
    0000:00:0b.0: 3Com PCI 3c556 Laptop Tornado at e0800400.
    PCI: Enabling bus mastering for device 0000:00:0b.0
    initcall vortex_init+0x0/0xb0 returned 0 after 47 msecs
...
    calling  init_netconsole+0x0/0x1b0
    netconsole: local port 4444
    netconsole: local IP 10.0.1.9
    netconsole: interface eth0
    netconsole: remote port 4444
    netconsole: remote IP 10.0.1.16
    netconsole: remote ethernet address 00:19:xx:xx:xx:xx
    netconsole: device eth0 not up yet, forcing it
    eth0:  setting half-duplex.
    eth0:  setting full-duplex.
------------[ cut here ]------------
    WARNING: at kernel/softirq.c:137 local_bh_enable_ip+0xd1/0xe0()
    Pid: 1, comm: swapper Not tainted 2.6.26-rc6-tip #2091
     [] warn_on_slowpath+0x4f/0x70
     [] ? release_console_sem+0x1b4/0x1d0
     [] ? vprintk+0x2a0/0x450
     [] ? __mod_timer+0xa5/0xc0
     [] ? mdio_sync+0x3d/0x50
     [] ? marker_probe_cb+0x46/0xa0
     [] ? printk+0x27/0x50
     [] ? vortex_set_duplex+0x43/0xc0
     [] ? vortex_set_duplex+0xa1/0xc0
     [] ? vortex_timer+0xe2/0x3e0
     [] local_bh_enable_ip+0xd1/0xe0
     [] _spin_unlock_bh+0x2f/0x40
     [] vortex_timer+0xe2/0x3e0
     [] ? trace_hardirqs_on+0xb/0x10
     [] ? trace_hardirqs_on_caller+0x88/0x160
     [] run_timer_softirq+0x162/0x1c0
     [] ? vortex_timer+0x0/0x3e0
     [] local_bh_enable_ip+0xd1/0xe0
     [] _spin_unlock_bh+0x2f/0x40
     [] vortex_timer+0xe2/0x3e0
     [] ? trace_hardirqs_on+0xb/0x10
     [] ? trace_hardirqs_on_caller+0x88/0x160
     [] run_timer_softirq+0x162/0x1c0
     [] ? vortex_timer+0x0/0x3e0
     [] ? vortex_timer+0x0/0x3e0
     [] __do_softirq+0x9a/0x160
     [] ? __do_softirq+0x0/0x160
     [] call_on_stack+0x15/0x30
     [] ? irq_exit+0x55/0x60
     [] ? do_IRQ+0x85/0xd0
     [] ? trace_hardirqs_on_caller+0xc1/0x160
     [] ? common_interrupt+0x28/0x30
     [] ? mutex_unlock+0x8/0x10
     [] ? _cond_resched+0x10/0x30
     [] ? netpoll_setup+0x117/0x390
     [] ? init_netconsole+0x14e/0x1b0
     [] ? ktime_get+0x19/0x40
     [] ? kernel_init+0x1b2/0x2c0
     [] ? init_netconsole+0x0/0x1b0
     [] ? trace_hardirqs_on_thunk+0xc/0x10
     [] ? restore_nocheck_notrace+0x0/0xe
     [] ? kernel_init+0x0/0x2c0
     [] ? kernel_init+0x0/0x2c0
     [] ? kernel_thread_helper+0x7/0x10
     =======================
---[ end trace 37f9c502aff112e0 ]---
    console [netcon0] enabled
    netconsole: network logging started
    initcall init_netconsole+0x0/0x1b0 returned 0 after 2914 msecs

looking at the driver I think the bug is real and the fix actually
is trivial.

vp->lock is also taken in hardware IRQ context, so we _have_ to always
use irqsafe locking. As we run in a timer with IRQs disabled,
we can simply use spin_lock.

Cc: 
Signed-off-by: Ingo Molnar 
Signed-off-by: Jeff Garzik

3c59x: use netstats in net_device structure

2008-05-06T16:22:11+00:00

Use net_device_stats from net_device structure instead of local.

Signed-off-by: Paulius Zaleckas 
Acked-by: Steffen Klassert 
Signed-off-by: Jeff Garzik