linux-toradex.git/drivers/net/3c59x.c, branch v2.6.25.10

vortex_up should initialize "err"

2007-10-18T00:23:30+00:00

Simple compile warning fix. (against 2.6.23-git12)

Thanks,
Badari

vortex_up() should initialize 'err' for a successful return.

drivers/net/3c59x.c: In function `vortex_up':
drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in this function

Signed-off-by: Badari Pulavarty 
Signed-off-by: Jeff Garzik

WOL bugfix for 3c59x.c

2007-10-17T01:10:29+00:00

Some NICs (3c905B) can not generate PME in power state PCI_D0, while others
like 3c905C can.  Call pci_enable_wake() with PCI_D3hot should give proper
WOL for 3c905B.

Signed-off-by: Steffen Klassert 
Tested-by: Harry Coin 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik

3c59x: trivial endianness annotations, NULL noise removal

2007-10-10T23:51:57+00:00

Signed-off-by: Al Viro 
Signed-off-by: Jeff Garzik

[netdrvr] Stop using legacy hooks ->self_test_count, ->get_stats_count

2007-10-10T23:51:45+00:00

These have been superceded by the new ->get_sset_count() hook.

Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

[NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()

2007-10-10T23:51:42+00:00

This is nicer than the MAC_FMT stuff.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

[NET]: Nuke SET_MODULE_OWNER macro.

2007-10-10T23:51:13+00:00

It's been a useless no-op for long enough in 2.6 so I figured it's time to
remove it.  The number of people that could object because they're
maintaining unified 2.4 and 2.6 drivers is probably rather small.

[ Handled drivers added by netdev tree and some missed IRDA cases... -DaveM ]

Signed-off-by: Ralf Baechle 
Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

3c59x: check return of pci_enable_device()

2007-10-10T23:50:46+00:00

Check return of pci_enable_device in vortex_up().

Also modify vortex_up to return error to callers. Handle failure of
vortex_up in vortex_open and vortex_resume.

Signed-off-by: Mark Hindley 
Signed-off-by: Jeff Garzik

3c59x: fix duplex configuration

2007-08-14T05:38:37+00:00

A special sequence of ifconfig up/down and plug/unplug the cable can break
the duplex configuration of the driver.

Setting
vp->mii.full_duplex = vp->full_duplex
in vortex_up should fix this.

Addresses Bug 8575 3c59x duplex configuration broken
http://bugzilla.kernel.org/show_bug.cgi?id=8575

Cc: Martin Buck 
Signed-off-by: Steffen Klassert 
Cc: Natalie Protasevich 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik

[NET]: ethtool_perm_addr only has one implementation

2007-07-31T21:00:29+00:00

All drivers implement ethtool get_perm_addr the same way -- by calling
the generic function.  So we can inline the generic function into the
caller and avoid going through the drivers.

Signed-off-by: Matthew Wilcox 
Signed-off-by: David S. Miller

3cSOHO100-TX needs EXTRA_PREAMBLE

2007-07-10T16:22:30+00:00

The 3cSOHO100-TX needs a mdio_sync() before mdio_read() to read the MII
transceiver registers properly.  Adding EXTRA_PREAMBLE to drv_flags of the
3cSOHO100-TX will force this.

This problem exists already for years (I checked back to 2.6.8).
Setting duplex for the 3cSOHO100-TX was more or less a random process.
Till 2.6.15 it was more likely that the diver ends up in half
duplex mode, after the code change in 2.6.16 it was more likely
to end up in full duplex mode. I wonder why nobody noticed this earier.

Hopefully addresses

Bug 7454 3c59x (3cSOHO100-TX Hurricane) slow network bug
http://bugzilla.kernel.org/show_bug.cgi?id=7454

and

Bug 3654 3cSOHO100-TX: No MII transceiver present
http://bugzilla.kernel.org/show_bug.cgi?id=3654

Cc: Jonas Sandberg 
Cc: Jon Sanchez 
Signed-off-by: Steffen Klassert 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik