linux-toradex.git/drivers/net/3c59x.c, branch v2.6.28.4

drivers/net: use nr_irqs

2008-10-16T14:52:05+00:00

Signed-off-by: Yinghai Lu 
Signed-off-by: Ingo Molnar

3c59x: use netdev_alloc_skb

2008-08-07T06:22:15+00:00

Fix possible bug where end of receive buffer could be overwritten.
The allocation needs to allow for the reserved space. This would only happen
if device received packet greater than Ethernet standard MTU.

Change this driver to use netdev_alloc_skb rather than setting skb->dev
directly. For the initial allocation it doesn't need to be GFP_ATOMIC.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Jeff Garzik

3c59x: handle pci_name() being const

2008-07-22T04:55:03+00:00

This changes vortex_prob1() to handle pci_name() now returning a
constant string.

Cc: Steffen Klassert 
Signed-off-by: Greg Kroah-Hartman

[netdrvr] 3c59x: remove irqs_disabled warning from local_bh_enable

2008-06-27T05:30:33+00:00

Original Author: Michael Buesch 

net, vortex: fix lockup

Ingo Molnar reported:

-tip testing found that Johannes Berg's "softirq: remove irqs_disabled
warning from local_bh_enable" enhancement to lockdep triggers a new
warning on an old testbox that uses 3c59x vortex and netlogging:

----->
    calling  vortex_init+0x0/0xb0
    PCI: Found IRQ 10 for device 0000:00:0b.0
    PCI: Sharing IRQ 10 with 0000:00:0a.0
    PCI: Sharing IRQ 10 with 0000:00:0b.1
    3c59x: Donald Becker and others.
    0000:00:0b.0: 3Com PCI 3c556 Laptop Tornado at e0800400.
    PCI: Enabling bus mastering for device 0000:00:0b.0
    initcall vortex_init+0x0/0xb0 returned 0 after 47 msecs
...
    calling  init_netconsole+0x0/0x1b0
    netconsole: local port 4444
    netconsole: local IP 10.0.1.9
    netconsole: interface eth0
    netconsole: remote port 4444
    netconsole: remote IP 10.0.1.16
    netconsole: remote ethernet address 00:19:xx:xx:xx:xx
    netconsole: device eth0 not up yet, forcing it
    eth0:  setting half-duplex.
    eth0:  setting full-duplex.
------------[ cut here ]------------
    WARNING: at kernel/softirq.c:137 local_bh_enable_ip+0xd1/0xe0()
    Pid: 1, comm: swapper Not tainted 2.6.26-rc6-tip #2091
     [] warn_on_slowpath+0x4f/0x70
     [] ? release_console_sem+0x1b4/0x1d0
     [] ? vprintk+0x2a0/0x450
     [] ? __mod_timer+0xa5/0xc0
     [] ? mdio_sync+0x3d/0x50
     [] ? marker_probe_cb+0x46/0xa0
     [] ? printk+0x27/0x50
     [] ? vortex_set_duplex+0x43/0xc0
     [] ? vortex_set_duplex+0xa1/0xc0
     [] ? vortex_timer+0xe2/0x3e0
     [] local_bh_enable_ip+0xd1/0xe0
     [] _spin_unlock_bh+0x2f/0x40
     [] vortex_timer+0xe2/0x3e0
     [] ? trace_hardirqs_on+0xb/0x10
     [] ? trace_hardirqs_on_caller+0x88/0x160
     [] run_timer_softirq+0x162/0x1c0
     [] ? vortex_timer+0x0/0x3e0
     [] local_bh_enable_ip+0xd1/0xe0
     [] _spin_unlock_bh+0x2f/0x40
     [] vortex_timer+0xe2/0x3e0
     [] ? trace_hardirqs_on+0xb/0x10
     [] ? trace_hardirqs_on_caller+0x88/0x160
     [] run_timer_softirq+0x162/0x1c0
     [] ? vortex_timer+0x0/0x3e0
     [] ? vortex_timer+0x0/0x3e0
     [] __do_softirq+0x9a/0x160
     [] ? __do_softirq+0x0/0x160
     [] call_on_stack+0x15/0x30
     [] ? irq_exit+0x55/0x60
     [] ? do_IRQ+0x85/0xd0
     [] ? trace_hardirqs_on_caller+0xc1/0x160
     [] ? common_interrupt+0x28/0x30
     [] ? mutex_unlock+0x8/0x10
     [] ? _cond_resched+0x10/0x30
     [] ? netpoll_setup+0x117/0x390
     [] ? init_netconsole+0x14e/0x1b0
     [] ? ktime_get+0x19/0x40
     [] ? kernel_init+0x1b2/0x2c0
     [] ? init_netconsole+0x0/0x1b0
     [] ? trace_hardirqs_on_thunk+0xc/0x10
     [] ? restore_nocheck_notrace+0x0/0xe
     [] ? kernel_init+0x0/0x2c0
     [] ? kernel_init+0x0/0x2c0
     [] ? kernel_thread_helper+0x7/0x10
     =======================
---[ end trace 37f9c502aff112e0 ]---
    console [netcon0] enabled
    netconsole: network logging started
    initcall init_netconsole+0x0/0x1b0 returned 0 after 2914 msecs

looking at the driver I think the bug is real and the fix actually
is trivial.

vp->lock is also taken in hardware IRQ context, so we _have_ to always
use irqsafe locking. As we run in a timer with IRQs disabled,
we can simply use spin_lock.

Cc: 
Signed-off-by: Ingo Molnar 
Signed-off-by: Jeff Garzik

3c59x: use netstats in net_device structure

2008-05-06T16:22:11+00:00

Use net_device_stats from net_device structure instead of local.

Signed-off-by: Paulius Zaleckas 
Acked-by: Steffen Klassert 
Signed-off-by: Jeff Garzik

3c980-TX needs EXTRA_PREAMBLE

2008-05-06T16:22:10+00:00

The ethernet card 3c980-TX needs a mdio_sync() to initialize the ethernet
properly. This is forced by adding an EXTRA_PREAMBLE to its drv_flags.

Without this, the driver did not reconnect after a link loss.

Signed-off-by: Gunnar Larisch 
Acked-by: Steffen Klassert 
Signed-off-by: Jeff Garzik

vortex_up should initialize "err"

2007-10-18T00:23:30+00:00

Simple compile warning fix. (against 2.6.23-git12)

Thanks,
Badari

vortex_up() should initialize 'err' for a successful return.

drivers/net/3c59x.c: In function `vortex_up':
drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in this function

Signed-off-by: Badari Pulavarty 
Signed-off-by: Jeff Garzik

WOL bugfix for 3c59x.c

2007-10-17T01:10:29+00:00

Some NICs (3c905B) can not generate PME in power state PCI_D0, while others
like 3c905C can.  Call pci_enable_wake() with PCI_D3hot should give proper
WOL for 3c905B.

Signed-off-by: Steffen Klassert 
Tested-by: Harry Coin 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik

3c59x: trivial endianness annotations, NULL noise removal

2007-10-10T23:51:57+00:00

Signed-off-by: Al Viro 
Signed-off-by: Jeff Garzik

[netdrvr] Stop using legacy hooks ->self_test_count, ->get_stats_count

2007-10-10T23:51:45+00:00

These have been superceded by the new ->get_sset_count() hook.

Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller