linux-toradex.git/drivers/net/bonding/bond_sysfs.c, branch v2.6.25.10

[BOND]: Fix warning in bond_sysfs.c

2008-03-28T23:15:38+00:00

original_mtu is only used if we end up with a non-NULL
dev, and it is assigned in all such cases, but GCC can't
see that.

Signed-off-by: David S. Miller

bonding: fix lock ordering for rtnl and bonding_rwsem

2008-01-18T19:38:39+00:00

Fix the handling of rtnl and the bonding_rwsem to always be acquired
in a consistent order (rtnl, then bonding_rwsem).

The existing code sometimes acquired them in this order, and sometimes
in the opposite order, which opens a window for deadlock between ifenslave
and sysfs.

Signed-off-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik

bonding: Fix up parameter parsing

2008-01-18T19:38:38+00:00

	A recent change to add an additional hash policy modified
bond_parse_parm, but it now does not correctly match parameters passed in
via sysfs.

	Rewrote bond_parse_parm to handle (a) parameter matches that
are substrings of one another and (b) user input with whitespace (e.g.,
sysfs input often has a trailing newline).

Signed-off-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik

bonding: fix locking in sysfs primary/active selection

2008-01-18T19:38:38+00:00

	Fix the functions that store the primary and active slave
options via sysfs to hold the correct locks in the correct order.

	The bond_change_active_slave and bond_select_active_slave
functions both require rtnl, bond->lock for read and curr_slave_lock for
write_bh, and no other locks.  This is so that the lower level
mode-specific functions (notably for balance-alb mode) can release locks
down to just rtnl in order to call, e.g., dev_set_mac_address with the
locks it expects (rtnl only).

Signed-off-by: Jay Vosburgh 
Signed-off-by: Andy Gospodarek 
Signed-off-by: Jeff Garzik

bonding: Allow setting and querying xmit policy regardless of mode

2007-12-07T20:00:28+00:00

From: Wagner Ferenc 

For consistency with the behaviour of the arp_ip_target option,
let /sys/class/net/bond0/bonding/xmit_hash_policy accept and report
current policy even if the bonding mode in effect does not use it.

Signed-off-by: Ferenc Wagner 
Acked-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik

bonding: Coding style: break line after the if condition

2007-12-07T20:00:27+00:00

From: Wagner Ferenc 

Adhere to coding style: break line after the if condition

Signed-off-by: Ferenc Wagner 
Acked-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik

bonding: Purely cosmetic: rename a local variable

2007-12-07T20:00:26+00:00

From: Wagner Ferenc 

Code for rendering multivalue sysfs files occurs three times
in this module.  Rename 'buffer' to 'buf' in the first, for
the sake of consistency.

Signed-off-by: Ferenc Wagner 
Acked-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik

bonding: Return nothing for not applicable values

2007-12-07T20:00:25+00:00

From: Wagner Ferenc 

The previous code returned '\n' (that is, a single empty line)
from most files, with one exception (xmit_hash_policy), where
it returned 'NA\n'.  This patch consolidates each file to return
nothing at all if not applicable, not even a '\n'.

I find this behaviour more usual, more useful, more efficient
and shorter to code from both sides.

Signed-off-by: Ferenc Wagner 
Acked-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik

bonding: Remove trailing NULs from sysfs interface.

2007-12-07T20:00:18+00:00

From: Wagner Ferenc 

Also remove trailing spaces from multivalued files.

This fixes output like for example:

$ od -c /sys/class/net/bond0/bonding/slaves
0000000   e   t   h   -   l   e   f   t       e   t   h   -   r   i   g
0000020   h   t      \n  \0
0000025

It mostly entails deleting '+1'-s after sprintf() calls: the return value
of sprintf is the number of characters printed, without the closing NUL,
ie. exactly what the sysfs interface requires.  The three multivalue
cases are different, because they also have to swallow back a trailing
space.

Signed-off-by: Ferenc Wagner 
Acked-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik

bonding: fix rtnl locking merge error

2007-11-10T09:25:14+00:00

	Looks like I incorrectly merged one of the rtnl lock changes,
so that one function, bonding_show_active_slave, held rtnl but didn't
release it, and another, bonding_store_active_slave, never held rtnl but
did release it.

	Fixed so the first function doesn't mess with rtnl, and the
second correctly acquires and releases rtnl.

	Bug reported by Moni Shoua 

Signed-off-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik