linux-toradex.git/drivers/net/caif/caif_serial.c, branch v3.2.32

caif: fix NULL pointer check

2012-08-19T17:15:23+00:00

[ Upstream commit c66b9b7d365444b433307ebb18734757cb668a02 ]

Reported-by: 
Resolves-bug: http://bugzilla.kernel.org/show_bug?44441
Signed-off-by: Alan Cox 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

net: Remove unneeded version.h includes from drivers/net/

2011-06-24T09:40:08+00:00

It was pointed out by 'make versioncheck' that some includes of
linux/version.h are not needed in drivers/net/.
This patch removes them.

Signed-off-by: Jesper Juhl 
Signed-off-by: David S. Miller

net: remove interrupt.h inclusion from netdevice.h

2011-06-07T05:55:11+00:00

* remove interrupt.g inclusion from netdevice.h -- not needed
* fixup fallout, add interrupt.h and hardirq.h back where needed.

Signed-off-by: Alexey Dobriyan 
Signed-off-by: David S. Miller

Revert "tty: make receive_buf() return the amout of bytes received"

2011-06-03T21:33:24+00:00

This reverts commit b1c43f82c5aa265442f82dba31ce985ebb7aa71c.

It was broken in so many ways, and results in random odd pty issues.

It re-introduced the buggy schedule_work() in flush_to_ldisc() that can
cause endless work-loops (see commit a5660b41af6a: "tty: fix endless
work loop when the buffer fills up").

It also used an "unsigned int" return value fo the ->receive_buf()
function, but then made multiple functions return a negative error code,
and didn't actually check for the error in the caller.

And it didn't actually work at all.  BenH bisected down odd tty behavior
to it:
  "It looks like the patch is causing some major malfunctions of the X
   server for me, possibly related to PTYs.  For example, cat'ing a
   large file in a gnome terminal hangs the kernel for -minutes- in a
   loop of what looks like flush_to_ldisc/workqueue code, (some ftrace
   data in the quoted bits further down).

   ...

   Some more data: It -looks- like what happens is that the
   flush_to_ldisc work queue entry constantly re-queues itself (because
   the PTY is full ?) and the workqueue thread will basically loop
   forver calling it without ever scheduling, thus starving the consumer
   process that could have emptied the PTY."

which is pretty much exactly the problem we fixed in a5660b41af6a.

Milton Miller pointed out the 'unsigned int' issue.

Reported-by: Benjamin Herrenschmidt 
Reported-by: Milton Miller 
Cc: Stefan Bigler 
Cc: Toby Gray 
Cc: Felipe Balbi 
Cc: Greg Kroah-Hartman 
Cc: Alan Cox 
Signed-off-by: Linus Torvalds

tty: make receive_buf() return the amout of bytes received

2011-04-23T00:31:53+00:00

it makes it simpler to keep track of the amount of
bytes received and simplifies how flush_to_ldisc counts
the remaining bytes. It also fixes a bug of lost bytes
on n_tty when flushing too many bytes via the USB
serial gadget driver.

Tested-by: Stefan Bigler 
Tested-by: Toby Gray 
Signed-off-by: Felipe Balbi 
Signed-off-by: Greg Kroah-Hartman

caif: Use link layer MTU instead of fixed MTU

2010-06-21T02:46:06+00:00

Previously CAIF supported maximum transfer size of ~4050.
The transfer size is now calculated dynamically based on the
link layers mtu size.

Signed-off-by: Sjur Braendeland@stericsson.com
Signed-off-by: David S. Miller

caif: add newlines after declarations in caif_serial.c

2010-06-02T12:16:22+00:00

I added newlines after the declarations in caif_serial.c.  This is
normal kernel style, although I can't see anywhere it's documented.

Signed-off-by: Dan Carpenter 
Signed-off-by: David S. Miller

caif: remove unneeded variable from caif_net_open()

2010-06-02T12:16:21+00:00

We don't use the "ser" variable so I've removed it.

Signed-off-by: Dan Carpenter 
Acked-by: Sjur Braendeland 
Signed-off-by: David S. Miller

caif: Ldisc add permission check and mem-alloc error check

2010-04-28T19:55:10+00:00

Changes:
   o Added permission checks for installing. CAP_SYS_ADMIN and
     CAP_SYS_TTY_CONFIG can install the ldisc.
   o Check if allocation of skb was successful.

Signed-off-by: Sjur Braendeland 
Signed-off-by: David S. Miller

caif: tty's are kref objects so take a reference

2010-04-07T23:50:00+00:00

I don't think this can be abused in this case but do things properly.

Signed-off-by: Alan Cox 
Signed-off-by: David S. Miller