linux-toradex.git/drivers/net/dsa/lan9303-core.c, branch v4.14

net: dsa: make dsa_switch_ops const

2017-08-10T05:42:49+00:00

Make these structures const as they are only stored in the ops field of
a dsa_switch structure, which is const.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal 
Reviewed-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: lan9303: Only allocate 3 ports

2017-08-09T01:13:59+00:00

Save 2628 bytes on arm eabi by allocate only the required 3 ports.

Now that ds->num_ports is correct: In net/dsa/tag_lan9303.c
eliminate duplicate LAN9303_MAX_PORTS, use ds->num_ports.
(Matching the pattern of other net/dsa/tag_xxx.c files.)

Signed-off-by: Egil Hjelmeland 
Reviewed-by: Florian Fainelli 
Reviewed-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: lan9303: refactor lan9303_get_ethtool_stats

2017-08-07T21:18:01+00:00

In lan9303_get_ethtool_stats: Get rid of 0x400 constant magic
by using new lan9303_read_switch_reg() inside loop.
Reduced scope of two variables.

Signed-off-by: Egil Hjelmeland 
Reviewed-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: dsa: lan9303: Rename lan9303_xxx_packet_processing()

2017-08-07T21:18:01+00:00

The lan9303_enable_packet_processing, lan9303_disable_packet_processing
functions operate on port, so the names should reflect that.
And to align with lan9303_disable_processing(), rename:

lan9303_enable_packet_processing -> lan9303_enable_processing_port
lan9303_disable_packet_processing -> lan9303_disable_processing_port

Signed-off-by: Egil Hjelmeland 
Reviewed-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

2017-08-07T21:18:01+00:00

Simplify usage of lan9303_enable_packet_processing,
lan9303_disable_packet_processing()

Signed-off-by: Egil Hjelmeland 
Reviewed-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: dsa: lan9303: define LAN9303_NUM_PORTS 3

2017-08-07T21:18:01+00:00

Will be used instead of '3' in upcomming patches.

Signed-off-by: Egil Hjelmeland 
Signed-off-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: dsa: lan9303: Change lan9303_xxx_packet_processing() port param.

2017-08-07T21:18:01+00:00

lan9303_enable_packet_processing, lan9303_disable_packet_processing()
Pass port number (0,1,2) as parameter instead of port offset.
Because other functions in the module pass port numbers.
And to enable simplifications in following patch.

Introduce lan9303_write_switch_port().

Signed-off-by: Egil Hjelmeland 
Reviewed-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: dsa: lan9303: MDIO access phy registers directly

2017-07-31T02:23:29+00:00

Indirect access (PMI) to phy register only work in I2C mode. In
MDIO mode phy registers must be accessed directly. Introduced
struct lan9303_phy_ops to handle the two modes.

Signed-off-by: Egil Hjelmeland 
Reviewed-by: Andrew Lunn 
Reviewed-by: Vivien Didelot 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: dsa: lan9303: Renamed indirect phy access functions

2017-07-31T02:23:29+00:00

Preparing for the following fix of MDIO phy access:

Renamed functions that access PHY 1 and 2 indirectly through PMI
registers.

 lan9303_port_phy_reg_wait_for_completion() to
 lan9303_indirect_phy_wait_for_completion()

 lan9303_port_phy_reg_read() to
 lan9303_indirect_phy_read()

 lan9303_port_phy_reg_write() to
 lan9303_indirect_phy_write()

Also changed "val" parameter of lan9303_indirect_phy_write() to u16,
for clarity.

Signed-off-by: Egil Hjelmeland 
Reviewed-by: Andrew Lunn 
Reviewed-by: Vivien Didelot 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: dsa: lan9303: Multiply by 4 to get MDIO register

2017-07-31T02:23:29+00:00

lan9303_mdio_write()/_read() must multiply register number by 4 to get
offset.

Added some commments to the register definitions.

Signed-off-by: Egil Hjelmeland 
Reviewed-by: Andrew Lunn 
Reviewed-by: Vivien Didelot 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller