linux-toradex.git/drivers/net/e1000e, branch v3.0.3

e1000e: alternate MAC address does not work on device id 0x1060

2011-08-16T01:31:42+00:00

commit c407bee8a56d874b91f3e4ee790660959ff1a25e upstream.

This issue is present all the way back to 2.6.34 kernels.

Signed-off-by: Bruce Allan 
Tested-by: Jeffrey Pieper 
Signed-off-by: Jeff Kirsher 
Signed-off-by: Greg Kroah-Hartman

Merge branch 'linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6

2011-05-23T22:39:34+00:00

* 'linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6: (27 commits)
  PCI: Don't use dmi_name_in_vendors in quirk
  PCI: remove unused AER functions
  PCI/sysfs: move bus cpuaffinity to class dev_attrs
  PCI: add rescan to /sys/.../pci_bus/.../
  PCI: update bridge resources to get more big ranges when allocating space (again)
  KVM: Use pci_store/load_saved_state() around VM device usage
  PCI: Add interfaces to store and load the device saved state
  PCI: Track the size of each saved capability data area
  PCI/e1000e: Add and use pci_disable_link_state_locked()
  x86/PCI: derive pcibios_last_bus from ACPI MCFG
  PCI: add latency tolerance reporting enable/disable support
  PCI: add OBFF enable/disable support
  PCI: add ID-based ordering enable/disable support
  PCI hotplug: acpiphp: assume device is in state D0 after powering on a slot.
  PCI: Set PCIE maxpayload for card during hotplug insertion
  PCI/ACPI: Report _OSC control mask returned on failure to get control
  x86/PCI: irq and pci_ids patch for Intel Panther Point DeviceIDs
  PCI: handle positive error codes
  PCI: check pci_vpd_pci22_wait() return
  PCI: Use ICH6_GPIO_EN in ich6_lpc_acpi_gpio
  ...

Fix up trivial conflicts in include/linux/pci_ids.h: commit a6e5e2be4461
moved the intel SMBUS ID definitons to the i2c-i801.c driver.

Add appropriate include for prefetch users

2011-05-23T04:41:57+00:00

After discovering that wide use of prefetch on modern CPUs
could be a net loss instead of a win, net drivers which were
relying on the implicit inclusion of prefetch.h via the list
headers showed up in the resulting cleanup fallout.  Give
them an explicit include via the following $0.02 script.

 =========================================
 #!/bin/bash
 MANUAL=""
 for i in `git grep -l 'prefetch(.*)' .` ; do
 	grep -q '' $i
 	if [ $? = 0 ] ; then
 		continue
 	fi

 	(	echo '?^#include '
 		echo .
 		echo w
 		echo q
 	) | ed -s $i > /dev/null 2>&1
 	if [ $? != 0 ]; then
 		echo $i needs manual fixup
 		MANUAL="$i $MANUAL"
 	fi
 done
 echo ------------------- 8\<----------------------
 echo vi $MANUAL
 =========================================

Signed-off-by: Paul 
[ Fixed up some incorrect #include placements, and added some
  non-network drivers and the fib_trie.c case    - Linus ]
Signed-off-by: Linus Torvalds

PCI/e1000e: Add and use pci_disable_link_state_locked()

2011-05-21T19:16:44+00:00

Need to use it in _e1000e_disable_aspm.  This routine is used for error
recovery, where the pci_bus_sem is already held, and we don't want
pci_disable_link_state to try to take it again.  So add a locked variant
for use in cases like this.

Found lock up:

[ 2374.654557] kworker/32:1    D ffff881027f6b0f0     0  6075      2 0x00000000
[ 2374.654816]  ffff88503f099a68 0000000000000046 ffff88503f098000 0000000000004000
[ 2374.654837]  00000000001d1ec0 ffff88503f099fd8 00000000001d1ec0 ffff88503f099fd8
[ 2374.654860]  0000000000004000 00000000001d1ec0 ffff88503dcc8000 ffff88503f090000
[ 2374.654880] Call Trace:
[ 2374.654898]  [] ? __lock_acquired+0x3a/0x224
[ 2374.654914]  [] ? _raw_spin_unlock_irq+0x30/0x36
[ 2374.654925]  [] ? trace_hardirqs_on_caller+0x1f/0x178
[ 2374.654936]  [] rwsem_down_failed_common+0xd3/0x103
[ 2374.654945]  [] ? __lock_contended+0x3a/0x2a2
[ 2374.654955]  [] rwsem_down_read_failed+0x12/0x14
[ 2374.654967]  [] call_rwsem_down_read_failed+0x14/0x30
[ 2374.654981]  [] ? pci_disable_link_state+0x5f/0xf5
[ 2374.654990]  [] ? down_read+0x7e/0x91
[ 2374.654999]  [] ? pci_disable_link_state+0x5f/0xf5
[ 2374.655008]  [] pci_disable_link_state+0x5f/0xf5
[ 2374.655024]  [] e1000e_disable_aspm+0x55/0x5a
[ 2374.655037]  [] e1000_io_slot_reset+0x59/0xea
[ 2374.655048]  [] ? report_mmio_enabled+0x5d/0x5d
[ 2374.655057]  [] report_slot_reset+0x2e/0x5d
[ 2374.655072]  [] pci_walk_bus+0x8a/0xb7
[ 2374.655081]  [] ? report_mmio_enabled+0x5d/0x5d
[ 2374.655091]  [] broadcast_error_message+0xa4/0xb2
[ 2374.655101]  [] ? pci_bus_read_config_dword+0x72/0x80
[ 2374.655110]  [] do_recovery+0x9e/0xf9
[ 2374.655120]  [] handle_error_source+0x4c/0x51
[ 2374.655129]  [] aer_isr_one_error+0x1e9/0x21a
[ 2374.655138]  [] aer_isr+0xc7/0xcc
[ 2374.655147]  [] ? aer_isr_one_error+0x21a/0x21a
[ 2374.655159]  [] process_one_work+0x237/0x3ec
[ 2374.655168]  [] ? process_one_work+0x1a8/0x3ec
[ 2374.655178]  [] worker_thread+0x17c/0x240
[ 2374.655186]  [] ? trace_hardirqs_on+0xd/0xf
[ 2374.655196]  [] ? manage_workers+0xab/0xab
[ 2374.655209]  [] kthread+0xa0/0xa8
[ 2374.655223]  [] kernel_thread_helper+0x4/0x10
[ 2374.655232]  [] ? retint_restore_args+0xe/0xe
[ 2374.655243]  [] ? __init_kthread_worker+0x5b/0x5b
[ 2374.655252]  [] ? gs_change+0xb/0xb

when aer happens,
pci_walk_bus already have down_read(&pci_bus_sem)...
then report_slot_reset
        ==> e1000_io_slot_reset
                ==> e1000e_disable_aspm
                        ==> pci_disable_link_state...

We can not use pci_disable_link_state, and it will try to hold pci_bus_sem again.

Try to have __pci_disable_link_state that will not need to hold pci_bus_sem.

-v2: change name to pci_disable_link_state_locked() according to Jesse.

[jbarnes: make sure new function is exported for modules]

Signed-off-by: Yinghai Lu 
Signed-off-by: Jesse Barnes

e1000e: minor comment cleanups

2011-05-15T00:50:01+00:00

Signed-off-by: Bruce Allan 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher

net/igb/e1000/e1000e: more robust ethtool duplex/speed configuration

2011-04-29T21:03:03+00:00

This makes sure that one cannot request a 99Mbps full-duplex and get a
100Mbps half-duplex configuration in return due to the way the
speed/duplex parameters are handled internally.

Tested: e1000 works
Signed-off-by: David Decotigny 
Signed-off-by: David S. Miller

ethtool: cosmetic: Use ethtool ethtool_cmd_speed API

2011-04-29T21:03:01+00:00

This updates the network drivers so that they don't access the
ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
instead.

For most of the drivers, these changes are purely cosmetic and don't
fix any problem, such as for those 1GbE/10GbE drivers that indirectly
call their own ethtool get_settings()/mii_ethtool_gset(). The changes
are meant to enforce code consistency and provide robustness with
future larger throughputs, at the expense of a few CPU cycles for each
ethtool operation.

All drivers compiled with make allyesconfig ion x86_64 have been
updated.

Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
Signed-off-by: David Decotigny 
Signed-off-by: David S. Miller

ethtool: Use full 32 bit speed range in ethtool's set_settings

2011-04-29T21:03:00+00:00

This makes sure the ethtool's set_settings() callback of network
drivers don't ignore the 16 most significant bits when ethtool calls
their set_settings().

All drivers compiled with make allyesconfig on x86_64 have been
updated.

Signed-off-by: David Decotigny 
Signed-off-by: David S. Miller

e1000e: implement ethtool set_phys_id

2011-04-27T09:05:53+00:00

Based on a patch from Stephen Hemminger .

The new ethtool set_phys_id takes over controlling the LED for
identifying boards.  This fixes the lockout during that period.
For this device lots of extra infrastructure can also be removed by
using set_phys_id.

v2: - return blink frequency for parts that do not support blink in h/w
    - add blink_led function pointers for devices that do support blink
      in h/w to cleanup the test for this functionality

Signed-off-by: Bruce Allan 
Cc: Stephen Hemminger 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher

e1000e: If ASPM L0s needs to be disabled, do it prior to enabling device

2011-04-14T02:19:22+00:00

Based on a patch from Naga Chumbalkar :

If ASPM L0s needs to be disabled due to HW errata, do it prior to
"enabling" the device. This way if the kernel ever defaults its
aspm_policy to POLICY_POWERSAVE, then the e1000e driver will get a
chance to disable ASPM on the misbehaving device *prior* to calling
pci_enable_device_mem(). This will be useful in situations
where the BIOS indicates ASPM support on the server by clearing the
ACPI FADT "ASPM Controls" bit.

Note:
The kernel (2.6.38) currently uses the BIOS "default" as its aspm_policy.
However, Linux distros can diverge from that and set the default to
"powersave".

v2: o cleanup namespace pollution of e1000e_disable_aspm(),
    o fix type and initialization of the new aspm_disable_flag in a few
      functions, and
    o redefine FLAG2_DISABLE_ASPM_L0S to the first unused bit in
      adapter->flags2.

Signed-off-by: Bruce Allan 
Cc: Naga Chumbalkar 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher