linux-toradex.git/drivers/net/ethernet/broadcom, branch v3.9.4

bnx2x: Fix status blocks configuration

2013-04-18T19:03:26+00:00

This fixes 2 issues regarding bnx2x's status blocks:

   1. ethtool -c caused corruption of status blocks in FW RAM.

   2. when using multi-CoS, the configuration of the timeout values of
      status blocks is incorrect, harming the coalescing of interrupts
      for such CoSs.

Signed-off-by: Ariel Elior 
Signed-off-by: Yuval Mintz 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: Prevent UNDI FW illegal host access

2013-04-18T19:03:25+00:00

When loading after UNDI (e.g., Boot from SAN) the UNDI does not
gracefully yield its resources; The bnx2x driver handles that release
itself.

During the manipulation required to release those resources, it's possible
for the UNDI to try and write to memory regions which are no longer accessible,
causing the PCI bus to prevent further writes from the chip.

This would in turn cause DMAE timeouts later on in the driver, as the driver
will be unable to use the chip's DMA engines.

This patch prevents the chip from actually writing through the PCI bus
in said scenario, thus allowing the release without the unfortunate by-product.

Signed-off-by: Dmitry Kravkov 
Signed-off-by: Yuval Mintz 
Signed-off-by: Ariel Elior 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: Prevent null pointer dereference in AFEX mode

2013-04-10T19:27:04+00:00

The cnic module is responsible for initializing various bnx2x structs
via callbacks provided by the bnx2x module.
One such struct is the queue object for the FCoE queue.

If a device is working in AFEX mode and its configuration allows FCoE yet
the cnic module is not loaded, it's very likely a null pointer dereference
will occur, as the bnx2x will erroneously access the FCoE's queue object.

Prevent said access until cnic properly registers itself.

Signed-off-by: Yuval Mintz 
Signed-off-by: Ariel Elior 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: Fix KR2 rapid link flap

2013-04-07T21:17:00+00:00

Check KR2 recovery time at the beginning of the work-around function.

Signed-off-by: Yaniv Rosner 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

tg3: fix length overflow in VPD firmware parsing

2013-03-27T18:06:41+00:00

Commit 184b89044fb6e2a74611dafa69b1dce0d98612c6 ("tg3: Use VPD fw version
when present") introduced VPD parsing that contained a potential length
overflow.

Limit the hardware's reported firmware string length (max 255 bytes) to
stay inside the driver's firmware string length (32 bytes). On overflow,
truncate the formatted firmware string instead of potentially overwriting
portions of the tg3 struct.

http://cansecwest.com/slides/2013/PrivateCore%20CSW%202013.pdf

Signed-off-by: Kees Cook 
Reported-by: Oded Horovitz 
Reported-by: Brad Spengler 
Cc: stable@vger.kernel.org
Cc: Matt Carlson 
Signed-off-by: David S. Miller

bnx2x: fix assignment of signed expression to unsigned variable

2013-03-24T21:27:28+00:00

fix for incorrect assignment of signed expression to unsigned variable.

Signed-off-by: Kumar Amit Mehta 
Acked-by: Dmitry Kravkov 
Signed-off-by: David S. Miller

bnx2x: fix occasional statistics off-by-4GB error

2013-03-18T17:12:20+00:00

The UPDATE_QSTAT function introduced on February 15, 2012
in commit 1355b704b9ba "bnx2x: consistent statistics after
internal driver reload" incorrectly fails to handle overflow
during addition of the lower 32-bit field of a stat.

This bug is present since 3.4-rc1 and should thus be considered
a candidate for stable 3.4+ releases.

Google-Bug-Id: 8374428
Signed-off-by: Maciej Żenczykowski 
Cc: Mintz Yuval 
Acked-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: add missing napi deletion in error path

2013-03-17T16:26:52+00:00

If the hardware initialization fails in bnx2x_nic_load() after adding
napi objects, they would not be deleted. A subsequent attempt to unload
the bnx2x module detects a corruption in the napi list.

Add the missing napi deletion to the error path.

Signed-off-by: Michal Schmidt 
Acked-by: Dmitry Kravkov 
Signed-off-by: David S. Miller

tg3: 5715 does not link up when autoneg off

2013-03-13T13:54:05+00:00

Commit d13ba512cbba7de5d55d7a3b2aae7d83c8921457 ("tg3: Remove
SPEED_UNKNOWN checks") cleaned up the autoneg advertisement by
removing some dead code. One effect of this change was that the
advertisement register would not be updated if autoneg is turned off.

This exposed a bug on the 5715 device w.r.t linking. The 5715 defaults
to advertise only 10Mb Full duplex. But with autoneg disabled, it needs
the configured speed enabled in the advertisement register to link up.

This patch adds the work around to advertise all speeds on the 5715 when
autoneg is disabled.

Reported-by: Marcin Miotk 
Reviewed-by: Benjamin Li 
Signed-off-by: Nithin Nayak Sujir 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

tg3: Update link_up flag for phylib devices

2013-03-08T18:14:58+00:00

Commit f4a46d1f46a8fece34edd2023e054072b02e110d introduced a bug where
the ifconfig stats would remain 0 for phylib devices. This is due to
tp->link_up flag never becoming true causing tg3_periodic_fetch_stats()
to return.

The link_up flag was being updated in tg3_test_and_report_link_chg()
after setting up the phy. This function however, is not called for
phylib devices since the driver does not do the phy setup.

This patch moves the link_up flag update into the common
tg3_link_report() function that gets called for phylib devices as well
for non phylib devices when the link state changes.

To avoid updating link_up twice, we replace tg3_carrier_...() calls that
are followed by tg3_link_report(), with netif_carrier_...(). We can then
remove the unused tg3_carrier_on() function.

CC: 
Reported-by: OGAWA Hirofumi 
Signed-off-by: Nithin Nayak Sujir 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller