linux-toradex.git/drivers/net/ethernet/dec, branch v3.6.1

ethernet: Remove casts to same type

2012-06-06T16:31:33+00:00

Adding casts of objects to the same type is unnecessary
and confusing for a human reader.

For example, this cast:

        int y;
        int *p = (int *)&y;

I used the coccinelle script below to find and remove these
unnecessary casts.  I manually removed the conversions this
script produces of casts with __force, __iomem and __user.

@@
type T;
T *p;
@@

-       (T *)p
+       p

A function in atl1e_main.c was passed a const pointer
when it actually modified elements of the structure.

Change the argument to a non-const pointer.

A function in stmmac needed a __force to avoid a sparse
warning.  Added it.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

drivers/net: Convert compare_ether_addr to ether_addr_equal

2012-05-11T03:33:01+00:00

Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.

Done via cocci script:

$ cat compare_ether_addr.cocci
@@
expression a,b;
@@
-	!compare_ether_addr(a, b)
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	compare_ether_addr(a, b)
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!ether_addr_equal(a, b) == 0
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!ether_addr_equal(a, b) != 0
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	ether_addr_equal(a, b) == 0
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	ether_addr_equal(a, b) != 0
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!!ether_addr_equal(a, b)
+	ether_addr_equal(a, b)

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

dmfe: enforce consistent timing delay.

2012-04-18T02:54:13+00:00

The driver does not always use the same timing for what looks like
the same operations.

- DCR0
  Use the same udelay everywhere for reset. Upper bound is 100 us.
- DCR9
  Use 5us delay for srom clock. 1us delay for phy_write_1bit (writes
  PHY_DATA_[01]) are not changed as they stay withing a 2,5MHz MDIO
  clock range.

Signed-off-by: Francois Romieu 
Reviewed-by: Grant Grundler 
Signed-off-by: David S. Miller

dmfe: stop using net_device.{base_addr, irq} and convert to __iomem.

2012-04-07T09:47:18+00:00

This is a pure PCI driver, no ISA here.

Signed-off-by: Francois Romieu 
Acked-by: Grant Grundler

uli526x: stop using net_device.{base_addr, irq} and convert to __iomem.

2012-04-07T09:47:17+00:00

The bulk of the patch comes from the __iomem changes.

- the phy read and write operations were carrying the chip id deep
  down the call chain. Let's waste a pointer and contain the flying
  spaghetti monster.
- phy_{read, write}_1bit only need to access the DCR9 register. The loss
  of generality here should not hurt.
- removed a leftover printk of the EISA era. This is a pure PCI device.

Signed-off-by: Francois Romieu 
Acked-by: Grant Grundler

de2104x: stop using net_device.{base_addr, irq}.

2012-04-07T09:47:16+00:00

Signed-off-by: Francois Romieu 
Acked-by: Grant Grundler

xircom_cb: stop using net_device.{base_addr, irq} and convert to __iomem.

2012-04-07T09:47:16+00:00

Signed-off-by: Francois Romieu 
Acked-by: Grant Grundler

xircom_cb: fix device probe error path.

2012-04-07T09:47:15+00:00

- unbalanced pci_disable_device
- PCI ressources were not released
- mismatching pci_alloc_.../kfree pairs are replaced by DMA alloc helpers.

Signed-off-by: Francois Romieu 
Ack-by: Grant Grundler

uli526x: fix regions leak in driver probe error path.

2012-04-07T09:47:15+00:00

Signed-off-by: Francois Romieu 
Ack-by: Grant Grundler

tulip_core: stop using net_device.{base_addr, irq}.

2012-04-07T09:45:27+00:00

Signed-off-by: Francois Romieu 
Ack-by: Grant Grundler