linux-toradex.git/drivers/net/ethernet/intel, branch v3.18-rc5

ixgbe: phy: fix uninitialized status in ixgbe_setup_phy_link_tnx

2014-11-11T21:31:54+00:00

Status variable is never initialized, can carry an arbitrary value
on the stack and thus may let the function fail.

Fixes: e90dd2645664 ("ixgbe: Make return values more direct")
Signed-off-by: Daniel Borkmann 
Acked-by: Emil Tantilov 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

ixgbe: fix race when setting advertised speed

2014-10-30T12:12:07+00:00

Following commands:

modprobe ixgbe
ifconfig ethX up
ethtool -s ethX advertise 0x020

can lead to "setup link failed with code -14" error due to the setup_link
call racing with the SFP detection routine in the watchdog.

This patch resolves this issue by protecting the setup_link call with check
for __IXGBE_IN_SFP_INIT.

Reported-by: Scott Harrison 
Signed-off-by: Emil Tantilov 
Tested-by: Phil Schmitt 
Signed-off-by: Jeff Kirsher

ixgbe: need not repeat init skb with NULL

2014-10-30T12:04:39+00:00

Signed-off-by: Martin Zhang 
Tested-by: Phil Schmitt 
Signed-off-by: Jeff Kirsher

igb: don't reuse pages with pfmemalloc flag

2014-10-30T11:56:52+00:00

Incoming packet is dropped silently by sk_filter(), if the skb was
allocated from pfmemalloc reserves and the corresponding socket is
not marked with the SOCK_MEMALLOC flag.

Igb driver allocates pages for DMA with __skb_alloc_page(), which
calls alloc_pages_node() with the __GFP_MEMALLOC flag. So, in case
of OOM condition, igb can get pages with pfmemalloc flag set.

If an incoming packet hits the pfmemalloc page and is large enough
(small packets are copying into the memory, allocated with
netdev_alloc_skb_ip_align(), so they are not affected), it will be
dropped.

This behavior is ok under high memory pressure, but the problem is
that the igb driver reuses these mapped pages. So, packets are still
dropping even if all memory issues are gone and there is a plenty
of free memory.

In my case, some TCP sessions hang on a small percentage (< 0.1%)
of machines days after OOMs.

Fix this by avoiding reuse of such pages.

Signed-off-by: Roman Gushchin 
Tested-by: Aaron Brown "aaron.f.brown@intel.com"
Signed-off-by: Jeff Kirsher

e1000: unset IFF_UNICAST_FLT on WMware 82545EM

2014-10-30T11:47:39+00:00

VMWare's e1000 implementation does not seem to support unicast filtering.
This can be observed by configuring a macvlan interface on eth0 in a VM in
VMWare Fusion 5.0.5, and trying to use that interface instead of eth0.
Tested on 3.16.

Signed-off-by: Francesco Ruggeri 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher

i40e: _MASK vs _SHIFT typo in i40e_handle_mdd_event()

2014-10-25T20:50:56+00:00

We accidentally mask by the _SHIFT variable.  It means that "event" is
always zero.

Signed-off-by: Dan Carpenter 
Tested-by: Jim Young 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

ixgbe: check for vfs outside of sriov_num_vfs before dereference

2014-10-16T09:21:03+00:00

The check for vfinfo is not sufficient because it does not protect
against specifying vf that is outside of sriov_num_vfs range.
All of the ndo functions have a check for it except for
ixgbevf_ndo_set_spoofcheck().

The following patch is all we need to protect against this panic:

ip link set p96p1 vf 0 spoofchk off
BUG: unable to handle kernel NULL pointer dereference at 0000000000000052
IP: []
ixgbe_ndo_set_vf_spoofchk+0x51/0x150 [ixgbe]

Reported-by: Thierry Herbelot 
Signed-off-by: Emil Tantilov 
Acked-by: Thierry Herbelot 
Signed-off-by: Jeff Kirsher

fm10k: Add CONFIG_FM10K_VXLAN configuration option

2014-10-16T09:03:39+00:00

Compiling with CONFIG_FM10K=y and VXLAN=m resulting in linking error:

   drivers/built-in.o: In function `fm10k_open':
   (.text+0x1f9d7a): undefined reference to `vxlan_get_rx_port'
   make: *** [vmlinux] Error 1

The fix follows the same strategy as I40E.

Signed-off-by: Andy Zhou 
Acked-by: Alexander Duyck 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher

fm10k: Unlock mailbox on VLAN addition failures

2014-10-16T08:55:31+00:00

After grabbing the mailbox lock and detecting an error, the lock must be
released before the error code can be returned.

Signed-off-by: Matthew Vick 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher

fm10k: Check the host state when bringing the interface up

2014-10-16T08:37:33+00:00

Set the flag to fetch the host state before kicking off the service task
that reads the host state when bringing the interface back up.

Signed-off-by: Matthew Vick 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher