linux-toradex.git/drivers/net/ethernet/rdc, branch v3.9.4

ethernet: Remove unnecessary alloc/OOM messages, alloc cleanups

2013-02-04T18:22:33+00:00

alloc failures already get standardized OOM
messages and a dump_stack.

Convert kzalloc's with multiplies to kcalloc.
Convert kmalloc's with multiplies to kmalloc_array.
Fix a few whitespace defects.
Convert a constant 6 to ETH_ALEN.
Use parentheses around sizeof.
Convert vmalloc/memset to vzalloc.
Remove now unused size variables.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

net: phy: remove flags argument from phy_{attach, connect, connect_direct}

2013-01-14T20:11:50+00:00

The flags argument of the phy_{attach,connect,connect_direct} functions
is then used to assign a struct phy_device dev_flags with its value.
All callers but the tg3 driver pass the flag 0, which results in the
underlying PHY drivers in drivers/net/phy/ not being able to actually
use any of the flags they would set in dev_flags. This patch gets rid of
the flags argument, and passes phydev->dev_flags to the internal PHY
library call phy_attach_direct() such that drivers which actually modify
a phy device dev_flags get the value preserved for use by the underlying
phy driver.

Acked-by: Kosta Zertsekel 
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

remove init of dev->perm_addr in drivers

2013-01-09T02:00:48+00:00

perm_addr is initialized correctly in register_netdevice() so to init it in
drivers is no longer needed.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

ethtool: fix drvinfo strings set in drivers

2013-01-07T05:06:31+00:00

Use strlcpy where possible to ensure the string is \0 terminated.
Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN
and custom defines.
Use snprintf instead of sprint.
Remove unnecessary inits of ->fw_version
Remove unnecessary inits of drvinfo struct.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

drivers/net: fix up function prototypes after __dev* removals

2012-12-07T19:22:22+00:00

The __dev* removal patches for the network drivers ended up messing up
the function prototypes for a bunch of drivers.  This patch fixes all of
them back up to be properly aligned.

Bonus is that this almost removes 100 lines of code, always a nice
surprise.

Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: David S. Miller

r6040: remove __dev* attributes

2012-12-03T19:16:46+00:00

CONFIG_HOTPLUG is going away as an option.  As result the __dev*
markings will be going away.

Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
and __devexit.

Signed-off-by: Bill Pemberton 
Cc: Florian Fainelli 
Signed-off-by: Greg Kroah-Hartman

r6040: use module_pci_driver macro

2012-07-09T21:42:30+00:00

as the manual of module_pci_driver says that
it can be used when the init and exit functions of
the module does nothing but the pci_register_driver
and pci_unregister_driver.

use it for rdc's r6040 driver, as the init and exit
paths does as above, and also this reduces a little
amount of code.

Signed-off-by: Devendra Naga 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller

r6040: remove duplicate call to the pci_set_drvdata

2012-07-07T23:16:12+00:00

pci_set_drvdata is called twice at the remove path of driver,
call it once.

Signed-off-by: Devendra Naga 
Signed-off-by: David S. Miller

r6040: Do a Proper deinit at errorpath and also when driver unloads (calling r6040_remove_one)

2012-05-30T02:31:08+00:00

so if mdiobus_alloc fails, the errorpath doesnt do a netif_napi_del and also
doesn't set the priv data of the driver to NULL.

at the driver unload stage the driver doesn't remove the NAPI context, and
doesnt' set the priv data to NULL, and also doesn't call the pci_iounmap.

Signed-off-by: Devendra Naga 
Signed-off-by: David S. Miller

r6040: disable pci device if the subsequent calls (after pci_enable_device) fails

2012-05-30T02:31:08+00:00

the calls after the pci_enable_device may fail, and will error out with out
disabling it. disable the device at error paths.

Signed-off-by: Devendra Naga 
Signed-off-by: David S. Miller