linux-toradex.git/drivers/net/ethernet/synopsys, branch v4.5

dwc_eth_qos: do phy_start before resetting hardware

2016-03-02T19:57:15+00:00

This reverts the changed init order from commit 3647bc35bd42
("dwc_eth_qos: Reset hardware before PHY start") and makes another fix
for the race.

It turned out that the reset state machine of the dwceqos hardware
requires PHY clocks to be present in order to complete the reset
cycle.

To plug the race with the phy state machine we defer link speed
setting until the hardware init has finished.

Signed-off-by: Lars Persson 
Signed-off-by: David S. Miller

dwc_eth_qos: use DWCEQOS_MSG_DEFAULT

2016-03-02T19:57:15+00:00

Since debug is hardcoded to 3, the defaults in the DWCEQOS_MSG_DEFAULT
macro are never used, which does not seem to be the intended behaviour
here.  Set debug to -1 like other drivers so that DWCEQOS_MSG_DEFAULT is
actually used by default.

Signed-off-by: Rabin Vincent 
Signed-off-by: Lars Persson 
Signed-off-by: David S. Miller

dwc_eth_qos: use GFP_KERNEL in dma_alloc_coherent()

2016-03-02T19:57:15+00:00

Since we are in non-atomic context here we can pass GFP_KERNEL to
dma_alloc_coherent(). This enables use of the CMA.

Signed-off-by: Rabin Vincent 
Signed-off-by: Lars Persson 
Signed-off-by: David S. Miller

dwc_eth_qos: release descriptors outside netif_tx_lock

2016-03-02T19:57:14+00:00

To prepare for using the CMA, we can not be in atomic context when
de-allocating DMA buffers.

The tx lock was needed only to protect the hw reset against the xmit
handler. Now we briefly grab the tx lock while stopping the queue to
make sure no thread is inside or will enter the xmit handler.

Signed-off-by: Lars Persson 
Signed-off-by: David S. Miller

dwc_eth_qos: fix race condition in dwceqos_start_xmit

2016-03-02T19:57:14+00:00

The xmit handler and the tx_reclaim tasklet had a race on the tx_free
variable which could lead to a tx timeout if tx_free was updated after
the tx complete interrupt.

Signed-off-by: Rabin Vincent 
Signed-off-by: Lars Persson 
Signed-off-by: David S. Miller

dwc_eth_qos: Reset hardware before PHY start

2016-02-06T08:38:11+00:00

The hardware reset is currently done after phy_start() is called,
leading to a race where we can lose the link status if the phy state
machine calls dwceqos_adjust_link() before we reset the MAC registers.

Acked-by: Lars Persson 
Signed-off-by: Rabin Vincent 
Signed-off-by: David S. Miller

dwc_eth_qos: Fix dma address for multi-fragment skbs

2016-01-12T17:03:30+00:00

The offset inside the fragment was not used for the dma address and
silent data corruption resulted because TSO makes the checksum match.

Fixes: 077742dac2c7 ("dwc_eth_qos: Add support for Synopsys DWC Ethernet QoS")
Signed-off-by: Lars Persson 
Signed-off-by: David S. Miller

mdio: Move allocation of interrupts into core

2016-01-07T19:31:26+00:00

Have mdio_alloc() create the array of interrupt numbers, and
initialize it to POLLING. This is what most MDIO drivers want, so
allowing code to be removed from the drivers.

Signed-off-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

phy: Centralise print about attached phy

2016-01-07T19:31:25+00:00

Many Ethernet drivers contain the same netdev_info() print statement
about the attached phy. Move it into the phy device code. Additionally
add a varargs function which can be used to append additional
information.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put"

2015-11-07T18:17:32+00:00

The of_node_put() function tests whether its argument is NULL
and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: David S. Miller