linux-toradex.git/drivers/net/ethernet/via, branch v3.12.15

net,via-rhine: Fix tx_timeout handling

2014-02-06T19:22:20+00:00

[ Upstream commit a926592f5e4e900f3fa903298c4619a131e60963 ]

rhine_reset_task() misses to disable the tx scheduler upon reset,
this can lead to a crash if work is still scheduled while we're resetting
the tx queue.

Fixes:
[   93.591707] BUG: unable to handle kernel NULL pointer dereference at 0000004c
[   93.595514] IP: [] rhine_napipoll+0x491/0x6

Signed-off-by: Richard Weinberger 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

via-velocity: fix netif_receive_skb use in irq disabled section.

2013-12-08T15:29:14+00:00

[ Upstream commit bc9627e7e918a85e906c1a3f6d01d9b8ef911a96 ]

2fdac010bdcf10a30711b6924612dfc40daf19b8 ("via-velocity.c: update napi
implementation") overlooked an irq disabling spinlock when the Rx part
of the NAPI poll handler was converted from netif_rx to netif_receive_skb.

NAPI Rx processing can be taken out of the locked section with a pair of
napi_{disable / enable} since it only races with the MTU change function.

An heavier rework of the NAPI locking would be able to perform NAPI Tx
before Rx where I simply removed one of velocity_tx_srv calls.

References: https://bugzilla.redhat.com/show_bug.cgi?id=1022733
Fixes: 2fdac010bdcf (via-velocity.c: update napi implementation)
Signed-off-by: Francois Romieu 
Tested-by: Alex A. Schmidt 
Cc: Jamie Heilman 
Cc: Michele Baldessari 
Cc: Julia Lawall 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

via-rhine: fix VLAN priority field (PCP, IEEE 802.1p)

2013-09-26T20:09:00+00:00

Outgoing packets sent by via-rhine have their VLAN PCP field off by one
(when hardware acceleration is enabled). The TX descriptor expects only VID
and PCP (without a CFI/DEI bit).

Peter Boström noticed and reported the bug.

Signed-off-by: Roger Luethi 
Cc: Peter Boström 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2013-08-16T22:37:26+00:00

drivers/net/ethernet/via/via-velocity.c: update napi implementation

2013-08-15T08:38:34+00:00

Drivers supporting NAPI should use a NAPI-specific function for receiving
packets.  Hence netif_rx is changed to netif_receive_skb.

Furthermore netif_napi_del should be used in the probe and remove function
to clean up the NAPI resource information.

Thanks to Francois Romieu, David Shwatrz and Rami Rosen for their help on
this patch.

Signed-off-by: Julia Lawall 
Signed-off-by: David S. Miller

net: via-rhine: Fix incorrect placement of __initdata

2013-08-09T20:24:26+00:00

__initdata should be placed between the variable name and equal
sign for the variable to be placed in the intended section.

Signed-off-by: Sachin Kamat 
Signed-off-by: David S. Miller

net/velocity: add poll controller function for velocity nic

2013-07-20T00:34:41+00:00

Add poll controller function for velocity nic.

Signed-off-by: Amit Uttamchandani 
Signed-off-by: David S. Miller

via-rhine: fix dma mapping errors

2013-07-12T23:28:02+00:00

this bug:
https://bugzilla.redhat.com/show_bug.cgi?id=951695

Reported a dma debug backtrace:

WARNING: at lib/dma-debug.c:937 check_unmap+0x47d/0x930()
Hardware name: To Be Filled By O.E.M.
via-rhine 0000:00:12.0: DMA-API: device driver failed to check map error[device
address=0x0000000075a837b2] [size=90 bytes] [mapped as single]
Modules linked in: ip6_tables gspca_spca561 gspca_main videodev media
snd_hda_codec_realtek snd_hda_intel i2c_viapro snd_hda_codec snd_hwdep snd_seq
ppdev mperf via_rhine coretemp snd_pcm mii microcode snd_page_alloc snd_timer
snd_mpu401 snd_mpu401_uart snd_rawmidi snd_seq_device snd soundcore parport_pc
parport shpchp ata_generic pata_acpi radeon i2c_algo_bit drm_kms_helper ttm drm
pata_via sata_via i2c_core uinput
Pid: 295, comm: systemd-journal Not tainted 3.9.0-0.rc6.git2.1.fc20.x86_64 #1
Call Trace:
   [] warn_slowpath_common+0x70/0xa0
 [] warn_slowpath_fmt+0x4c/0x50
 [] check_unmap+0x47d/0x930
 [] ? local_clock+0x5f/0x70
 [] debug_dma_unmap_page+0x5f/0x70
 [] ? rhine_ack_events.isra.14+0x3c/0x50 [via_rhine]
 [] rhine_napipoll+0x1d8/0xd80 [via_rhine]
 [] ? net_rx_action+0xa1/0x380
 [] net_rx_action+0x172/0x380
 [] __do_softirq+0xff/0x400
 [] irq_exit+0xb5/0xc0
 [] do_IRQ+0x56/0xc0
 [] common_interrupt+0x72/0x72
   [] ? __slab_alloc+0x4c2/0x526
 [] ? mmap_region+0x2b0/0x5a0
 [] ? __lock_is_held+0x57/0x80
 [] ? mmap_region+0x2b0/0x5a0
 [] kmem_cache_alloc+0x2df/0x360
 [] mmap_region+0x2b0/0x5a0
 [] do_mmap_pgoff+0x316/0x3d0
 [] vm_mmap_pgoff+0x90/0xc0
 [] sys_mmap_pgoff+0x4c/0x190
 [] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [] sys_mmap+0x22/0x30
 [] system_call_fastpath+0x16/0x1b

Usual problem with the usual fix, add the appropriate calls to dma_mapping_error
where appropriate

Untested, as I don't have hardware, but its pretty straightforward

Signed-off-by: Neil Horman 
CC: David S. Miller 
CC: Roger Luethi 
Signed-off-by: David S. Miller

net/trivial: replace numeric with standard PM state macros

2013-06-29T05:11:48+00:00

Use standard PM state macros PCI_Dx instead of numeric 0/1/2..

Signed-off-by: Yijing Wang 
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: David S. Miller

net: Move MII out from under NET_CORE and hide it

2013-06-20T05:22:56+00:00

All drivers that select MII also need to select NET_CORE because MII
depends on it.  This is a bit ridiculous because NET_CORE is just a
menu option that doesn't enable any code by itself.

There is also no need for it to be a visible option, since its users
all select it.

Signed-off-by: Ben Hutchings 
Acked-by: Jeff Kirsher 
Signed-off-by: David S. Miller