linux-toradex.git/drivers/net/ethernet, branch v3.2.51

ixgbe: Fix Tx Hang issue with lldpad on 82598EB

2013-09-10T00:57:16+00:00

commit 1eb9ac14c34a948bf1538bfb9034e8ab29099a64 upstream.

This patch fixes an issue with the 82598EB device, where lldpad is causing Tx
Hangs on the card as soon as it attempts to configure DCB for the device. The
adapter will continually Tx hang and reset in a loop.

Signed-off-by: Jacob Keller 
Tested-by: Phil Schmitt 
Tested-by: Jack Morgan 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

atl1e: unmap partially mapped skb on dma error and free skb

2013-08-02T20:14:50+00:00

[ Upstream commit 584ec4355355ffac43571b02a314d43eb2f7fcbf ]

Ben Hutchings pointed out that my recent update to atl1e
in commit 352900b583b2852152a1e05ea0e8b579292e731e
("atl1e: fix dma mapping warnings") was missing a bit of code.

Specifically it reset the hardware tx ring to its origional state when
we hit a dma error, but didn't unmap any exiting mappings from the
operation.  This patch fixes that up.  It also remembers to free the
skb in the event that an error occurs, so we don't leak.  Untested, as
I don't have hardware.  I think its pretty straightforward, but please
review closely.

Signed-off-by: Neil Horman 
CC: Ben Hutchings 
CC: Jay Cliburn 
CC: Chris Snook 
CC: "David S. Miller" 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

atl1e: fix dma mapping warnings

2013-08-02T20:14:50+00:00

[ Upstream commit 352900b583b2852152a1e05ea0e8b579292e731e ]

Recently had this backtrace reported:
WARNING: at lib/dma-debug.c:937 check_unmap+0x47d/0x930()
Hardware name: System Product Name
ATL1E 0000:02:00.0: DMA-API: device driver failed to check map error[device
address=0x00000000cbfd1000] [size=90 bytes] [mapped as single]
Modules linked in: xt_conntrack nf_conntrack ebtable_filter ebtables
ip6table_filter ip6_tables snd_hda_codec_hdmi snd_hda_codec_realtek iTCO_wdt
iTCO_vendor_support snd_hda_intel acpi_cpufreq mperf coretemp btrfs zlib_deflate
snd_hda_codec snd_hwdep microcode raid6_pq libcrc32c snd_seq usblp serio_raw xor
snd_seq_device joydev snd_pcm snd_page_alloc snd_timer snd lpc_ich i2c_i801
soundcore mfd_core atl1e asus_atk0110 ata_generic pata_acpi radeon i2c_algo_bit
drm_kms_helper ttm drm i2c_core pata_marvell uinput
Pid: 314, comm: systemd-journal Not tainted 3.9.0-0.rc6.git2.3.fc19.x86_64 #1
Call Trace:
   [] warn_slowpath_common+0x66/0x80
 [] warn_slowpath_fmt+0x4c/0x50
 [] check_unmap+0x47d/0x930
 [] ? sched_clock_cpu+0xa8/0x100
 [] debug_dma_unmap_page+0x5f/0x70
 [] ? unmap_single+0x20/0x30
 [] atl1e_intr+0x3a1/0x5b0 [atl1e]
 [] ? trace_hardirqs_off+0xd/0x10
 [] handle_irq_event_percpu+0x56/0x390
 [] handle_irq_event+0x3d/0x60
 [] handle_fasteoi_irq+0x5a/0x100
 [] handle_irq+0xbf/0x150
 [] ? file_sb_list_del+0x3f/0x50
 [] ? irq_enter+0x50/0xa0
 [] do_IRQ+0x4d/0xc0
 [] ? file_sb_list_del+0x3f/0x50
 [] common_interrupt+0x72/0x72
   [] ? lock_release+0xc2/0x310
 [] lg_local_unlock_cpu+0x24/0x50
 [] file_sb_list_del+0x3f/0x50
 [] fput+0x2d/0xc0
 [] filp_close+0x61/0x90
 [] __close_fd+0x8d/0x150
 [] sys_close+0x20/0x50
 [] system_call_fastpath+0x16/0x1b

The usual straighforward failure to check for dma_mapping_error after a map
operation is completed.

This patch should fix it, the reporter wandered off after filing this bz:
https://bugzilla.redhat.com/show_bug.cgi?id=954170

and I don't have hardware to test, but the fix is pretty straightforward, so I
figured I'd post it for review.

Signed-off-by: Neil Horman 
CC: Jay Cliburn 
CC: Chris Snook 
CC: "David S. Miller" 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

sunvnet: vnet_port_remove must call unregister_netdev

2013-08-02T20:14:48+00:00

[ Upstream commit aabb9875d02559ab9b928cd6f259a5cc4c21a589 ]

The missing call to unregister_netdev() leaves the interface active
after the driver is unloaded by rmmod.

Signed-off-by: Dave Kleikamp 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

sh_eth: fix unhandled RFE interrupt

2013-08-02T20:14:46+00:00

[ Upstream commit ca8c35852138ee0585eaffe6b9f10a5261ea7771 ]

EESR.RFE (receive FIFO overflow) interrupt is enabled by the driver on all SoCs
and sh_eth_error() handles it but it's not present in any initializer/assignment
of the 'eesr_err_check' field of 'struct sh_eth_cpu_data'. This leads to that
interrupt not being handled and cleared, and finally to disabling IRQ and the
driver being non-functional.

Modify DEFAULT_EESR_ERR_CHECK macro and all explicit initializers of the above
mentioned field to contain the EESR.RFE bit. Remove useless backslashes from the
initializers, while at it.

Signed-off-by: Sergei Shtylyov 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

r8169: fix offloaded tx checksum for small packets.

2013-07-27T04:34:04+00:00

The workaround introduced by commit e5195c1f31f3 'r8169: fix 8168evl
frame padding.' upstream was incorrect and was entirely replaced in
commit b423e9ae49d7 'r8169: fix offloaded tx checksum for small
packets.'

On the 3.2.y branch, the first commit has effectively been applied
twice: the first time by itself, and the second time in commit
3cf40360f431 which squashed the two upstream commits together.  That
left us with both the incorrect and the correct workaround in place.
Remove the incorrect one.

Signed-off-by: Ben Hutchings 
Cc: Francois Romieu

r8169: fix 8168evl frame padding.

2013-06-29T03:06:37+00:00

[ Upstream commits e5195c1f31f399289347e043d6abf3ffa80f0005 and
  b423e9ae49d78ea3f53b131c8d5a6087aed16fd6 ]

Signed-off-by: Stefan Bader 
Acked-by: Francois Romieu 
Cc: hayeswang 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

gianfar: add missing iounmap() on error in gianfar_ptp_probe()

2013-06-29T03:06:36+00:00

[ Upstream commit e5f5e380e0f3bb11f04ca5bc66a551e58e0ad26e ]

Add the missing iounmap() before return from gianfar_ptp_probe()
in the error handling case.

Signed-off-by: Wei Yongjun 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

tg3: Wait for boot code to finish after power on

2013-06-19T01:17:02+00:00

commit df465abfe06f7dc4f33f4a96d17f096e9e8ac917 upstream.

Some systems that don't need wake-on-lan may choose to power down the
chip on system standby. Upon resume, the power on causes the boot code
to startup and initialize the hardware. On one new platform, this is
causing the device to go into a bad state due to a race between the
driver and boot code, once every several hundred resumes. The same race
exists on open since we come up from a power on.

This patch adds a wait for boot code signature at the beginning of
tg3_init_hw() which is common to both cases. If there has not been a
power-off or the boot code has already completed, the signature will be
present and poll_fw() returns immediately. Also return immediately if
the device does not have firmware.

Signed-off-by: Nithin Nayak Sujir 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings

tg3: Add read dma workaround for 5720

2013-06-19T01:16:41+00:00

commit 9bc297ea0622bb2a6b3abfa2fa84f0a3b86ef8c8 upstream.

Commit 091f0ea30074bc43f9250961b3247af713024bc6 "tg3: Add New 5719 Read
DMA workaround" added a workaround for TX DMA stall on the 5719. This
workaround needs to be applied to the 5720 as well.

Reported-by: Roland Dreier 
Tested-by: Roland Dreier 
Signed-off-by: Nithin Nayak Sujir 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller 
[bwh: Backported to 3.2: use GET_ASIC_REV() instead of tg3_asic_rev()]
Signed-off-by: Ben Hutchings