linux-toradex.git/drivers/net/ethernet, branch v5.14

net: hns3: fix get wrong pfc_en when query PFC configuration

2021-08-26T14:24:17+00:00

Currently, when query PFC configuration by dcbtool, driver will return
PFC enable status based on TC. As all priorities are mapped to TC0 by
default, if TC0 is enabled, then all priorities mapped to TC0 will be
shown as enabled status when query PFC setting, even though some
priorities have never been set.

for example:
$ dcb pfc show dev eth0
pfc-cap 4 macsec-bypass off delay 0
prio-pfc 0:off 1:off 2:off 3:off 4:off 5:off 6:off 7:off
$ dcb pfc set dev eth0 prio-pfc 0:on 1:on 2:on 3:on
$ dcb pfc show dev eth0
pfc-cap 4 macsec-bypass off delay 0
prio-pfc 0:on 1:on 2:on 3:on 4:on 5:on 6:on 7:on

To fix this problem, just returns user's PFC config parameter saved in
driver.

Fixes: cacde272dd00 ("net: hns3: Add hclge_dcb module for the support of DCB feature")
Signed-off-by: Guangbin Huang 
Signed-off-by: Jakub Kicinski

net: hns3: fix GRO configuration error after reset

2021-08-26T14:24:17+00:00

The GRO configuration is enabled by default after reset. This
is incorrect and should be restored to the user-configured value.
So this restoration is added during reset initialization.

Signed-off-by: Yufeng Mo 
Signed-off-by: Guangbin Huang 
Signed-off-by: Jakub Kicinski

net: hns3: change the method of getting cmd index in debugfs

2021-08-26T14:24:17+00:00

Currently, the cmd index is obtained in debugfs by comparing file names.
However, this method may cause errors when processing more complex file
names. So, change this method by saving cmd in private data and comparing
it when getting cmd index in debugfs for optimization.

Fixes: 5e69ea7ee2a6 ("net: hns3: refactor the debugfs process")
Signed-off-by: Yufeng Mo 
Signed-off-by: Guangbin Huang 
Signed-off-by: Jakub Kicinski

net: hns3: fix duplicate node in VLAN list

2021-08-26T14:24:17+00:00

VLAN list should not be added duplicate VLAN node, otherwise it would
cause "add failed" when restore VLAN from VLAN list, so this patch adds
VLAN ID check before adding node into VLAN list.

Fixes: c6075b193462 ("net: hns3: Record VF vlan tables")
Signed-off-by: Guojia Liao 
Signed-off-by: Guangbin Huang 
Signed-off-by: Jakub Kicinski

net: hns3: fix speed unknown issue in bond 4

2021-08-26T14:24:16+00:00

In bond 4, when the link goes down and up repeatedly, the bond may get an
unknown speed, and then this port can not work.

The driver notify netif_carrier_on() before update the link state, when the
bond receive carrier on, will query the speed of the port, if the query
operation happens before updating the link state, will get an unknown
speed. So need to notify netif_carrier_on() after update the link state.

Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support")
Fixes: e2cb1dec9779 ("net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support")
Signed-off-by: Yonglong Liu 
Signed-off-by: Guangbin Huang 
Signed-off-by: Jakub Kicinski

net: hns3: add waiting time before cmdq memory is released

2021-08-26T14:24:16+00:00

After the cmdq registers are cleared, the firmware may take time to
clear out possible left over commands in the cmdq. Driver must release
cmdq memory only after firmware has completed processing of left over
commands.

Fixes: 232d0d55fca6 ("net: hns3: uninitialize command queue while unloading PF driver")
Signed-off-by: Yufeng Mo 
Signed-off-by: Guangbin Huang 
Signed-off-by: Jakub Kicinski

net: hns3: clear hardware resource when loading driver

2021-08-26T14:24:16+00:00

If a PF is bonded to a virtual machine and the virtual machine exits
unexpectedly, some hardware resource cannot be cleared. In this case,
loading driver may cause exceptions. Therefore, the hardware resource
needs to be cleared when the driver is loaded.

Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support")
Signed-off-by: Yufeng Mo 
Signed-off-by: Salil Mehta 
Signed-off-by: Guangbin Huang 
Signed-off-by: Jakub Kicinski

cxgb4: dont touch blocked freelist bitmap after free

2021-08-26T09:23:24+00:00

When adapter init fails, the blocked freelist bitmap is already freed
up and should not be touched. So, move the bitmap zeroing closer to
where it was successfully allocated. Also handle adapter init failure
unwind path immediately and avoid setting up RDMA memory windows.

Fixes: 5b377d114f2b ("cxgb4: Add debugfs facility to inject FL starvation")
Signed-off-by: Rahul Lakkireddy 
Signed-off-by: David S. Miller

qede: Fix memset corruption

2021-08-25T10:07:55+00:00

Thanks to Kees Cook who detected the problem of memset that starting
from not the first member, but sized for the whole struct.
The better change will be to remove the redundant memset and to clear
only the msix_cnt member.

Signed-off-by: Prabhakar Kushwaha 
Signed-off-by: Ariel Elior 
Signed-off-by: Shai Malin 
Reported-by: Kees Cook 
Reviewed-by: Kees Cook 
Signed-off-by: David S. Miller

net: stmmac: fix kernel panic due to NULL pointer dereference of buf->xdp

2021-08-25T09:59:39+00:00

Ensure a valid XSK buffer before proceed to free the xdp buffer.

The following kernel panic is observed without this patch:

RIP: 0010:xp_free+0x5/0x40
Call Trace:
stmmac_napi_poll_rxtx+0x332/0xb30 [stmmac]
? stmmac_tx_timer+0x3c/0xb0 [stmmac]
net_rx_action+0x13d/0x3d0
__do_softirq+0xfc/0x2fb
? smpboot_register_percpu_thread+0xe0/0xe0
run_ksoftirqd+0x32/0x70
smpboot_thread_fn+0x1d8/0x2c0
kthread+0x169/0x1a0
? kthread_park+0x90/0x90
ret_from_fork+0x1f/0x30
---[ end trace 0000000000000002 ]---

Fixes: bba2556efad6 ("net: stmmac: Enable RX via AF_XDP zero-copy")
Cc:  # 5.13.x
Suggested-by: Ong Boon Leong 
Signed-off-by: Song Yoong Siang 
Signed-off-by: David S. Miller