linux-toradex.git/drivers/net/fddi, branch v5.9-rc5

treewide: Use fallthrough pseudo-keyword

2020-08-23T22:36:59+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva

net: fddi: skfp: cfm: Remove seemingly unused variable 'ID_sccs'

2020-08-15T03:42:25+00:00

This variable is present in many source files and has not been used
anywhere (at least internally) since it was introduced.

Fixes the following W=1 kernel build warning(s):

 drivers/net/fddi/skfp/cfm.c: In function ‘cfm’:
 drivers/net/fddi/skfp/cfm.c:211:6: warning: variable ‘oldstate’ set but not used [-Wunused-but-set-variable]
 drivers/net/fddi/skfp/cfm.c:40:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]

Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: Lee Jones 
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones 
Signed-off-by: David S. Miller

net: fddi: skfp: cfm: Remove set but unused variable 'oldstate'

2020-08-15T03:42:25+00:00

While we're at it, remove some code which has never been invoked.

Keep the comment though, as it seems potentially half useful.

Fixes the following W=1 kernel build warning(s):

 drivers/net/fddi/skfp/cfm.c: In function ‘cfm’:
 drivers/net/fddi/skfp/cfm.c:211:6: warning: variable ‘oldstate’ set but not used [-Wunused-but-set-variable]

Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones 
Signed-off-by: David S. Miller

net: fddi: skfp: smt: Remove seemingly unused variable 'ID_sccs'

2020-08-15T03:42:25+00:00

This variable is present in many source files and has not been used
anywhere (at least internally) since it was introduced.

Fixes the following W=1 kernel build warning(s):

 drivers/net/fddi/skfp/smt.c:24:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]

Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: Tetsuo Handa 
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones 
Signed-off-by: David S. Miller

net: fddi: skfp: smt: Place definition of 'smt_pdef' under same stipulations as its use

2020-08-15T03:42:25+00:00

The variable 'smt_pdef' is only used if LITTLE_ENDIAN is set, so only
define it if this is the case.

Fixes the following W=1 kernel build warning(s):

 drivers/net/fddi/skfp/smt.c:1572:3: warning: ‘smt_pdef’ defined but not used [-Wunused-const-variable=]

Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: Tetsuo Handa 
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones 
Signed-off-by: David S. Miller

net: fddi: skfp: fplustm: Remove seemingly unused variable 'ID_sccs'

2020-08-15T03:42:25+00:00

This variable is present in many source files and has not been used
anywhere (at least internally) since it was introduced.

Fixes the following W=1 kernel build warning(s):

 drivers/net/fddi/skfp/fplustm.c:25:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]

Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: Maxime Coquelin 
Cc: Alexandre Torgue 
Cc: netdev@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Signed-off-by: Lee Jones 
Signed-off-by: David S. Miller

net: fddi: skfp: hwmtm: Remove seemingly unused variable 'ID_sccs'

2020-08-15T03:42:25+00:00

This variable is present in many source files and has not been used
anywhere (at least internally) since it was introduced.

Fixes the following W=1 kernel build warning(s):

 drivers/net/fddi/skfp/hwmtm.c:14:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]

Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones 
Signed-off-by: David S. Miller

net: fddi: skfp: Remove addr_to_string().

2020-07-13T18:49:51+00:00

kbuild test robot found that addr_to_string() is available only when
DEBUG is defined. And I found that what that function is doing is
what %pM will do. Thus, replace %s with %pM and remove thread-unsafe
addr_to_string() function.

Reported-by: kbuild test robot 
Signed-off-by: Tetsuo Handa 
Signed-off-by: David S. Miller

docs: networking: move FDDI drivers to the hw driver section

2020-06-26T23:08:45+00:00

Move docs for defza and skfp under device_drivers/fddi.

Signed-off-by: Jakub Kicinski 
Signed-off-by: David S. Miller

treewide: replace '---help---' in Kconfig files with 'help'

2020-06-13T16:57:21+00:00

Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over
'---help---'"), the number of '---help---' has been gradually
decreasing, but there are still more than 2400 instances.

This commit finishes the conversion. While I touched the lines,
I also fixed the indentation.

There are a variety of indentation styles found.

  a) 4 spaces + '---help---'
  b) 7 spaces + '---help---'
  c) 8 spaces + '---help---'
  d) 1 space + 1 tab + '---help---'
  e) 1 tab + '---help---'    (correct indentation)
  f) 1 tab + 1 space + '---help---'
  g) 1 tab + 2 spaces + '---help---'

In order to convert all of them to 1 tab + 'help', I ran the
following commend:

  $ find . -name 'Kconfig*' | xargs sed -i 's/^[[:space:]]*---help---/\thelp/'

Signed-off-by: Masahiro Yamada