linux-toradex.git/drivers/net/hyperv, branch v4.16

hv_netvsc: enable multicast if necessary

2018-03-29T15:45:06+00:00

My recent change to netvsc drive in how receive flags are handled
broke multicast.  The Hyper-v/Azure virtual interface there is not a
multicast filter list, filtering is only all or none. The driver must
enable all multicast if any multicast address is present.

Fixes: 009f766ca238 ("hv_netvsc: filter multicast/broadcast")
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: common detach logic

2018-03-22T16:45:09+00:00

Make common function for detaching internals of device
during changes to MTU and RSS. Make sure no more packets
are transmitted and all packets have been received before
doing device teardown.

Change the wait logic to be common and use usleep_range().

Changes transmit enabling logic so that transmit queues are disabled
during the period when lower device is being changed. And enabled
only after sub channels are setup. This avoids issue where it could
be that a packet was being sent while subchannel was not initialized.

Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: change GPAD teardown order on older versions

2018-03-22T16:45:09+00:00

On older versions of Windows, the host ignores messages after
vmbus channel is closed.

Workaround this by doing what Windows does and send the teardown
before close on older versions of NVSP protocol.

Reported-by: Mohammed Gamal 
Fixes: 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split")
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: use RCU to fix concurrent rx and queue changes

2018-03-22T16:45:09+00:00

The receive processing may continue to happen while the
internal network device state is in RCU grace period.
The internal RNDIS structure is associated with the
internal netvsc_device structure; both have the same
RCU lifetime.

Defer freeing all associated parts until after grace
period.

Fixes: 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split")
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: disable NAPI before channel close

2018-03-22T16:45:09+00:00

This makes sure that no CPU is still process packets when
the channel is closed.

Fixes: 76bb5db5c749 ("netvsc: fix use after free on module removal")
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: fix locking during VF setup

2018-03-08T17:48:57+00:00

The dev_uc/mc_sync calls need to have the device address list
locked. This was spotted by running with lockdep enabled.

Fixes: bee9d41b37ea ("hv_netvsc: propagate rx filters to VF")
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: fix locking for rx_mode

2018-03-08T17:48:56+00:00

The rx_mode operation handler is different than other callbacks
in that is not always called with rtnl held. Therefore use
RCU to ensure that references are valid.

Fixes: bee9d41b37ea ("hv_netvsc: propagate rx filters to VF")
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: avoid repeated updates of packet filter

2018-03-08T17:48:56+00:00

The netvsc driver can get repeated calls to netvsc_rx_mode during
network setup; each of these calls ends up scheduling the lower
layers to update tha packet filter. This update requires an
request/response to the host. So avoid doing this if we already
know that the correct packet filter value is set.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: fix filter flags

2018-03-08T17:48:56+00:00

The recent change to not always enable all multicast and broadcast
was broken; meant to set filter, not change flags.

Fixes: 009f766ca238 ("hv_netvsc: filter multicast/broadcast")
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: propagate rx filters to VF

2018-03-05T03:18:21+00:00

The netvsc device should propagate filters to the SR-IOV VF
device (if present). The flags also need to be propagated to the
VF device as well. This only really matters on local Hyper-V
since Azure does not support multiple addresses.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller