linux-toradex.git/drivers/net/ibmveth.c, branch colibri_vf

ibmveth: Checksum offload is always disabled

2011-10-03T18:40:32+00:00

commit 91aae1e5c407d4fc79f6983e6c6ba04756c004cb upstream.

Commit b9367bf3ee6d (net: ibmveth: convert to hw_features) reversed
a check in ibmveth_set_csum_offload that results in checksum offload
never being enabled.

Signed-off-by: Anton Blanchard 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ibmveth: Fix issue with DMA mapping failure

2011-10-03T18:40:32+00:00

commit b93da27f5234198433345e40b39ff59797bc6f6e upstream.

descs[].fields.address is 32bit which truncates any dma mapping
errors so dma_mapping_error() fails to catch it.

Use a dma_addr_t to do the comparison. With this patch I was able
to transfer many gigabytes of data with IOMMU fault injection set
at 10% probability.

Signed-off-by: Anton Blanchard 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ibmveth: Fix DMA unmap error

2011-10-03T18:40:32+00:00

commit 33a48ab105a75d37021e422a0a3283241099b142 upstream.

Commit 6e8ab30ec677 (ibmveth: Add scatter-gather support) introduced a
DMA mapping API inconsistency resulting in dma_unmap_page getting
called on memory mapped via dma_map_single. This was seen when
CONFIG_DMA_API_DEBUG was enabled. Fix up this API usage inconsistency.

Signed-off-by: Brian King 
Acked-by: Anton Blanchard 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ibmveth: Fix leak when recycling skb and hypervisor returns error

2011-10-03T18:39:55+00:00

commit c6f59d13e24187ff95427a9f4a5a7e14fb8faf5a upstream.

If h_add_logical_lan_buffer returns an error we need to free
the skb.

Signed-off-by: Anton Blanchard 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ethtool: cosmetic: Use ethtool ethtool_cmd_speed API

2011-04-29T21:03:01+00:00

This updates the network drivers so that they don't access the
ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
instead.

For most of the drivers, these changes are purely cosmetic and don't
fix any problem, such as for those 1GbE/10GbE drivers that indirectly
call their own ethtool get_settings()/mii_ethtool_gset(). The changes
are meant to enforce code consistency and provide robustness with
future larger throughputs, at the expense of a few CPU cycles for each
ethtool operation.

All drivers compiled with make allyesconfig ion x86_64 have been
updated.

Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
Signed-off-by: David Decotigny 
Signed-off-by: David S. Miller

net: ibmveth: force reconfiguring checksum settings on startup

2011-04-28T20:45:41+00:00

Commit b9367bf3ee6d ("net: ibmveth: convert to hw_features") accidentally
removed call to ibmveth_set_csum_offload() in ibmveth_probe(). Put the
call back where it was, but with additional error checking provided
by ibmveth_set_features().

Signed-off-by: Michał Mirosław 
Reported-by: Stephen Rothwell 
[sfr: dev -> netdev]
Signed-off-by: Stephen Rothwell 
Signed-off-by: David S. Miller

net: ibmveth: convert to hw_features

2011-04-20T08:30:43+00:00

A minimal conversion.

ibmveth_set_csum_offload() can be folded into ibmveth_set_features()
and adapter->rx_csum removed - left for later cleanup.

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

netdev: Use default implementation of ethtool_ops::get_link where possible

2010-12-10T23:55:24+00:00

Various drivers are using implementations of ethtool_ops::get_link
that are equivalent to the default ethtool_op_get_link().  Change
them to use that instead.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

ibmveth: Free irq on error path

2010-10-21T08:26:46+00:00

Free irq on error path.

Signed-off-by: Denis Kirjanov 
Signed-off-by: David S. Miller

ibmveth: Cleanup error handling inside ibmveth_open

2010-10-21T08:26:46+00:00

Remove duplicated code in one place.

Signed-off-by: Denis Kirjanov 
Signed-off-by: David S. Miller