linux-toradex.git/drivers/net/ieee802154, branch v3.14.25

at86rf230: fix lockdep splats

2014-03-13T19:44:24+00:00

This patch fix a lockdep in the at86rf230 driver, otherwise we get:

[   30.206517] =================================
[   30.211078] [ INFO: inconsistent lock state ]
[   30.215647] 3.14.0-20140108-1-00994-g32e9426 #163 Not tainted
[   30.221660] ---------------------------------
[   30.226222] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
[   30.232514] systemd-udevd/157 [HC1[1]:SC0[0]:HE0:SE1] takes:
[   30.238439]  (&(&lp->lock)->rlock){?.+...}, at: [] at86rf230_isr+0x18/0x44
[   30.246621] {HARDIRQ-ON-W} state was registered at:
[   30.251728]   [] __lock_acquire+0x7a4/0x18d8
[   30.257135]   [] lock_acquire+0x68/0x7c
[   30.262071]   [] _raw_spin_lock+0x28/0x38
[   30.267203]   [] at86rf230_xmit+0x1c/0x144
[   30.272412]   [] mac802154_xmit_worker+0x88/0x148
[   30.278271]   [] process_one_work+0x274/0x404
[   30.283761]   [] worker_thread+0x228/0x374
[   30.288971]   [] kthread+0xd0/0xe4
[   30.293455]   [] ret_from_fork+0x14/0x2c
[   30.298493] irq event stamp: 8948
[   30.301963] hardirqs last  enabled at (8947): [] __kmalloc+0xb4/0x110
[   30.309636] hardirqs last disabled at (8948): [] __irq_svc+0x34/0x5c
[   30.317215] softirqs last  enabled at (8452): [] __do_softirq+0x1dc/0x264
[   30.325243] softirqs last disabled at (8439): [] irq_exit+0x80/0xf4

We use the lp->lock inside the isr of at86rf230, that's why we need the
irqsave spinlock calls.

Signed-off-by: Alexander Aring 
Signed-off-by: David S. Miller

net: ieee802154: remove unnecessary spi_set_drvdata()

2013-12-11T03:31:32+00:00

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han 
Signed-off-by: David S. Miller

tree-wide: use reinit_completion instead of INIT_COMPLETION

2013-11-15T00:32:21+00:00

Use this new function to make code more comprehensible, since we are
reinitialzing the completion, not initializing.

[akpm@linux-foundation.org: linux-next resyncs]
Signed-off-by: Wolfram Sang 
Acked-by: Linus Walleij  (personally at LCE13)
Cc: Ingo Molnar 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mrf24j40: Use level-triggered interrupts

2013-10-08T19:32:14+00:00

The mrf24j40 generates level interrupts. There are rare cases where it
appears that the interrupt line never gets de-asserted between interrupts,
causing interrupts to be lost, and causing a hung device from the driver's
perspective.  Switching the driver to interpret these interrupts as
level-triggered fixes this issue.

Signed-off-by: Alan Ott 
Signed-off-by: David S. Miller

mrf24j40: Use threaded IRQ handler

2013-10-08T19:32:13+00:00

Eliminate all the workqueue and interrupt enable/disable.

Signed-off-by: Alan Ott 
Signed-off-by: David S. Miller

mrf24j40: Move INIT_COMPLETION() to before packet transmission

2013-10-08T19:32:13+00:00

This avoids a race condition where complete(tx_complete) could be called
before tx_complete is initialized.

Signed-off-by: Alan Ott 
Signed-off-by: David S. Miller

drivers/net/ieee802154: don't use devm_pinctrl_get_select_default() in probe

2013-07-12T00:18:27+00:00

Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.

Acked-by: Linus Walleij  (personally at LCE13)
Signed-off-by: Wolfram Sang 
Signed-off-by: David S. Miller

at86rf230: change irq handling to prevent lockups with edge type irq

2013-04-16T20:34:08+00:00

Implemented separate irq handling for edge and level type interrupt
configuration. For edge type interrupts calls to disable_irq_nosync()
and enable_irq() are removed. The at86rf230 resets the irq line only
after the irq status register is read. Disabling the irq can lock the
driver in situations where a irq is set by the radio while the driver
is still reading the frame buffer.

With irq_type configuration set to 0 the original behavior is
preserverd.

Additional the irq filter register is set to filter out all unused
interrupts and the irq status register is read in the probe
function to clear the irq line.

Signed-off-by: Sascha Herrmann 

Conflicts:
	drivers/net/ieee802154/at86rf230.c
Signed-off-by: David S. Miller

at86rf230: add irq type configuration option

2013-04-16T20:34:07+00:00

Add option to at86rf230 platform data to configure the type of the
interrupt used by the driver. The irq polarity of the device will
be configured accordingly.

Signed-off-by: Sascha Herrmann 
Signed-off-by: David S. Miller

mrf24j40: use module_spi_driver to simplify the code

2013-04-09T17:19:38+00:00

module_spi_driver() makes the code simpler by eliminating
boilerplate code.

Signed-off-by: Wei Yongjun 
Signed-off-by: David S. Miller