linux-toradex.git/drivers/net/ipvlan, branch v6.12-rc4

netdev_features: convert NETIF_F_LLTX to dev->lltx

2024-09-03T09:36:43+00:00

NETIF_F_LLTX can't be changed via Ethtool and is not a feature,
rather an attribute, very similar to IFF_NO_QUEUE (and hot).
Free one netdev_features_t bit and make it a "hot" private flag.

Signed-off-by: Alexander Lobakin 
Signed-off-by: Paolo Abeni

ipvlan: Unmask upper DSCP bits in ipvlan_process_v4_outbound()

2024-08-31T16:44:51+00:00

Unmask the upper DSCP bits when calling ip_route_output_flow() so that
in the future it could perform the FIB lookup according to the full DSCP
value.

Signed-off-by: Ido Schimmel 
Reviewed-by: Guillaume Nault 
Signed-off-by: David S. Miller

ipvlan: Dont Use skb->sk in ipvlan_process_v{4,6}_outbound

2024-05-30T10:05:52+00:00

Raw packet from PF_PACKET socket ontop of an IPv6-backed ipvlan device will
hit WARN_ON_ONCE() in sk_mc_loop() through sch_direct_xmit() path.

WARNING: CPU: 2 PID: 0 at net/core/sock.c:775 sk_mc_loop+0x2d/0x70
Modules linked in: sch_netem ipvlan rfkill cirrus drm_shmem_helper sg drm_kms_helper
CPU: 2 PID: 0 Comm: swapper/2 Kdump: loaded Not tainted 6.9.0+ #279
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014
RIP: 0010:sk_mc_loop+0x2d/0x70
Code: fa 0f 1f 44 00 00 65 0f b7 15 f7 96 a3 4f 31 c0 66 85 d2 75 26 48 85 ff 74 1c
RSP: 0018:ffffa9584015cd78 EFLAGS: 00010212
RAX: 0000000000000011 RBX: ffff91e585793e00 RCX: 0000000002c6a001
RDX: 0000000000000000 RSI: 0000000000000040 RDI: ffff91e589c0f000
RBP: ffff91e5855bd100 R08: 0000000000000000 R09: 3d00545216f43d00
R10: ffff91e584fdcc50 R11: 00000060dd8616f4 R12: ffff91e58132d000
R13: ffff91e584fdcc68 R14: ffff91e5869ce800 R15: ffff91e589c0f000
FS:  0000000000000000(0000) GS:ffff91e898100000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f788f7c44c0 CR3: 0000000008e1a000 CR4: 00000000000006f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:

 ? __warn (kernel/panic.c:693)
 ? sk_mc_loop (net/core/sock.c:760)
 ? report_bug (lib/bug.c:201 lib/bug.c:219)
 ? handle_bug (arch/x86/kernel/traps.c:239)
 ? exc_invalid_op (arch/x86/kernel/traps.c:260 (discriminator 1))
 ? asm_exc_invalid_op (./arch/x86/include/asm/idtentry.h:621)
 ? sk_mc_loop (net/core/sock.c:760)
 ip6_finish_output2 (net/ipv6/ip6_output.c:83 (discriminator 1))
 ? nf_hook_slow (net/netfilter/core.c:626)
 ip6_finish_output (net/ipv6/ip6_output.c:222)
 ? __pfx_ip6_finish_output (net/ipv6/ip6_output.c:215)
 ipvlan_xmit_mode_l3 (drivers/net/ipvlan/ipvlan_core.c:602) ipvlan
 ipvlan_start_xmit (drivers/net/ipvlan/ipvlan_main.c:226) ipvlan
 dev_hard_start_xmit (net/core/dev.c:3594)
 sch_direct_xmit (net/sched/sch_generic.c:343)
 __qdisc_run (net/sched/sch_generic.c:416)
 net_tx_action (net/core/dev.c:5286)
 handle_softirqs (kernel/softirq.c:555)
 __irq_exit_rcu (kernel/softirq.c:589)
 sysvec_apic_timer_interrupt (arch/x86/kernel/apic/apic.c:1043)

The warning triggers as this:
packet_sendmsg
   packet_snd //skb->sk is packet sk
      __dev_queue_xmit
         __dev_xmit_skb //q->enqueue is not NULL
             __qdisc_run
               sch_direct_xmit
                 dev_hard_start_xmit
                   ipvlan_start_xmit
                      ipvlan_xmit_mode_l3 //l3 mode
                        ipvlan_process_outbound //vepa flag
                          ipvlan_process_v6_outbound
                            ip6_local_out
                                __ip6_finish_output
                                  ip6_finish_output2 //multicast packet
                                    sk_mc_loop //sk->sk_family is AF_PACKET

Call ip{6}_local_out() with NULL sk in ipvlan as other tunnels to fix this.

Fixes: 2ad7bf363841 ("ipvlan: Initial check-in of the IPVLAN driver.")
Suggested-by: Eric Dumazet 
Signed-off-by: Yue Haibing 
Reviewed-by: Eric Dumazet 
Link: https://lore.kernel.org/r/20240529095633.613103-1-yuehaibing@huawei.com
Signed-off-by: Paolo Abeni

ipvlan: handle NETDEV_DOWN event

2024-04-08T12:20:01+00:00

In case of stacked devices, to help propagate the down
link state from the parent/root device (to this leaf device),
handle NETDEV_DOWN event like it is done now for NETDEV_UP.

In the below example, ens5 is the host interface which is the
parent of the ipvlan interface eth0 in the container.

Host:

[root@gkn-podman-x64 ~]# ip link set ens5 down
[root@gkn-podman-x64 ~]# ip -d link show dev ens5
3: ens5:  mtu 9000 qdisc mq state DOWN
      ...
[root@gkn-podman-x64 ~]#

Container:

[root@testnode-ol8 /]# ip -d link show dev eth0
2: eth0@if3:  mtu 9000 state UNKNOWN
        ...
    ipvlan mode l2 bridge
        ...
[root@testnode-ol8 /]#

eth0's state continues to show up as UP even though ens5 is now DOWN.

For macvlan the handling of NETDEV_DOWN event was added in
commit 80fd2d6ca546 ("macvlan: Change status when lower device goes down").

Reported-by: Gia-Khanh Nguyen 
Signed-off-by: Venkat Venkatsubra 
Reviewed-by: Eric Dumazet 
Signed-off-by: David S. Miller

rtnetlink: prepare nla_put_iflink() to run under RCU

2024-02-26T11:46:12+00:00

We want to be able to run rtnl_fill_ifinfo() under RCU protection
instead of RTNL in the future.

This patch prepares dev_get_iflink() and nla_put_iflink()
to run either with RTNL or RCU held.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: fill in MODULE_DESCRIPTION()s for ipvtap

2024-02-09T22:12:02+00:00

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the IP-VLAN based tap driver.

Signed-off-by: Breno Leitao 
Reviewed-by: Simon Horman 
Link: https://lore.kernel.org/r/20240208164244.3818498-9-leitao@debian.org
Signed-off-by: Jakub Kicinski

ipvlan: Remove usage of the deprecated ida_simple_xx() API

2024-01-07T22:32:48+00:00

ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

This is less verbose.

Note that the upper bound of ida_alloc_range() is inclusive while the one
of ida_simple_get() was exclusive. So calls have been updated accordingly.

Signed-off-by: Christophe JAILLET 
Reviewed-by: Simon Horman 
Signed-off-by: David S. Miller

ipvlan: Fix a typo in a comment

2024-01-07T22:32:48+00:00

s/diffentiate/differentiate/

Signed-off-by: Christophe JAILLET 
Reviewed-by: Simon Horman 
Signed-off-by: David S. Miller

ipvlan: implement .parse_protocol hook function in ipvlan_header_ops

2023-12-05T12:42:08+00:00

The .parse_protocol hook function in the ipvlan_header_ops structure is
not implemented. As a result, when the AF_PACKET family is used to send
packets, skb->protocol will be set to 0.
Ipvlan is a device of type ARPHRD_ETHER (ether_setup). Therefore, use
eth_header_parse_protocol function to obtain the protocol.

Signed-off-by: Zhengchao Shao 
Reviewed-by: Willem de Bruijn 
Link: https://lore.kernel.org/r/20231202130438.2266343-1-shaozhengchao@huawei.com
Signed-off-by: Paolo Abeni

ipvlan: add ipvlan_route_v6_outbound() helper

2023-11-10T10:59:22+00:00

Inspired by syzbot reports using a stack of multiple ipvlan devices.

Reduce stack size needed in ipvlan_process_v6_outbound() by moving
the flowi6 struct used for the route lookup in an non inlined
helper. ipvlan_route_v6_outbound() needs 120 bytes on the stack,
immediately reclaimed.

Also make sure ipvlan_process_v4_outbound() is not inlined.

We might also have to lower MAX_NEST_DEV, because only syzbot uses
setups with more than four stacked devices.

BUG: TASK stack guard page was hit at ffffc9000e803ff8 (stack is ffffc9000e804000..ffffc9000e808000)
stack guard page: 0000 [#1] SMP KASAN
CPU: 0 PID: 13442 Comm: syz-executor.4 Not tainted 6.1.52-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/09/2023
RIP: 0010:kasan_check_range+0x4/0x2a0 mm/kasan/generic.c:188
Code: 48 01 c6 48 89 c7 e8 db 4e c1 03 31 c0 5d c3 cc 0f 0b eb 02 0f 0b b8 ea ff ff ff 5d c3 cc 00 00 cc cc 00 00 cc cc 55 48 89 e5 <41> 57 41 56 41 55 41 54 53 b0 01 48 85 f6 0f 84 a4 01 00 00 48 89
RSP: 0018:ffffc9000e804000 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffffff817e5bf2
RDX: 0000000000000000 RSI: 0000000000000008 RDI: ffffffff887c6568
RBP: ffffc9000e804000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: dffffc0000000001 R12: 1ffff92001d0080c
R13: dffffc0000000000 R14: ffffffff87e6b100 R15: 0000000000000000
FS: 00007fd0c55826c0(0000) GS:ffff8881f6800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffc9000e803ff8 CR3: 0000000170ef7000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<#DF>


[] __kasan_check_read+0x11/0x20 mm/kasan/shadow.c:31
[] instrument_atomic_read include/linux/instrumented.h:72 [inline]
[] _test_bit include/asm-generic/bitops/instrumented-non-atomic.h:141 [inline]
[] cpumask_test_cpu include/linux/cpumask.h:506 [inline]
[] cpu_online include/linux/cpumask.h:1092 [inline]
[] trace_lock_acquire include/trace/events/lock.h:24 [inline]
[] lock_acquire+0xe2/0x590 kernel/locking/lockdep.c:5632
[] rcu_lock_acquire+0x2e/0x40 include/linux/rcupdate.h:306
[] rcu_read_lock include/linux/rcupdate.h:747 [inline]
[] ip6_pol_route+0x15d/0x1440 net/ipv6/route.c:2221
[] ip6_pol_route_output+0x50/0x80 net/ipv6/route.c:2606
[] pol_lookup_func include/net/ip6_fib.h:584 [inline]
[] fib6_rule_lookup+0x265/0x620 net/ipv6/fib6_rules.c:116
[] ip6_route_output_flags_noref+0x2d9/0x3a0 net/ipv6/route.c:2638
[] ip6_route_output_flags+0xca/0x340 net/ipv6/route.c:2651
[] ip6_route_output include/net/ip6_route.h:100 [inline]
[] ipvlan_process_v6_outbound drivers/net/ipvlan/ipvlan_core.c:473 [inline]
[] ipvlan_process_outbound drivers/net/ipvlan/ipvlan_core.c:529 [inline]
[] ipvlan_xmit_mode_l3 drivers/net/ipvlan/ipvlan_core.c:602 [inline]
[] ipvlan_queue_xmit+0xc33/0x1be0 drivers/net/ipvlan/ipvlan_core.c:677
[] ipvlan_start_xmit+0x49/0x100 drivers/net/ipvlan/ipvlan_main.c:229
[] netdev_start_xmit include/linux/netdevice.h:4966 [inline]
[] xmit_one net/core/dev.c:3644 [inline]
[] dev_hard_start_xmit+0x320/0x980 net/core/dev.c:3660
[] __dev_queue_xmit+0x16b2/0x3370 net/core/dev.c:4324
[] dev_queue_xmit include/linux/netdevice.h:3067 [inline]
[] neigh_hh_output include/net/neighbour.h:529 [inline]
[] neigh_output include/net/neighbour.h:543 [inline]
[] ip6_finish_output2+0x160d/0x1ae0 net/ipv6/ip6_output.c:139
[] __ip6_finish_output net/ipv6/ip6_output.c:200 [inline]
[] ip6_finish_output+0x6c6/0xb10 net/ipv6/ip6_output.c:211
[] NF_HOOK_COND include/linux/netfilter.h:298 [inline]
[] ip6_output+0x2bc/0x3d0 net/ipv6/ip6_output.c:232
[] dst_output include/net/dst.h:444 [inline]
[] ip6_local_out+0x10f/0x140 net/ipv6/output_core.c:161
[] ipvlan_process_v6_outbound drivers/net/ipvlan/ipvlan_core.c:483 [inline]
[] ipvlan_process_outbound drivers/net/ipvlan/ipvlan_core.c:529 [inline]
[] ipvlan_xmit_mode_l3 drivers/net/ipvlan/ipvlan_core.c:602 [inline]
[] ipvlan_queue_xmit+0x1174/0x1be0 drivers/net/ipvlan/ipvlan_core.c:677
[] ipvlan_start_xmit+0x49/0x100 drivers/net/ipvlan/ipvlan_main.c:229
[] netdev_start_xmit include/linux/netdevice.h:4966 [inline]
[] xmit_one net/core/dev.c:3644 [inline]
[] dev_hard_start_xmit+0x320/0x980 net/core/dev.c:3660
[] __dev_queue_xmit+0x16b2/0x3370 net/core/dev.c:4324
[] dev_queue_xmit include/linux/netdevice.h:3067 [inline]
[] neigh_hh_output include/net/neighbour.h:529 [inline]
[] neigh_output include/net/neighbour.h:543 [inline]
[] ip6_finish_output2+0x160d/0x1ae0 net/ipv6/ip6_output.c:139
[] __ip6_finish_output net/ipv6/ip6_output.c:200 [inline]
[] ip6_finish_output+0x6c6/0xb10 net/ipv6/ip6_output.c:211
[] NF_HOOK_COND include/linux/netfilter.h:298 [inline]
[] ip6_output+0x2bc/0x3d0 net/ipv6/ip6_output.c:232
[] dst_output include/net/dst.h:444 [inline]
[] ip6_local_out+0x10f/0x140 net/ipv6/output_core.c:161
[] ipvlan_process_v6_outbound drivers/net/ipvlan/ipvlan_core.c:483 [inline]
[] ipvlan_process_outbound drivers/net/ipvlan/ipvlan_core.c:529 [inline]
[] ipvlan_xmit_mode_l3 drivers/net/ipvlan/ipvlan_core.c:602 [inline]
[] ipvlan_queue_xmit+0x1174/0x1be0 drivers/net/ipvlan/ipvlan_core.c:677
[] ipvlan_start_xmit+0x49/0x100 drivers/net/ipvlan/ipvlan_main.c:229
[] netdev_start_xmit include/linux/netdevice.h:4966 [inline]
[] xmit_one net/core/dev.c:3644 [inline]
[] dev_hard_start_xmit+0x320/0x980 net/core/dev.c:3660
[] __dev_queue_xmit+0x16b2/0x3370 net/core/dev.c:4324
[] dev_queue_xmit include/linux/netdevice.h:3067 [inline]
[] neigh_hh_output include/net/neighbour.h:529 [inline]
[] neigh_output include/net/neighbour.h:543 [inline]
[] ip6_finish_output2+0x160d/0x1ae0 net/ipv6/ip6_output.c:139
[] __ip6_finish_output net/ipv6/ip6_output.c:200 [inline]
[] ip6_finish_output+0x6c6/0xb10 net/ipv6/ip6_output.c:211
[] NF_HOOK_COND include/linux/netfilter.h:298 [inline]
[] ip6_output+0x2bc/0x3d0 net/ipv6/ip6_output.c:232
[] dst_output include/net/dst.h:444 [inline]
[] ip6_local_out+0x10f/0x140 net/ipv6/output_core.c:161
[] ipvlan_process_v6_outbound drivers/net/ipvlan/ipvlan_core.c:483 [inline]
[] ipvlan_process_outbound drivers/net/ipvlan/ipvlan_core.c:529 [inline]
[] ipvlan_xmit_mode_l3 drivers/net/ipvlan/ipvlan_core.c:602 [inline]
[] ipvlan_queue_xmit+0x1174/0x1be0 drivers/net/ipvlan/ipvlan_core.c:677
[] ipvlan_start_xmit+0x49/0x100 drivers/net/ipvlan/ipvlan_main.c:229
[] netdev_start_xmit include/linux/netdevice.h:4966 [inline]
[] xmit_one net/core/dev.c:3644 [inline]
[] dev_hard_start_xmit+0x320/0x980 net/core/dev.c:3660
[] __dev_queue_xmit+0x16b2/0x3370 net/core/dev.c:4324
[] dev_queue_xmit include/linux/netdevice.h:3067 [inline]
[] neigh_hh_output include/net/neighbour.h:529 [inline]
[] neigh_output include/net/neighbour.h:543 [inline]
[] ip6_finish_output2+0x160d/0x1ae0 net/ipv6/ip6_output.c:139
[] __ip6_finish_output net/ipv6/ip6_output.c:200 [inline]
[] ip6_finish_output+0x6c6/0xb10 net/ipv6/ip6_output.c:211
[] NF_HOOK_COND include/linux/netfilter.h:298 [inline]
[] ip6_output+0x2bc/0x3d0 net/ipv6/ip6_output.c:232
[] dst_output include/net/dst.h:444 [inline]
[] ip6_local_out+0x10f/0x140 net/ipv6/output_core.c:161
[] ipvlan_process_v6_outbound drivers/net/ipvlan/ipvlan_core.c:483 [inline]
[] ipvlan_process_outbound drivers/net/ipvlan/ipvlan_core.c:529 [inline]
[] ipvlan_xmit_mode_l3 drivers/net/ipvlan/ipvlan_core.c:602 [inline]
[] ipvlan_queue_xmit+0x1174/0x1be0 drivers/net/ipvlan/ipvlan_core.c:677
[] ipvlan_start_xmit+0x49/0x100 drivers/net/ipvlan/ipvlan_main.c:229
[] netdev_start_xmit include/linux/netdevice.h:4966 [inline]
[] xmit_one net/core/dev.c:3644 [inline]
[] dev_hard_start_xmit+0x320/0x980 net/core/dev.c:3660
[] __dev_queue_xmit+0x16b2/0x3370 net/core/dev.c:4324
[] dev_queue_xmit include/linux/netdevice.h:3067 [inline]
[] neigh_resolve_output+0x64e/0x750 net/core/neighbour.c:1560
[] neigh_output include/net/neighbour.h:545 [inline]
[] ip6_finish_output2+0x1643/0x1ae0 net/ipv6/ip6_output.c:139
[] __ip6_finish_output net/ipv6/ip6_output.c:200 [inline]
[] ip6_finish_output+0x6c6/0xb10 net/ipv6/ip6_output.c:211
[] NF_HOOK_COND include/linux/netfilter.h:298 [inline]
[] ip6_output+0x2bc/0x3d0 net/ipv6/ip6_output.c:232
[] dst_output include/net/dst.h:444 [inline]
[] NF_HOOK include/linux/netfilter.h:309 [inline]
[] ip6_xmit+0x11a4/0x1b20 net/ipv6/ip6_output.c:352
[] sctp_v6_xmit+0x9ae/0x1230 net/sctp/ipv6.c:250
[] sctp_packet_transmit+0x25de/0x2bc0 net/sctp/output.c:653
[] sctp_packet_singleton+0x202/0x310 net/sctp/outqueue.c:783
[] sctp_outq_flush_ctrl net/sctp/outqueue.c:914 [inline]
[] sctp_outq_flush+0x661/0x3d40 net/sctp/outqueue.c:1212
[] sctp_outq_uncork+0x79/0xb0 net/sctp/outqueue.c:764
[] sctp_side_effects net/sctp/sm_sideeffect.c:1199 [inline]
[] sctp_do_sm+0x55c0/0x5c30 net/sctp/sm_sideeffect.c:1170
[] sctp_primitive_ASSOCIATE+0x97/0xc0 net/sctp/primitive.c:73
[] sctp_sendmsg_to_asoc+0xf62/0x17b0 net/sctp/socket.c:1839
[] sctp_sendmsg+0x212e/0x33b0 net/sctp/socket.c:2029
[] inet_sendmsg+0x149/0x310 net/ipv4/af_inet.c:849
[] sock_sendmsg_nosec net/socket.c:716 [inline]
[] sock_sendmsg net/socket.c:736 [inline]
[] ____sys_sendmsg+0x572/0x8c0 net/socket.c:2504
[] ___sys_sendmsg net/socket.c:2558 [inline]
[] __sys_sendmsg+0x271/0x360 net/socket.c:2587
[] __do_sys_sendmsg net/socket.c:2596 [inline]
[] __se_sys_sendmsg net/socket.c:2594 [inline]
[] __x64_sys_sendmsg+0x7f/0x90 net/socket.c:2594
[] do_syscall_x64 arch/x86/entry/common.c:51 [inline]
[] do_syscall_64+0x53/0x80 arch/x86/entry/common.c:84
[] entry_SYSCALL_64_after_hwframe+0x63/0xcd

Fixes: 2ad7bf363841 ("ipvlan: Initial check-in of the IPVLAN driver.")
Reported-by: syzbot 
Signed-off-by: Eric Dumazet 
Cc: Mahesh Bandewar 
Cc: Willem de Bruijn 
Reviewed-by: Willem de Bruijn 
Signed-off-by: David S. Miller