linux-toradex.git/drivers/net/ixgbe, branch tegra

ixgbe: fix possible null buffer error

2011-09-21T06:14:13+00:00

It seems that at least one PPC machine would occasionally give a (valid) 0 as
the return value from dma_map, this caused the ixgbe code to not work
correctly.  A fix is pending in the PPC tree to not return 0 from dma map, but
we can also fix the driver to make sure we don't mess up in other arches as
well.

This patch is applicable to all current stable kernels.

Ref: https://bugzilla.redhat.com/show_bug.cgi?id=683611

Reported-by: Neil Horman 
Signed-off-by: Jesse Brandeburg 
CC: Alexander Duyck 
CC: stable@kernel.org
Tested-by: Thadeu Lima de Souza Cascardo 
Tested-by: Phil Schmitt 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

ixgbe: Fix FCOE memory leak for DDP packets

2011-08-13T09:10:27+00:00

This patch is meant to fix a memory leak found via code review for FCOE.
Specifically on DDP flows the SKBs were being dropped without being
recycled, freed, or given to the stack.

Signed-off-by: Alexander Duyck 
Tested-by: Ross Brattain 
Signed-off-by: Jeff Kirsher

ixgbe: fix PHY link setup for 82599

2011-08-04T12:06:13+00:00

Fix pointer to setup_link for 82599.

This resolves some link issues when advertising modes unsupported
by the link partner.

Signed-off-by: Emil Tantilov 
Tested-by: Phil Schmitt 
Signed-off-by: Jeff Kirsher

ixgbe: fix __ixgbe_notify_dca() bail out code

2011-08-04T12:03:27+00:00

The way __ixgbe_notify_dca() was currently set up it would not be
possible to add a requester. Both cases of the IXGBE_FLAG_DCA_ENABLED
bit being on and off would lead to the function exiting for a
DCA_PROVIDER_ADD.

Signed-off-by: Don Skidmore 
Tested-by: Phil Schmitt 
Signed-off-by: Jeff Kirsher

intel drivers: repair missing flush operations

2011-08-04T11:59:07+00:00

after review of all intel drivers, found several instances where
drivers had the incorrect pattern of:
memory mapped write();
delay();

which should always be:
memory mapped write();
write flush(); /* aka memory mapped read */
delay();

explanation:
The reason for including the flush is that writes can be held
(posted) in PCI/PCIe bridges, but the read always has to complete
synchronously and therefore has to flush all pending writes to a
device.  If a write is held and followed by a delay, the delay
means nothing because the write may not have reached hardware
(maybe even not until the next read)

Signed-off-by: Jesse Brandeburg 
Tested-by:  Aaron Brown 
Signed-off-by: Jeff Kirsher

ixgbe: convert to ndo_fix_features

2011-07-22T05:57:38+00:00

Private rx_csum flags are now duplicate of netdev->features &
NETIF_F_RXCSUM.  We remove those duplicates and now use the net_device_ops
ndo_set_features.  This was based on the original patch submitted by
Michal Miroslaw .  I also removed the special
case not requiring a reset for X540 hardware.  It is needed just as it is
in 82599 hardware.

Signed-off-by: Don Skidmore 
Cc:  Michal Miroslaw 
Tested-by: Phil Schmitt 
Signed-off-by: Jeff Kirsher

ixgbe: only enable WoL for magic packet by default

2011-07-22T05:57:15+00:00

Martin Wilck  reported that systems using
the ixgbe-driver that were capable of WoL were rebooting almost as soon
as they were shut down.  This is because the default WoL settings
enabled magic packet, broadcast, unicast, and multicast.

Other Intel devices seem to use the stored eeprom value for initial WoL
capabilities.  The 82578DM (e1000e) and 82576 (igb) the devices I looked
at had only the magic packet enabled in the eeprom, so that seems
appropriate on ixgbe-based devices as well.  I set the WoL options on my
82578DM to be the same default as the ixgbe devices (umbg) and saw the
same as Martin -- almost as soon as my box shutdown, it booted again.

This patch changes the default to only be the magic packet.  This is the
same as the default for most Intel and non-Intel hardware currently
upstream.

Signed-off-by: Andy Gospodarek 
CC: Martin Wilck 
Tested-by: Phil Schmitt 
Signed-off-by: Jeff Kirsher

ixgbe: remove ifdef check for non-existent define

2011-07-22T05:57:00+00:00

Signed-off-by: Emil Tantilov 
Tested-by: Phil Schmitt 
Signed-off-by: Jeff Kirsher

ixgbe: Pass staterr instead of re-reading status and error bits from descriptor

2011-07-22T05:56:37+00:00

This change is meant to address possible race conditions from the status
and error bits on the RX descriptors being re-read by multiple functions in
the RX cleanup path.  To resolve this I have added code that will pass the
staterr value to those functions.

Signed-off-by: Alexander Duyck 
Tested-by: Ross Brattain 
Signed-off-by: Jeff Kirsher

ixgbe: Move interrupt related values out of ring and into q_vector

2011-07-22T05:56:17+00:00

This change moves work_limit, total_packets, and total_bytes into the ring
container struct of the q_vector.  The advantage of this is that it should
reduce the size of memory used in the event of multiple rings being
assigned to a single q_vector.  In addition it should help to reduce the
total workload for calculating itr since now total_packets and total_bytes
will be the total work done of the interrupt instead of for the ring.

Signed-off-by: Alexander Duyck 
Tested-by: Ross Brattain 
Signed-off-by: Jeff Kirsher