linux-toradex.git/drivers/net/ixgbevf, branch tegra-11.2.9

e100/e1000/igb/ixgb*: Add missing read memory barrier

2010-08-09T03:02:45+00:00

Based on patches from Sonny Rao and Milton Miller...

Combined the patches to fix up clean_tx_irq and clean_rx_irq.

The PowerPC architecture does not require loads to independent bytes
to be ordered without adding an explicit barrier.

In ixgbe_clean_rx_irq we load the status bit then load the packet data.
With packet split disabled if these loads go out of order we get a
stale packet, but we will notice the bad sequence numbers and drop it.

The problem occurs with packet split enabled where the TCP/IP header
and data are in different descriptors. If the reads go out of order
we may have data that doesn't match the TCP/IP header. Since we use
hardware checksumming this bad data is never verified and it makes it
all the way to the application.

This bug was found during stress testing and adding this barrier has
been shown to fix it.  The bug can manifest as a data integrity issue
(bad payload data) or as a BUG in skb_pull().

This was a nasty bug to hunt down, if people agree with the fix I think
it's a candidate for stable.

Previously Submitted to e1000-devel only for ixgbe

http://marc.info/?l=e1000-devel&m=126593062701537&w=3

We've now seen this problem hit with other device drivers (e1000e mostly)
So I'm resubmitting with fixes for other Intel Device Drivers with
similar issues.

CC: Milton Miller 
CC: Anton Blanchard 
CC: Sonny Rao 
CC: stable 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

ixgbevf: fix null pointer dereference due to filter being set for VLAN 0

2010-08-03T04:20:21+00:00

This change corrects an issue that resulted in a null pointer dereference
for the addition of VLAN 0 without any VLANs being registered.  Also this
code removes some unnecessary checks for defines and the unnecessary setting
of VLAN flags since that is now handled within the kernel via the
vlan_features.

Signed-off-by: Alexander Duyck 
Tested-by: Emil Tantilov 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

igbvf, ixgbevf: use dev_hw_addr_random

2010-07-27T20:18:14+00:00

Both igbvf and ixgbevf should set addr_assign_type to NET_ADDR_RANDOM
so udev creates persistent net rules by matching the device path.
Do this by using the dev_hw_addr_random helper function.

Signed-off-by: Stefan Assmann 
Signed-off-by: David S. Miller

drivers: ixgbevf: fix unsigned underflow

2010-07-16T03:27:58+00:00

'count' is unsigned. It is initialized to zero, then it can be increased
multiple times, and finally it is used in such a way:

   >>>> count--;
   |
   |    /* clear timestamp and dma mappings for remaining portion of packet */
   |    while (count >= 0) {
   |            count--;
   |            ...
   ^
If count is zero here (so, it was never increased), we would have a very
long loop :)

Signed-off-by: Kulikov Vasiliy 
Signed-off-by: David S. Miller

ixgbevf: Enable GRO by default

2010-06-05T10:04:50+00:00

Enable GRO by default for performance.

Signed-off-by: Shirley Ma 
Acked-by: Greg Rose 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

drivers/net: Remove unnecessary returns from void function()s

2010-05-14T07:19:28+00:00

This patch removes from drivers/net/ all the unnecessary
return; statements that precede the last closing brace of
void functions.

It does not remove the returns that are immediately
preceded by a label as gcc doesn't like that.

It also does not remove null void functions with return.

Done via:
$ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
  xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'

with some cleanups by hand.

Compile tested x86 allmodconfig only.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

net: trans_start cleanups

2010-05-10T12:01:31+00:00

Now that core network takes care of trans_start updates, dont do it
in drivers themselves, if possible. Drivers can avoid one cache miss
(on dev->trans_start) in their start_xmit() handler.

Exceptions are NETIF_F_LLTX drivers

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

ixgbevf: Cache PF ack bit in interrupt

2010-05-06T07:31:45+00:00

When the PF acks a message from the VF the VF gets an interrupt.  It
must cache the ack bit so that polling SW will not miss the ack.  Also
avoid reading the message buffer on acks because that also will clear
the ack bit.

Signed-off-by: Greg Rose 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

ixgbevf: use DMA API instead of PCI DMA functions

2010-04-27T23:29:52+00:00

Signed-off-by: Nicholas Nunley 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

ixgbevf: Fix link speed display

2010-04-27T21:35:55+00:00

The ixgbevf driver would always report 10Gig speeds even when the link
speed is downshifted to 1Gig.  This patch fixes that problem.

Signed-off-by: Greg Rose 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller