linux-toradex.git/drivers/net/korina.c, branch tegra-10.8.3

netdev: drivers should make ethtool_ops const

2009-09-02T08:03:33+00:00

No need to put ethtool_ops in data, they should be const.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

korina: add error-handling to korina_alloc_ring

2009-08-13T23:26:12+00:00

This also avoids a potential buffer overflow in case the very first
receive descriptor fails to allocate, as an index of -1 would be used
afterwards. Kudos to Roel Kluin for pointing this out and providing an
initial patch.

Signed-off-by: Phil Sutter 
Signed-off-by: David S. Miller

korina: fix printk formatting, add final info line

2009-08-13T23:26:11+00:00

The macro DRV_NAME contains "korina", the field dev->name points to the
actual interface name. So messages were formerly prefixed with
'korinaeth2:' (on my system).

Signed-off-by: Phil Sutter 
Signed-off-by: David S. Miller

korina: periodically poll the media

2009-05-29T08:51:22+00:00

This patch makes the korina driver poll the media
for link change. This is actually required on
Mikrotik RB532 (not RB532A) for korina to
operate properly.

Signed-off-by: Felix Fietkau 
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

korina: convert to net_device_ops

2009-04-16T09:20:15+00:00

Signed-off-by: Alexander Beregalov 
Signed-off-by: David S. Miller

net: Remove redundant NAPI functions

2009-01-21T22:33:50+00:00

Following the removal of the unused struct net_device * parameter from
the NAPI functions named *netif_rx_* in commit 908a7a1, they are
exactly equivalent to the corresponding *napi_* functions and are
therefore redundant.

Signed-off-by: Ben Hutchings 
Acked-by: Neil Horman 
Signed-off-by: David S. Miller

korina: drop leftover assignment

2009-01-20T00:23:01+00:00

As the assigned value is being overwritten shortly after, it can be
dropped and so the whole variable definition moved to the start of the
function.

Signed-off-by: Phil Sutter 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller

korina: adjust headroom for new skb's also

2009-01-20T00:23:00+00:00

This is copy and paste from the original driver. As skb_reserve() is
also called within korina_alloc_ring() when initially allocating the
receive descriptors, the same should be done when allocating new space
after passing an skb to upper layers.

Signed-off-by: Phil Sutter 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller

korina: fix loop back of receive descriptors

2009-01-20T00:23:00+00:00

After the last loop iteration, i has the value RC32434_NUM_RDS and
therefore leads to an index overflow when used afterwards to address the
last element. This is yet another another bug introduced when rewriting
parts of the driver for upstream preparation, as the original driver
used 'RC32434_NUM_RDS - 1' instead.

Signed-off-by: Phil Sutter 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller

korina: do not use IRQF_SHARED with IRQF_DISABLED

2009-01-15T16:28:21+00:00

As the kernel warning states: "IRQF_DISABLED is not guaranteed on shared
IRQs". Since these IRQs' values are hardcoded and my test system doesn't
show any shared use of IRQs at all, rather make them non-shared than
non-disabled.

Signed-off-by: Phil Sutter 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller