linux-toradex.git/drivers/net/lib8390.c, branch v3.0.21

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

drivers/net: Remove unnecessary casts of netdev_priv

2010-11-17T18:37:52+00:00

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

8390: Don't oops on starting dev queue

2010-10-28T17:27:01+00:00

The __NS8390_init tries to start the device queue before the
device is registered. This results in an oops (snipped):

[    2.865493] BUG: unable to handle kernel NULL pointer dereference at 0000000000000010
[    2.866106] IP: [] netif_start_queue+0xb/0x12 [8390]
[    2.881267] Call Trace:
[    2.881437]  [] __NS8390_init+0x102/0x15a [8390]
[    2.881999]  [] NS8390_init+0x9/0xb [8390]
[    2.882237]  [] ne2k_pci_init_one+0x297/0x354 [ne2k_pci]
[    2.882955]  [] local_pci_probe+0x12/0x16
[    2.883308]  [] pci_device_probe+0xc3/0xef
[    2.884049]  [] driver_probe_device+0xbe/0x14b
[    2.884937]  [] __driver_attach+0x46/0x62
[    2.885170]  [] bus_for_each_dev+0x49/0x78
[    2.885781]  [] driver_attach+0x1c/0x1e
[    2.886089]  [] bus_add_driver+0xba/0x227
[    2.886330]  [] driver_register+0x9e/0x115
[    2.886933]  [] __pci_register_driver+0x50/0xac
[    2.887785]  [] ne2k_pci_init+0x2c/0x2e [ne2k_pci]
[    2.888093]  [] do_one_initcall+0x7c/0x130
[    2.888693]  [] sys_init_module+0x99/0x1da
[    2.888946]  [] system_call_fastpath+0x16/0x1b

This happens because the netif_start_queue sets respective bit on the dev->_tx
array which is not yet allocated.

As far as I understand the code removing the netif_start_queue from __NS8390_init
is OK, since queue will be started later on device open. Plz, correct me if I'm wrong.

Found in the Dave's current tree, so he's in Cc.

Signed-off-by: Pavel Emelyanov 
Signed-off-by: David S. Miller

drivers/net: Remove unnecessary returns from void function()s

2010-05-14T07:19:28+00:00

This patch removes from drivers/net/ all the unnecessary
return; statements that precede the last closing brace of
void functions.

It does not remove the returns that are immediately
preceded by a label as gcc doesn't like that.

It also does not remove null void functions with return.

Done via:
$ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
  xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'

with some cleanups by hand.

Compile tested x86 allmodconfig only.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

net: trans_start cleanups

2010-05-10T12:01:31+00:00

Now that core network takes care of trans_start updates, dont do it
in drivers themselves, if possible. Drivers can avoid one cache miss
(on dev->trans_start) in their start_xmit() handler.

Exceptions are NETIF_F_LLTX drivers

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: small cleanup of lib8390

2010-04-21T23:23:30+00:00

Remove the always true #if 1. Also the unecessary re-test of ei_local->irqlock
and the unreachable printk format string.

Signed-off-by: Nikanth Karthikesan 
Signed-off-by: David S. Miller

net: convert multicast list to list_head

2010-04-03T21:22:15+00:00

Converts the list and the core manipulating with it to be the same as uc_list.

+uses two functions for adding/removing mc address (normal and "global"
 variant) instead of a function parameter.
+removes dev_mcast.c completely.
+exposes netdev_hw_addr_list_* macros along with __hw_addr_* functions for
 manipulation with lists on a sandbox (used in bonding and 80211 drivers)

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: convert multiple drivers to use netdev_for_each_mc_addr, part5 V2

2010-02-26T10:07:30+00:00

removed some needless checks and also corrected bug in lp486e (dmi was passed
instead of dmi->dmi_addr)

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

drivers/net: Move && and || to end of previous line

2009-12-03T21:18:01+00:00

Only files where David Miller is the primary git-signer.
wireless, wimax, ixgbe, etc are not modified.

Compile tested x86 allyesconfig only
Not all files compiled (not x86 compatible)

Added a few > 80 column lines, which I ignored.
Existing checkpatch complaints ignored.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

netdev: convert bulk of drivers to netdev_tx_t

2009-09-01T08:14:07+00:00

In a couple of cases collapse some extra code like:
   int retval = NETDEV_TX_OK;
   ...
   return retval;
into
   return NETDEV_TX_OK;

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller