linux-toradex.git/drivers/net/macb.c, branch v2.6.31.3

drivers/net: fixed drivers that support netpoll use ndo_start_xmit()

2009-08-24T02:51:03+00:00

The NETPOLL API requires that interrupts remain disabled in
netpoll_send_skb(). The use of "A functions set" in the NETPOLL API
callbacks causes the interrupts to get enabled and can lead to kernel
instability.

The solution is to use "B functions set" to prevent the irqs from
getting enabled while in netpoll_send_skb().

A functions set:
local_irq_disable()/local_irq_enable()
spin_lock_irq()/spin_unlock_irq()
spin_trylock_irq()/spin_unlock_irq()

B functions set:
local_irq_save()/local_irq_restore()
spin_lock_irqsave()/spin_unlock_irqrestore()
spin_trylock_irqsave()/spin_unlock_irqrestore()

Signed-off-by: Dongdong Deng 
Acked-by: Matt Mackall 
Signed-off-by: David S. Miller

net: use symbolic values for ndo_start_xmit() return codes

2009-06-13T08:18:50+00:00

Convert magic values 1 and -1 to NETDEV_TX_BUSY and NETDEV_TX_LOCKED respectively.

0 (NETDEV_TX_OK) is not changed to keep the noise down, except in very few cases
where its in direct proximity to one of the other values.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

macb: Add support of the netpoll API

2009-05-04T18:08:41+00:00

With this patch in place, I'm successfully able to use the netconsole
mechanism with the Calao USB-A9263 board, which uses the AT91SAM9263
CPU, which in terms of Ethernet controller is supported by the macb
driver.

Signed-off-by: Thomas Petazzoni 
[haavard.skinnemoen@atmel.com: disable_irq() -> local_irq_save()]
[haavard.skinnemoen@atmel.com: convert to net_device_ops]
Signed-off-by: Haavard Skinnemoen 
Signed-off-by: David S. Miller

macb: process the RX ring regardless of interrupt status

2009-04-17T08:30:34+00:00

Suppose that we receive lots of frames, start processing them, but
exhaust our budget so that we return before we had a chance to look
at all of them.

Then, when the network layer calls us again, we will only continue
processing the buffers if the REC bit was set in the mean time, which it
might not be if there was a brief pause in the flow of packets. If this
happens, we'll simply display a warning and call netif_rx_complete()
with potentially lots of unprocessed packets in the RX ring...

Fix this by scanning the ring no matter what flags are set in the
interrupt status register.

Signed-off-by: Erik Waling 
Signed-off-by: Haavard Skinnemoen 
Signed-off-by: David S. Miller

macb: Handle Retry Limit Exceeded errors

2009-04-17T08:30:33+00:00

When transfering large amounts of data we sometimes experienced that the
Retry Limit Exceeded (RLE) bit got set in TSR during transmission
attempts. When this happened the driver would stall in a state that
prevented any more data from being sent.

Signed-off-by: Erik Waling 
Signed-off-by: Haavard Skinnemoen 
Signed-off-by: David S. Miller

macb: convert to net_device_ops

2009-04-13T22:16:27+00:00

Signed-off-by: Alexander Beregalov 
Signed-off-by: David S. Miller

macb: fix warning "warning: unused variable `dev' "

2009-03-24T23:30:20+00:00

Removed unused variable dev

Signed-off-by: vibi sreenivasan 
Signed-off-by: Haavard Skinnemoen 
Signed-off-by: David S. Miller

net: struct device - replace bus_id with dev_name(), dev_set_name()

2009-01-27T05:12:58+00:00

Signed-off-by: Kay Sievers 
Acked-by: Greg Kroah-Hartman 
Signed-off-by: David S. Miller

net: Remove redundant NAPI functions

2009-01-21T22:33:50+00:00

Following the removal of the unused struct net_device * parameter from
the NAPI functions named *netif_rx_* in commit 908a7a1, they are
exactly equivalent to the corresponding *napi_* functions and are
therefore redundant.

Signed-off-by: Ben Hutchings 
Acked-by: Neil Horman 
Signed-off-by: David S. Miller

macb: avoid lockup when TGO during underrun

2009-01-20T00:20:16+00:00

In rare cases when an underrun occur, all macb buffers where consumed
and the netif_queue was stopped infinitely. This happens then the TGO
(transfer ongoing) bit in the TSR is set (and UND). It seems like
clening up after the underrun makes the driver and the macb hardware
end up in an inconsistent state. The result of this is that in the
following calls to macb_tx no TX buffers are released -> the
netif_queue was stopped, and never woken up again.

The solution is to disable the transmitter, if TGO is set, before
clening up after the underrun, and re-enable the transmitter when the
cleaning up is done.

Signed-off-by: Richard Röjfors 
Signed-off-by: David S. Miller