linux-toradex.git/drivers/net/macvlan.c, branch v2.6.35

macvtap: Limit packet queue length

2010-07-22T20:08:56+00:00

Mark Wagner reported OOM symptoms when sending UDP traffic over
a macvtap link to a kvm receiver.

This appears to be caused by the fact that macvtap packet queues
are unlimited in length.  This means that if the receiver can't
keep up with the rate of flow, then we will hit OOM. Of course
it gets worse if the OOM killer then decides to kill the receiver.

This patch imposes a cap on the packet queue length, in the same
way as the tuntap driver, using the device TX queue length.

Please note that macvtap currently has no way of giving congestion
notification, that means the software device TX queue cannot be
used and packets will always be dropped once the macvtap driver
queue fills up.

This shouldn't be a great problem for the scenario where macvtap
is used to feed a kvm receiver, as the traffic is most likely
external in origin so congestion notification can't be applied
anyway.

Of course, if anybody decides to complain about guest-to-guest
UDP packet loss down the track, then we may have to revisit this.

Incidentally, this patch also fixes a real memory leak when
macvtap_get_queue fails.

Chris Wright noticed that for this patch to work, we need a
non-zero TX queue length.  This patch includes his work to change
the default macvtap TX queue length to 500.

Reported-by: Mark Wagner 
Signed-off-by: Herbert Xu 
Acked-by: Chris Wright 
Acked-by: Arnd Bergmann 
Signed-off-by: David S. Miller

macvlan: do proper cleanup in macvlan_common_newlink() V2

2010-05-25T01:42:12+00:00

Fixes possible memory leak.

Signed-off-by: Jiri Pirko 
Acked-by: Patrick McHardy 
Signed-off-by: David S. Miller

net: congestion notifications are not dropped packets

2010-05-16T07:42:15+00:00

vlan/macvlan start_xmit() can inform caller of congestion with
NET_XMIT_CN return value. This doesnt mean packet was dropped.
Increment normal stat counters instead of tx_dropped.

Signed-off-by: Eric Dumazet 
Acked-by: Patrick McHardy 
Signed-off-by: David S. Miller

net: adjust handle_macvlan to pass port struct to hook

2010-05-16T06:48:02+00:00

Now there's null check here and also again in the hook. Looking at bridge bits
which are simmilar, port structure is rcu_dereferenced right away in
handle_bridge and passed to hook. Looks nicer.

Signed-off-by: Jiri Pirko 
Acked-by: Patrick McHardy 
Signed-off-by: David S. Miller

net: move address list functions to a separate file

2010-04-03T21:22:11+00:00

+little renaming of unicast functions to be smooth with multicast ones

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: forbid underlaying devices to change its type

2010-03-19T03:00:02+00:00

It's not desired for underlaying devices to change type. At the time,
there is for example possible to have bond with changed type from
Ethernet to Infiniband as a port of a bridge. This patch fixes this.

Signed-off-by: Jiri Pirko 
Signed-off-by: Jay Vosburgh 
Signed-off-by: David S. Miller

macvlan: allow multiple driver backends

2010-02-04T04:20:33+00:00

This makes it possible to hook into the macvlan driver
from another kernel module. In particular, the goal is
to extend it with the macvtap backend that provides
a tun/tap compatible interface directly on the macvlan
device.

Signed-off-by: Arnd Bergmann 
Signed-off-by: David S. Miller

net: maintain namespace isolation between vlan and real device

2010-02-04T04:20:32+00:00

In the vlan and macvlan drivers, the start_xmit function forwards
data to the dev_queue_xmit function for another device, which may
potentially belong to a different namespace.

To make sure that classification stays within a single namespace,
this resets the potentially critical fields.

Signed-off-by: Arnd Bergmann 
Signed-off-by: David S. Miller

macvlan: add GRO bit to features mask

2010-01-16T09:05:38+00:00

Allow macvlan devices to support GRO.

Signed-off-by: Patrick Mullaney 
Acked-by: Patrick McHardy 
Signed-off-by: David S. Miller

netdevice: provide common routine for macvlan and vlan operstate management

2009-12-03T23:59:22+00:00

Provide common routine for the transition of operational state for a leaf
device during a root device transition.

Signed-off-by: Patrick Mullaney 
Acked-by: Arnd Bergmann 
Acked-by: Patrick McHardy 
Signed-off-by: David S. Miller