linux-toradex.git/drivers/net/macvtap.c, branch v3.3.5

macvtap: Fix macvtap_get_queue to use rxhash first

2011-12-20T18:45:55+00:00

It was reported that the macvtap device selects a
Acked-by: Michael S. Tsirkin 

Signed-off-by: David S. Miller

net: treewide use of RCU_INIT_POINTER

2011-11-23T23:48:19+00:00

rcu_assign_pointer(ptr, NULL) can be safely replaced by
RCU_INIT_POINTER(ptr, NULL)

(old rcu_assign_pointer() macro was testing the NULL value and could
omit the smp_wmb(), but this had to be removed because of compiler
warnings)

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

macvtap: Fix the minor device number allocation

2011-10-21T06:53:07+00:00

On systems that create and delete lots of dynamic devices the
31bit linux ifindex fails to fit in the 16bit macvtap minor,
resulting in unusable macvtap devices.  I have systems running
automated tests that that hit this condition in just a few days.

Use a linux idr allocator to track which mavtap minor numbers
are available and and to track the association between macvtap
minor numbers and macvtap network devices.

Remove the unnecessary unneccessary check to see if the network
device we have found is indeed a macvtap device.  With macvtap
specific data structures it is impossible to find any other
kind of networking device.

Increase the macvtap minor range from 65536 to the full 20 bits
that is supported by linux device numbers.  It doesn't solve the
original problem but there is no penalty for a larger minor
device range.

Signed-off-by: Eric W. Biederman 
Signed-off-by: David S. Miller

macvtap: Rewrite macvtap_newlink so the error handling works.

2011-10-21T06:53:07+00:00

Place macvlan_common_newlink at the end of macvtap_newlink because
failing in newlink after registering your network device is not
supported.

Move device_create into a netdevice creation notifier.   The network device
notifier is the only hook that is called after the network device has been
registered with the device layer and before register_network_device returns
success.

Signed-off-by: Eric W. Biederman 
Signed-off-by: David S. Miller

macvtap: Don't leak unreceived packets when we delete a macvtap device.

2011-10-21T06:53:07+00:00

To avoid leaking packets in the receive queue.  Add a socket destructor
that will run whenever destroy a macvtap socket.

Signed-off-by: Eric W. Biederman 
Signed-off-by: David S. Miller

macvtap: Fix macvtap_open races in the zero copy enable code.

2011-10-21T06:53:07+00:00

To see if it is appropriate to enable the macvtap zero copy feature
don't test the lowerdev network device flags.   Instead test the
macvtap network device flags which are a direct copy of the lowerdev
flags.  This is important because nothing holds a reference to lowerdev
and on a very bad day we lowerdev could be a pointer to stale memory.

Signed-off-by: Eric W. Biederman 
Signed-off-by: David S. Miller

macvtap: Close a race between macvtap_open and macvtap_dellink.

2011-10-21T06:53:06+00:00

There is a small window in macvtap_open between looking up a
networking device and calling macvtap_set_queue in which
macvtap_del_queues called from macvtap_dellink.   After
calling macvtap_del_queues it is totally incorrect to
allow macvtap_set_queue to proceed so prevent success by
reporting that all of the available queues are in use.

Signed-off-by: Eric W. Biederman 
Signed-off-by: David S. Miller

macvtap: fix the uninitialized var using in macvtap_alloc_skb()

2011-09-20T18:37:22+00:00

Commit d1b08284 use new frag API but would leave f to be used
uninitialized, this patch fix it.

Signed-off-by: Jason Wang 
Acked-by: Michael S. Tsirkin 
Acked-by: Ian Campbell 
Signed-off-by: David S. Miller

macvtap: convert to SKB paged frag API.

2011-09-15T19:34:59+00:00

Signed-off-by: Ian Campbell 
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller

macvtap: macvtapTX zero-copy support

2011-07-07T11:41:24+00:00

Only 128 bytes is copied, the rest of data is DMA mapped directly from
userspace.

Signed-off-by: Shirley Ma 
Signed-off-by: David S. Miller