linux-toradex.git/drivers/net/netconsole.c, branch v3.2-rc5

netconsole: enable netconsole can make net_device refcnt incorrent

2011-10-19T03:55:29+00:00

There is no check if netconsole is enabled current.
so when exec echo 1 > enabled;
the reference of net_device will increment always.

Signed-off-by: Gao feng 
Acked-by: Flavio Leitner 
Signed-off-by: David S. Miller

netconsole: switch init_netconsole() to late_initcall

2011-09-20T19:45:07+00:00

Commit 88491d8(drivers/net: Kconfig & Makefile cleanup) causes a
regression that netconsole does not work if netconsole and network
device driver are build into kernel, because netconsole is linked
before network device driver.

Andrew Morton suggested to fix this with initcall ordering.
Fixes it by switching init_netconsole() to late_initcall.

Signed-off-by: Lin Ming 
Signed-off-by: David S. Miller

net: rename NETDEV_BONDING_DESLAVE to NETDEV_RELEASE

2011-05-23T01:01:19+00:00

s/NETDEV_BONDING_DESLAVE/NETDEV_RELEASE/ as Andy suggested.

Signed-off-by: WANG Cong 
Cc: Andy Gospodarek 
Cc: Neil Horman 
Signed-off-by: David S. Miller

netpoll: disable netpoll when enslave a device

2011-05-23T01:01:19+00:00

V3: rename NETDEV_ENSLAVE to NETDEV_JOIN

Currently we do nothing when we enslave a net device which is running netconsole.
Neil pointed out that we may get weird results in such case, so let's disable
netpoll on the device being enslaved. I think it is too harsh to prevent
the device being ensalved if it is running netconsole.

By the way, this patch also removes the NETDEV_GOING_DOWN from netconsole
netdev notifier, because netpoll will check if the device is running or not
and we don't handle NETDEV_PRE_UP neither.

This patch is based on net-next-2.6.

Signed-off-by: WANG Cong 
Cc: Neil Horman 
Signed-off-by: David S. Miller

net: add mac_pton() for parsing MAC address

2011-05-09T19:10:49+00:00

mac_pton() parses MAC address in form XX:XX:XX:XX:XX:XX and only in that form.

mac_pton() doesn't dirty result until it's sure string representation is valid.

mac_pton() doesn't care about characters _after_ last octet,
it's up to caller to deal with it.

mac_pton() diverges from 0/-E return value convention.
Target usage:

	if (!mac_pton(str, whatever->mac))
		return -EINVAL;
	/* ->mac being u8 [ETH_ALEN] is filled at this point. */
	/* optionally check str[3 * ETH_ALEN - 1] for termination */

Use mac_pton() in pktgen and netconsole for start.

Signed-off-by: Alexey Dobriyan 
Signed-off-by: David S. Miller

netconsole: switch to kstrto*() functions

2011-05-09T19:10:48+00:00

Signed-off-by: Alexey Dobriyan 
Signed-off-by: David S. Miller

netconsole: fix deadlock when removing net driver that netconsole is using (v2)

2011-04-22T21:33:51+00:00

A deadlock was reported to me recently that occured when netconsole was being
used in a virtual guest.  If the virtio_net driver was removed while netconsole
was setup to use an interface that was driven by that driver, the guest
deadlocked.  No backtrace was provided because netconsole was the only console
configured, but it became clear pretty quickly what the problem was.  In
netconsole_netdev_event, if we get an unregister event, we call
__netpoll_cleanup with the target_list_lock held and irqs disabled.
__netpoll_cleanup can, if pending netpoll packets are waiting call
cancel_delayed_work_sync, which is a sleeping path.  the might_sleep call in
that path gets triggered, causing a console warning to be issued.  The
netconsole write handler of course tries to take the target_list_lock again,
which we already hold, causing deadlock.

The fix is pretty striaghtforward.  Simply drop the target_list_lock and
re-enable irqs prior to calling __netpoll_cleanup, the re-acquire the lock, and
restart the loop.  Confirmed by myself to fix the problem reported.

Signed-off-by: Neil Horman 
CC: "David S. Miller" 
Signed-off-by: David S. Miller

netconsole: clarify stopping message

2011-01-06T19:30:23+00:00

Signed-off-by: Ferenc Wagner 
Signed-off-by: David S. Miller

netconsole: don't announce stopping if nothing happened

2011-01-06T19:30:22+00:00

Signed-off-by: Ferenc Wagner 
Signed-off-by: David S. Miller

bonding: Fix netconsole to not deadlock on rmmod

2010-10-18T15:32:08+00:00

Netconsole calls netpoll_cleanup on receipt of a NETDEVICE_UNREGISTER event.
The notifier subsystem calls these event handlers with rtnl_lock held, which
netpoll_cleanup also takes, resulting in deadlock.  Fix this by calling the
__netpoll_cleanup interior function instead, and fixing up the additional
pointers.

Signed-off-by: Neil Horman 
Signed-off-by: David S. Miller