linux-toradex.git/drivers/net/phy/mdio_bus.c, branch v4.16-rc4

net: phy: Handle not having GPIO enabled in the kernel

2018-02-06T16:20:17+00:00

If CONFIG_GPIOLIB is disabled, fwnode_get_named_gpiod() becomes a stub
function, which return -ENOSYS. Handle this in the same way as
-ENOENT, i.e. assume there is no GPIO used to reset the PHYs.

Reported-by: Christian Zigotzky 
Tested-by: Christian Zigotzky 
Signed-off-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Fixes: bafbdd527d56 ("phylib: Add device reset GPIO support")
Signed-off-by: David S. Miller

net: mdio: Only perform gpio reset for PHYs

2018-01-03T16:08:10+00:00

Ethernet switch on the MDIO bus have historically performed their own
handling of the GPIO reset line. The resent patch to have the MDIO
core handle the reset has broken the switch drivers, in that they
cannot claim the GPIO. Some switch drivers need more control over the
GPIO line than what the MDIO core provides. So restore the historical
behaviour by only performing a reset of PHYs, not switches.

Fixes: bafbdd527d56 ("phylib: Add device reset GPIO support")
Reported-by: Sean Wang 
Signed-off-by: Andrew Lunn 
Reviewed-by: Geert Uytterhoeven 
Tested-by: Geert Uytterhoeven 
Signed-off-by: David S. Miller

net: mdiobus: add unlocked accessors

2018-01-03T16:00:22+00:00

Add unlocked versions of the bus accessors, which allows access to the
bus with all the tracing. These accessors validate that the bus mutex
is held, which is a basic requirement for all mii bus accesses.

Reviewed-by: Florian Fainelli 
Signed-off-by: Russell King 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2017-12-17T03:11:55+00:00

Three sets of overlapping changes, two in the packet scheduler
and one in the meson-gxl PHY driver.

Signed-off-by: David S. Miller

of_mdio / mdiobus: ensure mdio devices have fwnode correctly populated

2017-12-13T20:01:47+00:00

Ensure that all mdio devices populate the struct device fwnode pointer
as well as the of_node pointer to allow drivers that wish to use
fwnode APIs to work.

Signed-off-by: Russell King 
Reviewed-by: Rob Herring 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

phylib: Add device reset GPIO support

2017-12-05T17:51:19+00:00

The PHY devices sometimes do have their reset signal (maybe even power
supply?) tied to some GPIO and sometimes it also does happen that a boot
loader does not leave it deasserted. So far this issue has been attacked
from (as I believe) a wrong angle: by teaching the MAC driver to manipulate
the GPIO in question; that solution, when applied to the device trees, led
to adding the PHY reset GPIO properties to the MAC device node, with one
exception: Cadence MACB driver which could handle the "reset-gpios" prop
in a PHY device subnode. I believe that the correct approach is to teach
the 'phylib' to get the MDIO device reset GPIO from the device tree node
corresponding to this device -- which this patch is doing...

Note that I had to modify the AT803x PHY driver as it would stop working
otherwise -- it made use of the reset GPIO for its own purposes...

Signed-off-by: Sergei Shtylyov 
Acked-by: Rob Herring 
[geert: Propagate actual errors from fwnode_get_named_gpiod()]
[geert: Avoid destroying initial setup]
[geert: Consolidate GPIO descriptor acquiring code]
Signed-off-by: Geert Uytterhoeven 
Tested-by: Richard Leitner 
Signed-off-by: David S. Miller

Revert "mdio_bus: Remove unneeded gpiod NULL check"

2017-09-09T04:12:40+00:00

This reverts commit 95b80bf3db03c2bf572a357cf74b9a6aefef0a4a ("mdio_bus:
Remove unneeded gpiod NULL check"), this commit assumed that GPIOLIB
checks for NULL descriptors, so it's safe to drop them, but it is not
when CONFIG_GPIOLIB is disabled in the kernel. If we do call
gpiod_set_value_cansleep() on a GPIO descriptor we will issue warnings
coming from the inline stubs declared in include/linux/gpio/consumer.h.

Fixes: 95b80bf3db03 ("mdio_bus: Remove unneeded gpiod NULL check")
Reported-by: Woojung Huh 
Signed-off-by: Florian Fainelli 
Signed-off-by: Linus Walleij 
Acked-by: Linus Walleij 
Signed-off-by: David S. Miller

mdio_bus: Remove unneeded gpiod NULL check

2017-07-17T23:57:04+00:00

The gpiod API checks for NULL descriptors, so there is no need to
duplicate the check in the driver.

Signed-off-by: Fabio Estevam 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

mdio_bus: use devm_gpiod_get_optional()

2017-06-13T16:56:42+00:00

The MDIO reset GPIO is really a classical optional GPIO property case,
so devm_gpiod_get_optional() should have been used, not devm_gpiod_get().
Doing this  saves several LoCs...

Signed-off-by: Sergei Shtylyov 
Signed-off-by: David S. Miller

mdio_bus: handle only single PHY reset GPIO

2017-06-13T16:56:42+00:00

Commit 4c5e7a2c0501 ("dt-bindings: mdio: Clarify binding document")
declared that a MDIO reset GPIO property should have only a single GPIO
reference/specifier, however the supporting code was left intact, still
burdening the kernel with now apparently useless loops -- get rid of them.

Signed-off-by: Sergei Shtylyov 
Signed-off-by: David S. Miller