linux-toradex.git/drivers/net/phy/mscc/mscc_main.c, branch v5.9

net: phy: mscc: Fix a couple of spelling mistakes "spcified" -> "specified"

2020-08-20T18:10:12+00:00

There are a couple of spelling mistakes in comment text. Fix these.

Signed-off-by: Kaige Li 
Signed-off-by: David S. Miller

net: phy: mscc: improve vsc8514/8584_config_init consistency

2020-06-25T23:22:11+00:00

All PHY read and write return values are checked for errors in
vsc8514_config_init and vsc8584_config_init, except for one. Fix this.

Signed-off-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: remove useless page configuration in the config init

2020-06-25T23:22:11+00:00

In the middle of vsc8584_config_init and vsc8514_config_init, the page
is set to 'standard'. This is the default value, and the page isn't set
to another value before. Those pages configuration can be safely
removed.

Signed-off-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: restore the base page in vsc8514/8584_config_init

2020-06-25T23:22:11+00:00

In the vsc8584_config_init and vsc8514_config_init, the base page is set
to 'GPIO', configuration is done, and the page is never explicitly
restored to the standard page. No bug was triggered as it turns out
helpers called in those config_init functions do modify the base page,
and set it back to standard. But that is dangerous and any modification
to those functions would introduce bugs. This patch fixes this, to
improve maintenance, by restoring the base page to 'standard' once
'GPIO' accesses are completed.

Signed-off-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: do not access the MDIO bus lock directly

2020-06-25T23:22:11+00:00

This patch improves the MSCC driver by using the provided
phy_lock_mdio_bus and phy_unlock_mdio_bus helpers instead of locking and
unlocking the MDIO bus lock directly. The patch is only cosmetic but
should improve maintenance and consistency.

Signed-off-by: Antoine Tenart 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: mscc: fix a possible double unlock

2020-06-25T23:22:11+00:00

On vsc8584_ptp_init failure we jump to the 'err' label, which unlocks
the MDIO bus lock. But vsc8584_ptp_init isn't called with the MDIO bus
lock taken, which could result in a double unlock. Fix this.

Fixes: ab2bf9339357 ("net: phy: mscc: 1588 block initialization")
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 
Signed-off-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: timestamping and PHC support

2020-06-24T21:33:16+00:00

This patch adds support for PHC and timestamping operations for the MSCC
PHY. PTP 1-step and 2-step modes are supported, over Ethernet and UDP.

To get and set the PHC time, a GPIO has to be used and changes are only
retrieved or committed when on a rising edge. The same GPIO is shared by
all PHYs, so the granularity of the lock protecting it has to be
different from the ones protecting the 1588 registers (the VSC8584 PHY
has 2 1588 blocks, and a single load/save pin).

Co-developed-by: Quentin Schulz 
Signed-off-by: Quentin Schulz 
Signed-off-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: 1588 block initialization

2020-06-24T21:33:16+00:00

This patch adds the first parts of the 1588 support in the MSCC PHY,
with registers definition and the 1588 block initialization.

Those PHYs are distributed in hardware packages containing multiple
times the PHY. The VSC8584 for example is composed of 4 PHYs. With
hardware packages, parts of the logic is usually common and one of the
PHY has to be used for some parts of the initialization. Following this
logic, the 1588 blocks of those PHYs are shared between two PHYs and
accessing the registers has to be done using the "base" PHY of the
group. This is handled thanks to helpers in the PTP code (and locks).
We also need the MDIO bus lock while performing a single read or write
to the 1588 registers as the read/write are composed of multiple MDIO
transactions (and we don't want other threads updating the page).

Co-developed-by: Antoine Tenart 
Signed-off-by: Quentin Schulz 
Signed-off-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: remove the TR CLK disable magic value

2020-06-24T21:33:16+00:00

This patch adds a define for the 0x8000 magic value used to perform
enable/disable actions on the "token ring clock". The patch is only
cosmetic.

Signed-off-by: Quentin Schulz 
Signed-off-by: Antoine Tenart 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: mscc: fix Serdes configuration in vsc8584_config_init

2020-06-05T20:16:13+00:00

When converting the MSCC PHY driver to shared PHY packages, the Serdes
configuration in vsc8584_config_init was modified to use 'base_addr'
instead of 'base' as the port number. But 'base_addr' isn't equal to
'addr' for all PHYs inside the package, which leads to the Serdes still
being enabled on those ports. This patch fixes it.

Fixes: deb04e9c0ff2 ("net: phy: mscc: use phy_package_shared")
Signed-off-by: Antoine Tenart 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller