linux-toradex.git/drivers/net/phy/phy_device.c, branch v2.6.27.10

phylib: do EXPORT_SYMBOL on get_phy_id

2008-05-22T18:01:01+00:00

Commit cac1f3c8 factored out the code for get_phy_id so that it
could be reused in multiple places.  Turns out that some of the
users can be modular, so we need to export this symbol as well.

Signed-off-by: Paul Gortmaker 
Signed-off-by: Jeff Garzik

drivers/net/phy: fix kernel-doc notation

2008-04-29T05:55:55+00:00

Fix kernel-doc warning:
Warning(linux-2.6.25-git11//drivers/net/phy/phy_device.c:275): No
description found for parameter 'bus_id'

Signed-off-by: Randy Dunlap 
Signed-off-by: Jeff Garzik

phylib: Add support for board-level PHY fixups

2008-04-25T06:08:52+00:00

Sometimes the specific interaction between the platform and the PHY
requires special handling.  For instance, to change where the PHY's
clock input is, or to add a delay to account for latency issues in the
data path.  We add a mechanism for registering a callback with the PHY
Lib to be called on matching PHYs when they are brought up, or reset.

Signed-off-by: Andy Fleming 
Signed-off-by: Jeff Garzik

phylib: factor out get_phy_id from within get_phy_device

2008-04-17T19:31:33+00:00

We were already doing what amounts to a get_phy_id from within
get_phy_device, and rather than duplicate this for the TBIPA
probing, we might as well just factor it out and make it available
instead.

Signed-off-by: Paul Gortmaker 
Acked-by: Andy Fleming 
Signed-off-by: Jeff Garzik

PHYLIB: Locking fixes for PHY I/O potentially sleeping

2008-02-03T12:28:41+00:00

PHY read/write functions can potentially sleep (e.g., a PHY accessed
via I2C).  The following changes were made to account for this:

    * Change spin locks to mutex locks
    * Add a BUG_ON() to phy_read() phy_write() to warn against
      calling them from an interrupt context.
    * Use work queue for PHY state machine handling since
      it can potentially sleep
    * Change phydev lock from spinlock to mutex

Signed-off-by: Nate Case 
Acked-by: Andy Fleming 
Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

PHY: Add the phy_device_release device method.

2007-12-04T20:06:33+00:00

Lately I've got this nice badness on mdio bus removal:

Device 'e0103120:06' does not have a release() function, it is broken and must be fixed.
------------[ cut here ]------------
Badness at drivers/base/core.c:107
NIP: c015c1a8 LR: c015c1a8 CTR: c0157488
REGS: c34bdcf0 TRAP: 0700   Not tainted  (2.6.23-rc5-g9ebadfbb-dirty)
MSR: 00029032   CR: 24088422  XER: 00000000
...
[c34bdda0] [c015c1a8] device_release+0x78/0x80 (unreliable)
[c34bddb0] [c01354cc] kobject_cleanup+0x80/0xbc
[c34bddd0] [c01365f0] kref_put+0x54/0x6c
[c34bdde0] [c013543c] kobject_put+0x24/0x34
[c34bddf0] [c015c384] put_device+0x1c/0x2c
[c34bde00] [c0180e84] mdiobus_unregister+0x2c/0x58
...

Though actually there is nothing broken, it just device
subsystem core expects another "pattern" of resource managment.

This patch implement phy device's release function, thus
we're getting rid of this badness.

Also small hidden bug fixed, hope none other introduced. ;-)

Signed-off-by: Anton Vorontsov 
Acked-by: Andy Fleming 
Signed-off-by: Jeff Garzik

phylib: Silence driver registration

2007-11-05T22:58:36+00:00

It gets quite verbose to see every single PHY driver being registered
by default.

Signed-off-by: Olof Johansson 
Signed-off-by: Jeff Garzik

PHYLIB: Spinlock fixes for softirqs

2007-10-10T23:53:54+00:00

Use spin_lock_bh()/spin_unlock_bh() for the phydev lock throughout as it
is used in phy_timer() that is called as a softirq and all the other
operations may happen in the user context.

There has been a change recently that did such a conversion for some of the
operations on the lock, but some have been left intact.  Many of them,
perhaps all, may be called in the user context and I was able to trigger
recursive spinlock acquisition indeed, so I think for the sake of long-term
maintenance it is best to convert them all, even if unnecessarily for one
or two -- better safe than sorry.

Perhaps one in phy_timer() could actually be skipped as only called as a
softirq -- I can send an update if that sounds like a good idea.

Checked with checkpatch.pl and at the runtime.

Signed-off-by: Maciej W. Rozycki 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik

Fix a lock problem in generic phy code

2007-09-13T04:12:43+00:00

Lock debugging finds a problem in phy.c and phy_device.c,
this patch fixes it. Tested on an AT91SAM9263-EK board,
kernel 2.6.23-rc4.

Signed-off-by: Hans J. Koch 
Signed-off-by: Jeff Garzik

phy layer: fix genphy_setup_forced (don't reset)

2007-08-25T06:31:02+00:00

Writing BMCR_RESET bit will reset MII_BMCR to default values. This is
clearly not what we want.

Signed-off-by: Domen Puncer 
Signed-off-by: Jeff Garzik