linux-toradex.git/drivers/net/phy, branch v4.16-rc6

net: phy: Restore phy_resume() locking assumption

2018-02-27T19:32:09+00:00

commit f5e64032a799 ("net: phy: fix resume handling") changes the
locking semantics for phy_resume() such that the caller now needs to
hold the phy mutex. Not all call sites were adopted to this new
semantic, resulting in warnings from the added
WARN_ON(!mutex_is_locked(&phydev->lock)).  Rather than change the
semantics, add a __phy_resume() and restore the old behavior of
phy_resume().

Reported-by: Heiner Kallweit 
Fixes: f5e64032a799 ("net: phy: fix resume handling")
Signed-off-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: phy: fix wrong mask to phy_modify()

2018-02-12T16:42:48+00:00

When forcing a specific link mode, the PHY driver must clear the
existing speed and duplex bits in BMCR while preserving some other
control bits. This logic was accidentally inverted with the introduction
of phy_modify().

Fixes: fea23fb591cc ("net: phy: convert read-modify-write to phy_modify()")
Signed-off-by: Ingo van Lil 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

2018-02-08T20:35:51+00:00

This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added
long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates
also PHY state changes and we should do what the symbol says.

Fixes: 84a527a41f38 ("net: phylib: fix interrupts re-enablement in phy_start")
Signed-off-by: Heiner Kallweit 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: phy: Handle not having GPIO enabled in the kernel

2018-02-06T16:20:17+00:00

If CONFIG_GPIOLIB is disabled, fwnode_get_named_gpiod() becomes a stub
function, which return -ENOSYS. Handle this in the same way as
-ENOENT, i.e. assume there is no GPIO used to reset the PHYs.

Reported-by: Christian Zigotzky 
Tested-by: Christian Zigotzky 
Signed-off-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Fixes: bafbdd527d56 ("phylib: Add device reset GPIO support")
Signed-off-by: David S. Miller

net: phy: sfp: Fix kernel doc warning

2018-01-23T16:06:50+00:00

We forgot to update the kernel doc header above sfp_register_upstream()

Fixes: c19bb00070dd ("sfp: convert to fwnode")
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

phy: realtek: use new helpers for paged register access

2018-01-16T18:56:33+00:00

Make use of the new helpers for paged register access.

Signed-off-by: Heiner Kallweit 
Signed-off-by: David S. Miller

phy: use new helpers phy_set_bits/phy_clear_bits in phylib

2018-01-16T17:25:10+00:00

Use new helpers phy_set_bits / phy_clear_bits in phylib.

Signed-off-by: Heiner Kallweit 
Signed-off-by: David S. Miller

net: phy: remove parameter new_link from phy_mac_interrupt()

2018-01-15T18:45:03+00:00

I see two issues with parameter new_link:

1. It's not needed. See also phy_interrupt(), works w/o this parameter.
   phy_mac_interrupt sets the state to PHY_CHANGELINK and triggers the
   state machine which then calls phy_read_status. And phy_read_status
   updates the link state.

2. phy_mac_interrupt is used in interrupt context and getting the link
   state may sleep (at least when having to access the PHY registers
   via MDIO bus).

So let's remove it.

Signed-off-by: Heiner Kallweit 
Reviewed-by: Florian Fainelli 
Tested-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: phy: Have __phy_modify return 0 on success

2018-01-15T17:49:30+00:00

__phy_modify would return the old value of the register before it was
modified. Thus on success, it does not return 0, but a positive value.
Thus functions using phy_modify, which is a wrapper around
__phy_modify, can start returning > 0 on success, rather than 0. As a
result, breakage has been noticed in various places, where 0 was
assumed.

Code inspection does not find any current location where the return of
the old value is currently used. So have __phy_modify return 0 on
success. When there is a real need for the old value, either a new
accessor can be added, or an additional parameter passed.

Fixes: fea23fb591cc ("net: phy: convert read-modify-write to phy_modify()")
Fixes: 2b74e5be17d2 ("net: phy: add phy_modify() accessor")
Reported-by: Geert Uytterhoeven 
Tested-by: Geert Uytterhoeven 
Signed-off-by: Andrew Lunn 
Tested-by: Niklas Cassel 
Signed-off-by: David S. Miller

net: phy: mdio-bcm-unimac: fix potential NULL dereference in unimac_mdio_probe()

2018-01-11T18:56:24+00:00

platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Signed-off-by: Wei Yongjun 
Signed-off-by: David S. Miller