linux-toradex.git/drivers/net/ppp_async.c, branch v2.6.29

drivers/net: Remove redundant test

2008-12-26T02:03:28+00:00

In each case, ap is checked not to be NULL a few lines before.

A simplified version of the semantic patch that makes this change is as
follows: (http://www.emn.fr/x-info/coccinelle/)

// 
@r exists@
local idexpression x;
expression E;
position p1,p2;
@@

if (x@p1 == NULL || ...) { ... when forall
   return ...; }
... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
(
x@p2 == NULL
|
x@p2 != NULL
)

// another path to the test that is not through p1?
@s exists@
local idexpression r.x;
position r.p1,r.p2;
@@

... when != x@p1
(
x@p2 == NULL
|
x@p2 != NULL
)

@fix depends on !s@
position r.p1,r.p2;
expression x,E;
statement S1,S2;
@@

(
- if ((x@p2 != NULL) || ...)
  S1
|
- if ((x@p2 == NULL) && ...) S1
|
- BUG_ON(x@p2 == NULL);
)
// 

Signed-off-by: Julia Lawall 
Signed-off-by: David S. Miller

tty: Ldisc revamp

2008-07-21T00:12:34+00:00

Move the line disciplines towards a conventional ->ops arrangement.  For
the moment the actual 'tty_ldisc' struct in the tty is kept as part of
the tty struct but this can then be changed if it turns out that when it
all settles down we want to refcount ldiscs separately to the tty.

Pull the ldisc code out of /proc and put it with our ldisc code.

Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

tty: add throttle/unthrottle helpers

2008-04-30T15:29:47+00:00

Something Arjan suggested which allows us to clean up the code nicely

Signed-off-by: Alan Cox 
Cc: Arjan van de Ven 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tty: The big operations rework

2008-04-30T15:29:47+00:00

- Operations are now a shared const function block as with most other Linux
  objects

- Introduce wrappers for some optional functions to get consistent behaviour

- Wrap put_char which used to be patched by the tty layer

- Document which functions are needed/optional

- Make put_char report success/fail

- Cache the driver->ops pointer in the tty as tty->ops

- Remove various surplus lock calls we no longer need

- Remove proc_write method as noted by Alexey Dobriyan

- Introduce some missing sanity checks where certain driver/ldisc
  combinations would oops as they didn't check needed methods were present

[akpm@linux-foundation.org: fix fs/compat_ioctl.c build]
[akpm@linux-foundation.org: fix isicom]
[akpm@linux-foundation.org: fix arch/ia64/hp/sim/simserial.c build]
[akpm@linux-foundation.org: fix kgdb]
Signed-off-by: Alan Cox 
Acked-by: Greg Kroah-Hartman 
Cc: Jason Wessel 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PPP]: Remove ptr comparisons to 0

2007-11-13T02:07:31+00:00

fix sparse warnings "Using plain integer as NULL pointer"

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

[TTY]: Use tty_mode_ioctl() in network drivers.

2007-11-07T12:14:24+00:00

We conciously make a change here - we permit mode and speed setting to
be done in things like SLIP mode. There isn't actually a technical
reason to disallow this. It's usually a silly thing to do but we can
do it and soemone might wish to do so.

Signed-off-by: Alan Cox 
Signed-off-by: David S. Miller

some kmalloc/memset ->kzalloc (tree wide)

2007-07-19T17:04:50+00:00

Transform some calls to kmalloc/memset to a single kzalloc (or kcalloc).

Here is a short excerpt of the semantic patch performing
this transformation:

@@
type T2;
expression x;
identifier f,fld;
expression E;
expression E1,E2;
expression e1,e2,e3,y;
statement S;
@@

 x =
- kmalloc
+ kzalloc
  (E1,E2)
  ...  when != \(x->fld=E;\|y=f(...,x,...);\|f(...,x,...);\|x=E;\|while(...) S\|for(e1;e2;e3) S\)
- memset((T2)x,0,E1);

@@
expression E1,E2,E3;
@@

- kzalloc(E1 * E2,E3)
+ kcalloc(E1,E2,E3)

[akpm@linux-foundation.org: get kcalloc args the right way around]
Signed-off-by: Yoann Padioleau 
Cc: Richard Henderson 
Cc: Ivan Kokshaysky 
Acked-by: Russell King 
Cc: Bryan Wu 
Acked-by: Jiri Slaby 
Cc: Dave Airlie 
Acked-by: Roland Dreier 
Cc: Jiri Kosina 
Acked-by: Dmitry Torokhov 
Cc: Benjamin Herrenschmidt 
Acked-by: Mauro Carvalho Chehab 
Acked-by: Pierre Ossman 
Cc: Jeff Garzik 
Cc: "David S. Miller" 
Acked-by: Greg KH 
Cc: James Bottomley 
Cc: "Antonino A. Daplas" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PPP]: Fix skbuff.c:BUG due incorrect logic in process_input_packet()

2007-04-19T20:05:52+00:00

From: Paul Mackerras 

This fixes:

Subject: kernel BUG at net/core/skbuff.c in linux-2.6.21-rc6

process_input_packet() treats the case where the first byte is 0xff
(PPP_ALLSTATIONS) but the second byte is 0x03 (PPP_UI) as indicating a
packet with a PPP protocol number of 0xff.  Arguably that's wrong
since PPP protocol 0xff is reserved, and the RFC does envision the
possibility of receiving frames where the control field has values
other than 0x03.

Signed-off-by: David S. Miller

drivers/net: Trim trailing whitespace

2006-09-13T17:24:59+00:00

Signed-off-by: Jeff Garzik

[PATCH] drivers/net/*: use time_after() and friends

2006-01-17T12:59:23+00:00

They deal with wrapping correctly and are nicer to read.  Also make
jiffies-holding variables unsigned long.

Signed-off-by: Marcelo Feitoza Parisi 
Signed-off-by: Alexey Dobriyan 
Cc: Jeff Garzik 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik